From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CCF3ECAAA3 for ; Thu, 25 Aug 2022 21:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/PsTTcmzJ481y1xcy4yYjtiykQQSwGwWJ+A8v6lfdnQ=; b=znzEYndDXU8J5m Dq5ki5QzNv4iHHvb0vzZJLl0PaMa396xQIzHDuB6FkNNkOQ/I7VyXTpJh0Tgb4f0hL5MopwwnnNoB EyxMF1v5b29TcV4wWCuPDt0g/BX0JKput51hbCvYuKNbpQDSe8ji578jjNesJ5oN+x+CaYd8diHHw najJDnREZE6LqWYSD/wG/zBe0pkgZsgcK8pssJRDw3MY638a6D97CDwS7RaCcq2st26Hz5Ywxh7Z1 ArmA4feNBt6YOl+DRsbWCDJKKYRCQsUJWBjXb8iTz1qE9WA3si3WVjrNHu7KYWYvmb2fADTZd7X4b BP0vwi+Grzj4Yqgjb2YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRKIE-003PWU-23; Thu, 25 Aug 2022 21:21:38 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRKIA-003PVB-4v for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 21:21:35 +0000 Received: by mail-oi1-f174.google.com with SMTP id j5so24848970oih.6 for ; Thu, 25 Aug 2022 14:21:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=P5RpiV54xqAQLIQ9ti/eGfwgmfPwohj6xoxpANXur1M=; b=KhDmmiNQd3DMWVMg0D2jFgNLRFxrevJZrDQAlhP4+xlMgzPS6b+7GyfqAMRlq8xxtx MIHmYm67jTfPhpOSIPDyZjqeBHDzF6STCBSQOk6QYQfXfJhZiuVv65ferbn4ekX+CtzD EAtBQD6+UMqxQkcjj0Wbiy7psQC+SGDYkqkbbh84ECYpND7j3MGDLsXhoJGoM56yT8gW Q+QClUB+lkSRRY542pFfmBqtlrfVCujwkrryIlyUvd1+qtFtQb/mIrqKP3n6sKW8LnGG yecijZjhl48YavlyN0D95LsbPSHmOpupdt50XZldYsvtZONKeGDFWBX7qGsp6M8Lcvkx XLfw== X-Gm-Message-State: ACgBeo3wrWjgB1PokAM4swHgIF2OSZ0U2pu+hcFrCLYQyA2CP6AVIYRv rnnAI7taWMPn24aSgsl70xQXVLnGYw== X-Google-Smtp-Source: AA6agR5/0JfId/JjJ0kohOyVrYVEqVArMvPe43p5PabjDPHZudT8GG3n1U2UdnD7kxSyi1MSSSrDoQ== X-Received: by 2002:a05:6808:e85:b0:345:4fc2:4444 with SMTP id k5-20020a0568080e8500b003454fc24444mr401838oil.245.1661462492547; Thu, 25 Aug 2022 14:21:32 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e20-20020a056830201400b006394756c04fsm119369otp.0.2022.08.25.14.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 14:21:32 -0700 (PDT) Received: (nullmailer pid 1709275 invoked by uid 1000); Thu, 25 Aug 2022 21:21:30 -0000 Date: Thu, 25 Aug 2022 16:21:30 -0500 From: Rob Herring To: Frank Li Cc: maz@kernel.org, tglx@linutronix.de, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kw@linux.com, bhelgaas@google.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, peng.fan@nxp.com, aisheng.dong@nxp.com, jdmason@kudzu.us, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.com, ntb@lists.linux.dev, lznuaa@gmail.com Subject: Re: [PATCH v7 3/4] dt-bindings: irqchip: imx mu work as msi controller Message-ID: <20220825212130.GA1705214-robh@kernel.org> References: <20220822155130.2491006-1-Frank.Li@nxp.com> <20220822155130.2491006-4-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220822155130.2491006-4-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_142134_217551_95156967 X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 22, 2022 at 10:51:29AM -0500, Frank Li wrote: > I.MX mu support generate irq by write a register. Provide msi controller > support so other driver such as PCI EP can use it by standard msi > interface as doorbell. > > Signed-off-by: Frank Li > --- > .../interrupt-controller/fsl,mu-msi.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml > new file mode 100644 > index 0000000000000..ac07b138e24c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/fsl,mu-msi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale/NXP i.MX Messaging Unit (MU) work as msi controller > + > +maintainers: > + - Frank Li > + > +description: | > + The Messaging Unit module enables two processors within the SoC to > + communicate and coordinate by passing messages (e.g. data, status > + and control) through the MU interface. The MU also provides the ability > + for one processor (A side) to signal the other processor (B side) using > + interrupts. > + > + Because the MU manages the messaging between processors, the MU uses > + different clocks (from each side of the different peripheral buses). > + Therefore, the MU must synchronize the accesses from one side to the > + other. The MU accomplishes synchronization using two sets of matching > + registers (Processor A-facing, Processor B-facing). > + > + MU can work as msi interrupt controller to do doorbell > + > +allOf: > + - $ref: /schemas/interrupt-controller/msi-controller.yaml# > + > +properties: > + compatible: > + enum: > + - fsl,imx6sx-mu-msi > + - fsl,imx7ulp-mu-msi > + - fsl,imx8ulp-mu-msi > + - fsl,imx8ulp-mu-msi-s4 > + > + reg: > + items: > + - description: a side register base address > + - description: b side register base address > + > + reg-names: > + items: > + - const: processor a-facing > + - const: processor b-facing Isn't 'a' and 'b' sufficient to distinguish? Personally, doesn't really look like a case that benefits from -names at all. In any case, -names shouldn't have spaces. > + > + interrupts: > + description: a side interrupt number. > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + power-domains: > + items: > + - description: a side power domain > + - description: b side power domain > + > + power-domain-names: > + items: > + - const: processor a-facing > + - const: processor b-facing Same here. > + > + interrupt-controller: true > + > + msi-controller: true > + > + "#msi-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-controller > + - msi-controller #msi-cells should be required. > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + msi-controller@5d270000 { > + compatible = "fsl,imx6sx-mu-msi"; > + msi-controller; > + #msi-cells = <0>; > + interrupt-controller; > + reg = <0x5d270000 0x10000>, /* A side */ > + <0x5d300000 0x10000>; /* B side */ > + reg-names = "processor a-facing", "processor b-facing"; > + interrupts = ; > + power-domains = <&pd IMX_SC_R_MU_12A>, > + <&pd IMX_SC_R_MU_12B>; > + power-domain-names = "processor a-facing", "processor b-facing"; > + }; > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel