From: Corentin Labbe <clabbe@baylibre.com>
To: heiko@sntech.de, herbert@gondor.apana.org.au, ardb@kernel.org,
davem@davemloft.net, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, robh+dt@kernel.org, sboyd@kernel.org
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
Corentin Labbe <clabbe@baylibre.com>,
John Keeping <john@metanate.com>
Subject: [PATCH v9 11/33] crypto: rockchip: rewrite type
Date: Thu, 1 Sep 2022 12:56:48 +0000 [thread overview]
Message-ID: <20220901125710.3733083-12-clabbe@baylibre.com> (raw)
In-Reply-To: <20220901125710.3733083-1-clabbe@baylibre.com>
Instead of using a custom type for classify algorithms, let's just use
already defined ones.
And let's made a bit more verbose about what is registered.
Reviewed-by: John Keeping <john@metanate.com>
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
drivers/crypto/rockchip/rk3288_crypto.c | 26 +++++++++++++------
drivers/crypto/rockchip/rk3288_crypto.h | 7 +----
drivers/crypto/rockchip/rk3288_crypto_ahash.c | 6 ++---
.../crypto/rockchip/rk3288_crypto_skcipher.c | 12 ++++-----
4 files changed, 28 insertions(+), 23 deletions(-)
diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c
index 1afb65eee6c9..8f9664acc78d 100644
--- a/drivers/crypto/rockchip/rk3288_crypto.c
+++ b/drivers/crypto/rockchip/rk3288_crypto.c
@@ -102,12 +102,22 @@ static int rk_crypto_register(struct rk_crypto_info *crypto_info)
for (i = 0; i < ARRAY_SIZE(rk_cipher_algs); i++) {
rk_cipher_algs[i]->dev = crypto_info;
- if (rk_cipher_algs[i]->type == ALG_TYPE_CIPHER)
- err = crypto_register_skcipher(
- &rk_cipher_algs[i]->alg.skcipher);
- else
- err = crypto_register_ahash(
- &rk_cipher_algs[i]->alg.hash);
+ switch (rk_cipher_algs[i]->type) {
+ case CRYPTO_ALG_TYPE_SKCIPHER:
+ dev_info(crypto_info->dev, "Register %s as %s\n",
+ rk_cipher_algs[i]->alg.skcipher.base.cra_name,
+ rk_cipher_algs[i]->alg.skcipher.base.cra_driver_name);
+ err = crypto_register_skcipher(&rk_cipher_algs[i]->alg.skcipher);
+ break;
+ case CRYPTO_ALG_TYPE_AHASH:
+ dev_info(crypto_info->dev, "Register %s as %s\n",
+ rk_cipher_algs[i]->alg.hash.halg.base.cra_name,
+ rk_cipher_algs[i]->alg.hash.halg.base.cra_driver_name);
+ err = crypto_register_ahash(&rk_cipher_algs[i]->alg.hash);
+ break;
+ default:
+ dev_err(crypto_info->dev, "unknown algorithm\n");
+ }
if (err)
goto err_cipher_algs;
}
@@ -115,7 +125,7 @@ static int rk_crypto_register(struct rk_crypto_info *crypto_info)
err_cipher_algs:
for (k = 0; k < i; k++) {
- if (rk_cipher_algs[i]->type == ALG_TYPE_CIPHER)
+ if (rk_cipher_algs[i]->type == CRYPTO_ALG_TYPE_SKCIPHER)
crypto_unregister_skcipher(&rk_cipher_algs[k]->alg.skcipher);
else
crypto_unregister_ahash(&rk_cipher_algs[i]->alg.hash);
@@ -128,7 +138,7 @@ static void rk_crypto_unregister(void)
unsigned int i;
for (i = 0; i < ARRAY_SIZE(rk_cipher_algs); i++) {
- if (rk_cipher_algs[i]->type == ALG_TYPE_CIPHER)
+ if (rk_cipher_algs[i]->type == CRYPTO_ALG_TYPE_SKCIPHER)
crypto_unregister_skcipher(&rk_cipher_algs[i]->alg.skcipher);
else
crypto_unregister_ahash(&rk_cipher_algs[i]->alg.hash);
diff --git a/drivers/crypto/rockchip/rk3288_crypto.h b/drivers/crypto/rockchip/rk3288_crypto.h
index 65ed645e0168..d924ea17402a 100644
--- a/drivers/crypto/rockchip/rk3288_crypto.h
+++ b/drivers/crypto/rockchip/rk3288_crypto.h
@@ -232,18 +232,13 @@ struct rk_cipher_rctx {
struct skcipher_request fallback_req; // keep at the end
};
-enum alg_type {
- ALG_TYPE_HASH,
- ALG_TYPE_CIPHER,
-};
-
struct rk_crypto_tmp {
+ u32 type;
struct rk_crypto_info *dev;
union {
struct skcipher_alg skcipher;
struct ahash_alg hash;
} alg;
- enum alg_type type;
};
extern struct rk_crypto_tmp rk_ecb_aes_alg;
diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto/rockchip/rk3288_crypto_ahash.c
index edd40e16a3f0..d08e2438d356 100644
--- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c
+++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c
@@ -352,7 +352,7 @@ static void rk_cra_hash_exit(struct crypto_tfm *tfm)
}
struct rk_crypto_tmp rk_ahash_sha1 = {
- .type = ALG_TYPE_HASH,
+ .type = CRYPTO_ALG_TYPE_AHASH,
.alg.hash = {
.init = rk_ahash_init,
.update = rk_ahash_update,
@@ -382,7 +382,7 @@ struct rk_crypto_tmp rk_ahash_sha1 = {
};
struct rk_crypto_tmp rk_ahash_sha256 = {
- .type = ALG_TYPE_HASH,
+ .type = CRYPTO_ALG_TYPE_AHASH,
.alg.hash = {
.init = rk_ahash_init,
.update = rk_ahash_update,
@@ -412,7 +412,7 @@ struct rk_crypto_tmp rk_ahash_sha256 = {
};
struct rk_crypto_tmp rk_ahash_md5 = {
- .type = ALG_TYPE_HASH,
+ .type = CRYPTO_ALG_TYPE_AHASH,
.alg.hash = {
.init = rk_ahash_init,
.update = rk_ahash_update,
diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
index 67a7e05d5ae3..1ed297f5d809 100644
--- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
+++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
@@ -468,7 +468,7 @@ static void rk_ablk_exit_tfm(struct crypto_skcipher *tfm)
}
struct rk_crypto_tmp rk_ecb_aes_alg = {
- .type = ALG_TYPE_CIPHER,
+ .type = CRYPTO_ALG_TYPE_SKCIPHER,
.alg.skcipher = {
.base.cra_name = "ecb(aes)",
.base.cra_driver_name = "ecb-aes-rk",
@@ -490,7 +490,7 @@ struct rk_crypto_tmp rk_ecb_aes_alg = {
};
struct rk_crypto_tmp rk_cbc_aes_alg = {
- .type = ALG_TYPE_CIPHER,
+ .type = CRYPTO_ALG_TYPE_SKCIPHER,
.alg.skcipher = {
.base.cra_name = "cbc(aes)",
.base.cra_driver_name = "cbc-aes-rk",
@@ -513,7 +513,7 @@ struct rk_crypto_tmp rk_cbc_aes_alg = {
};
struct rk_crypto_tmp rk_ecb_des_alg = {
- .type = ALG_TYPE_CIPHER,
+ .type = CRYPTO_ALG_TYPE_SKCIPHER,
.alg.skcipher = {
.base.cra_name = "ecb(des)",
.base.cra_driver_name = "ecb-des-rk",
@@ -535,7 +535,7 @@ struct rk_crypto_tmp rk_ecb_des_alg = {
};
struct rk_crypto_tmp rk_cbc_des_alg = {
- .type = ALG_TYPE_CIPHER,
+ .type = CRYPTO_ALG_TYPE_SKCIPHER,
.alg.skcipher = {
.base.cra_name = "cbc(des)",
.base.cra_driver_name = "cbc-des-rk",
@@ -558,7 +558,7 @@ struct rk_crypto_tmp rk_cbc_des_alg = {
};
struct rk_crypto_tmp rk_ecb_des3_ede_alg = {
- .type = ALG_TYPE_CIPHER,
+ .type = CRYPTO_ALG_TYPE_SKCIPHER,
.alg.skcipher = {
.base.cra_name = "ecb(des3_ede)",
.base.cra_driver_name = "ecb-des3-ede-rk",
@@ -580,7 +580,7 @@ struct rk_crypto_tmp rk_ecb_des3_ede_alg = {
};
struct rk_crypto_tmp rk_cbc_des3_ede_alg = {
- .type = ALG_TYPE_CIPHER,
+ .type = CRYPTO_ALG_TYPE_SKCIPHER,
.alg.skcipher = {
.base.cra_name = "cbc(des3_ede)",
.base.cra_driver_name = "cbc-des3-ede-rk",
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-01 14:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 12:56 [PATCH v9 00/33] crypto: rockchip: permit to pass self-tests Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 01/33] crypto: rockchip: use dev_err for error message about interrupt Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 02/33] crypto: rockchip: do not use uninitialized variable Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 03/33] crypto: rockchip: do not do custom power management Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 04/33] crypto: rockchip: fix privete/private typo Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 05/33] crypto: rockchip: do not store mode globally Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 06/33] crypto: rockchip: add fallback for cipher Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 07/33] crypto: rockchip: add fallback for ahash Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 08/33] crypto: rockchip: better handle cipher key Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 09/33] crypto: rockchip: remove non-aligned handling Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 10/33] crypto: rockchip: rework by using crypto_engine Corentin Labbe
2022-09-01 12:56 ` Corentin Labbe [this message]
2022-09-01 12:56 ` [PATCH v9 12/33] crypto: rockchip: add debugfs Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 13/33] crypto: rockchip: introduce PM Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 14/33] crypto: rockchip: handle reset also in PM Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 15/33] crypto: rockchip: use clk_bulk to simplify clock management Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 16/33] crypto: rockchip: add myself as maintainer Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 17/33] crypto: rockchip: use read_poll_timeout Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 18/33] crypto: rockchip: fix style issue Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 19/33] crypto: rockchip: add support for rk3328 Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 20/33] crypto: rockchip: rename ablk functions to cipher Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 21/33] crypto: rockchip: rework rk_handle_req function Corentin Labbe
2022-09-01 12:56 ` [PATCH v9 22/33] crypto: rockchip: use a rk_crypto_info variable instead of lot of indirection Corentin Labbe
2022-09-01 12:57 ` [PATCH v9 23/33] crypto: rockchip: use the rk_crypto_info given as parameter Corentin Labbe
2022-09-01 12:57 ` [PATCH v9 24/33] dt-bindings: crypto: convert rockchip-crypto to YAML Corentin Labbe
2022-09-01 12:57 ` [PATCH v9 25/33] dt-bindings: crypto: rockchip: convert to new driver bindings Corentin Labbe
2022-09-07 20:38 ` Rob Herring
2022-09-09 8:57 ` LABBE Corentin
2022-09-01 12:57 ` [PATCH v9 26/33] clk: rk3399: use proper crypto0 name Corentin Labbe
2022-09-01 12:57 ` [PATCH v9 27/33] arm64: dts: rockchip: add rk3328 crypto node Corentin Labbe
2022-09-01 12:57 ` [PATCH v9 28/33] arm64: dts: rockchip: rk3399: add " Corentin Labbe
2022-09-01 12:57 ` [PATCH v9 29/33] crypto: rockchip: store crypto_info in request context Corentin Labbe
2022-09-01 12:57 ` [PATCH v9 30/33] crypto: rockchip: Check for clocks numbers and their frequencies Corentin Labbe
2022-09-01 12:57 ` [PATCH v9 31/33] crypto: rockchip: rk_ahash_reg_init use crypto_info from parameter Corentin Labbe
2022-09-01 12:57 ` [PATCH v9 32/33] crypto: rockchip: permit to have more than one reset Corentin Labbe
2022-09-01 12:57 ` [PATCH v9 33/33] crypto: rockchip: Add support for RK3399 Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901125710.3733083-12-clabbe@baylibre.com \
--to=clabbe@baylibre.com \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=john@metanate.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).