From: Pavel Machek <pavel@ucw.cz>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: festevam@gmail.com, shawnguo@kernel.org,
devicetree@vger.kernel.org, kernel@pengutronix.de,
kernel@puri.sm, krzk@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
robh@kernel.org, "Guido Günther" <agx@sigxcpu.org>
Subject: Re: [PATCH v2 2/6] arm64: dts: imx8mq-librem5: add RGB pwm notification leds
Date: Tue, 6 Sep 2022 10:45:31 +0200 [thread overview]
Message-ID: <20220906084531.GA29911@duo.ucw.cz> (raw)
In-Reply-To: <20220902084216.1259202-3-martin.kepplinger@puri.sm>
[-- Attachment #1.1: Type: text/plain, Size: 1458 bytes --]
Hi!
> From: Guido Günther <agx@sigxcpu.org>
>
> Describe the RGB notification leds on the Librem 5 phone.
> Use the common defines so we're sure to adhere to the common patterns,
> use predefined led colors and functions so we're being warned in case
> of deprecations.
I'd like LED lists to be cc-ed on patches like this, so that we can
keep userland API consistent.
In particular, RGB LED is very common feature on the phones, and it
would be good to have it consistent accross them. Can you take a look
at Documentation/leds/well-known-leds.txt, decide if your current API
is suitable, and update the file so that we get the consistency?
Thanks,
Pavel
> + led-controller {
> + compatible = "pwm-leds";
> +
> + led-0 {
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_BLUE>;
> + max-brightness = <248>;
> + pwms = <&pwm2 0 50000 0>;
> + };
> +
> + led-1 {
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_GREEN>;
> + max-brightness = <248>;
> + pwms = <&pwm4 0 50000 0>;
> + };
> +
> + led-2 {
> + function = LED_FUNCTION_STATUS;
> + color = <LED_COLOR_ID_RED>;
> + max-brightness = <248>;
> + pwms = <&pwm3 0 50000 0>;
> + };
> + };
> +
> reg_aud_1v8: regulator-audio-1v8 {
> compatible = "regulator-fixed";
> pinctrl-names = "default";
> --
> 2.30.2
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-06 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 8:42 [PATCH v2 0/6] arm64: dts: imx8mq-librem5: phone DT updates Martin Kepplinger
2022-09-02 8:42 ` [PATCH v2 1/6] arm64: dts: imx8mq-librem5: describe the voice coil motor for focus control Martin Kepplinger
2022-09-02 8:42 ` [PATCH v2 2/6] arm64: dts: imx8mq-librem5: add RGB pwm notification leds Martin Kepplinger
2022-09-06 8:45 ` Pavel Machek [this message]
2022-09-09 8:32 ` Martin Kepplinger
2022-09-02 8:42 ` [PATCH v2 3/6] arm64: dts: imx8mq-librem5: Add bq25895 as max17055's power supply Martin Kepplinger
2022-09-02 8:42 ` [PATCH v2 4/6] arm64: dts: imx8mq-librem5: add USB type-c properties for role switching Martin Kepplinger
2022-09-02 8:42 ` [PATCH v2 5/6] arm64: dts: imx8mq-librem5: add usb-role-switch property to dwc3 Martin Kepplinger
2022-09-02 8:42 ` [PATCH v2 6/6] arm64: dts: imx8mq-librem5: fix mipi_csi description Martin Kepplinger
2022-09-05 3:35 ` [PATCH v2 0/6] arm64: dts: imx8mq-librem5: phone DT updates Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906084531.GA29911@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).