From: Smitha T Murthy <smitha.t@samsung.com>
To: linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com,
benjamin.gaignard@collabora.com, stanimir.varbanov@linaro.org,
dillon.minfei@gmail.com, david.plowman@raspberrypi.com,
mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org,
andi@etezian.org, alim.akhtar@samsung.com,
aswani.reddy@samsung.com, pankaj.dubey@samsung.com,
linux-fsd@tesla.com, smitha.t@samsung.com,
aakarsh.jain@samsung.com
Subject: [Patch v2 09/15] media: s5p-mfc: Add support for rate controls in MFCv12
Date: Wed, 7 Sep 2022 12:17:09 +0530 [thread overview]
Message-ID: <20220907064715.55778-10-smitha.t@samsung.com> (raw)
In-Reply-To: <20220907064715.55778-1-smitha.t@samsung.com>
In MFCv12, the rc configs are changed with support for CBR loose,
CBR tight and Variable Bitrate (VBR) added.
Cc: linux-fsd@tesla.com
Signed-off-by: Smitha T Murthy <smitha.t@samsung.com>
---
.../platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c | 22 +++++++++++++++----
.../platform/samsung/s5p-mfc/s5p_mfc_opr_v6.h | 1 +
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c
index eecefcfc683b..c0b8434812e0 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c
@@ -1039,10 +1039,24 @@ static int s5p_mfc_set_enc_params(struct s5p_mfc_ctx *ctx)
/* reaction coefficient */
if (p->rc_frame) {
- if (p->rc_reaction_coeff < TIGHT_CBR_MAX) /* tight CBR */
- writel(1, mfc_regs->e_rc_mode);
- else /* loose CBR */
- writel(2, mfc_regs->e_rc_mode);
+ if (IS_MFCV12(dev)) {
+ /* loose CBR */
+ if (p->rc_reaction_coeff < LOOSE_CBR_MAX)
+ writel(1, mfc_regs->e_rc_mode);
+ /* tight CBR */
+ else if (p->rc_reaction_coeff < TIGHT_CBR_MAX)
+ writel(0, mfc_regs->e_rc_mode);
+ /* VBR */
+ else
+ writel(2, mfc_regs->e_rc_mode);
+ } else {
+ /* tight CBR */
+ if (p->rc_reaction_coeff < TIGHT_CBR_MAX)
+ writel(1, mfc_regs->e_rc_mode);
+ /* loose CBR */
+ else
+ writel(2, mfc_regs->e_rc_mode);
+ }
}
/* seq header ctrl */
diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.h b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.h
index 30269f3e68e8..24752a712fbf 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.h
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.h
@@ -40,6 +40,7 @@
#define ENC_H264_LEVEL_MAX 42
#define ENC_MPEG4_VOP_TIME_RES_MAX ((1 << 16) - 1)
#define FRAME_DELTA_H264_H263 1
+#define LOOSE_CBR_MAX 5
#define TIGHT_CBR_MAX 10
#define ENC_HEVC_RC_FRAME_RATE_MAX ((1 << 16) - 1)
#define ENC_HEVC_QP_INDEX_MIN -12
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-07 6:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220907063309epcas5p1793555c0747fd7a11997e97649924552@epcas5p1.samsung.com>
2022-09-07 6:47 ` [Patch v2 00/15] Add MFC v12 support Smitha T Murthy
[not found] ` <CGME20220907063313epcas5p114f793010fd0f2797e93bd83ed18a1d7@epcas5p1.samsung.com>
2022-09-07 6:47 ` [Patch v2 01/15] dt-bindings: media: s5p-mfc: Add new DT schema for MFC Smitha T Murthy
2022-09-07 11:22 ` Krzysztof Kozlowski
2022-09-08 12:56 ` Aakarsh Jain
2022-09-08 15:11 ` Krzysztof Kozlowski
2022-09-14 12:48 ` Aakarsh Jain
2022-09-07 15:13 ` Rob Herring
2022-09-08 11:54 ` Aakarsh Jain
[not found] ` <CGME20220907063318epcas5p2a395fc5da7576c3a53b6a55e3cc87911@epcas5p2.samsung.com>
2022-09-07 6:47 ` [Patch v2 02/15] dt-bindings: media: s5p-mfc: Add mfcv12 variant Smitha T Murthy
2022-09-07 11:24 ` Krzysztof Kozlowski
2022-09-08 6:53 ` Smitha T Murthy
[not found] ` <CGME20220907063323epcas5p37b1a06b0c0ba5ac685284bf68b40a205@epcas5p3.samsung.com>
2022-09-07 6:47 ` [Patch v2 03/15] media: s5p-mfc: Rename IS_MFCV10 macro Smitha T Murthy
[not found] ` <CGME20220907063328epcas5p12c01eb755e3ddfa4fdaee8e4c3bc9527@epcas5p1.samsung.com>
2022-09-07 6:47 ` [Patch v2 04/15] media: s5p-mfc: Add initial support for MFCv12 Smitha T Murthy
2022-09-12 22:26 ` Andi Shyti
[not found] ` <CGME20220907063332epcas5p2d3c4258885b17c6765658702d833a782@epcas5p2.samsung.com>
2022-09-07 6:47 ` [Patch v2 05/15] Documention: v4l: Documentation for VP9 CIDs Smitha T Murthy
[not found] ` <CGME20220907063336epcas5p3511dcc3393c7bd5fe44f37889dd754df@epcas5p3.samsung.com>
2022-09-07 6:47 ` [Patch v2 06/15] media: v4l2: Add v4l2 control IDs for VP9 encoder Smitha T Murthy
[not found] ` <CGME20220907063340epcas5p2d7eb2452918dfc593c47f48d05cfb83b@epcas5p2.samsung.com>
2022-09-07 6:47 ` [Patch v2 07/15] media: s5p-mfc: Add support " Smitha T Murthy
[not found] ` <CGME20220907063344epcas5p1bb88aa1275e41bf266ac82e53a88ba2e@epcas5p1.samsung.com>
2022-09-07 6:47 ` [Patch v2 08/15] media: s5p-mfc: Add YV12 and I420 multiplanar format support Smitha T Murthy
[not found] ` <CGME20220907063348epcas5p15d482a6f03f21489aedde74f93c64ae4@epcas5p1.samsung.com>
2022-09-07 6:47 ` Smitha T Murthy [this message]
[not found] ` <CGME20220907063352epcas5p2deb747c1a6a293fcc7275aed05010552@epcas5p2.samsung.com>
2022-09-07 6:47 ` [Patch v2 10/15] media: s5p-mfc: Add support for UHD encoding Smitha T Murthy
[not found] ` <CGME20220907063355epcas5p4738968135cdc376beb4a8c621131e2f1@epcas5p4.samsung.com>
2022-09-07 6:47 ` [Patch v2 11/15] media: s5p-mfc: Add support for DMABUF for encoder Smitha T Murthy
[not found] ` <CGME20220907063404epcas5p2e300613155b910ab587d015e77a2aa0e@epcas5p2.samsung.com>
2022-09-07 6:47 ` [Patch v2 13/15] media: s5p-mfc: Load firmware for each run in MFCv12 Smitha T Murthy
[not found] ` <CGME20220907063408epcas5p4285be9e4db0a64b396da8d66fb5ab2ad@epcas5p4.samsung.com>
2022-09-07 6:47 ` [Patch v2 14/15] media: s5p-mfc: DPB Count Independent of VIDIOC_REQBUF Smitha T Murthy
[not found] ` <CGME20220907063413epcas5p3df6d22933ba2884730c52b6a3af2cb09@epcas5p3.samsung.com>
2022-09-07 6:47 ` [Patch v2 15/15] arm64: dts: fsd: Add MFC related DT enteries Smitha T Murthy
2022-09-07 11:25 ` Krzysztof Kozlowski
2022-09-07 12:16 ` Smitha T Murthy
2022-09-07 7:46 ` [Patch v2 00/15] Add MFC v12 support Smitha T Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907064715.55778-10-smitha.t@samsung.com \
--to=smitha.t@samsung.com \
--cc=aakarsh.jain@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=andrzej.hajda@intel.com \
--cc=aswani.reddy@samsung.com \
--cc=benjamin.gaignard@collabora.com \
--cc=david.plowman@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).