Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

From: Maxime Ripard <maxime@cerno.tech>
To: Mateusz Kwiatkowski <kfyatek@gmail.com>
Cc: "Ben Skeggs" <bskeggs@redhat.com>,
	"David Airlie" <airlied@linux.ie>, "Chen-Yu Tsai" <wens@csie.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Lyude Paul" <lyude@redhat.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Karol Herbst" <kherbst@redhat.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Emma Anholt" <emma@anholt.net>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	linux-arm-kernel@lists.infradead.org,
	"Phil Elwell" <phil@raspberrypi.com>,
	intel-gfx@lists.freedesktop.org,
	"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
	dri-devel@lists.freedesktop.org,
	"Dom Cobley" <dom@raspberrypi.com>,
	linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org,
	linux-sunxi@lists.linux.dev,
	"Geert Uytterhoeven" <geert@linux-m68k.org>
Subject: Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes
Date: Wed, 7 Sep 2022 16:34:21 +0200	[thread overview]
Message-ID: <20220907143421.4iopqwhp3yfircsh@houat> (raw)
In-Reply-To: <10ce686a-d7c8-9ce4-3979-735ad8eab3b5@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2080 bytes --]

On Mon, Sep 05, 2022 at 06:44:42PM +0200, Mateusz Kwiatkowski wrote:
> Hi Maxime,
> 
> W dniu 5.09.2022 o 15:37, Maxime Ripard pisze:
> >>> +    vfp = vfp_min + (porches_rem / 2);
> >>> +    vbp = porches - vfp;
> >>
> >> Relative position of the vertical sync within the VBI effectively moves the
> >> image up and down. Adding that (porches_rem / 2) moves the image up off center
> >> by that many pixels. I'd keep the VFP always at minimum to keep the image
> >> centered.
> >
> > And you would increase the back porch only then?
> 
> Well, increasing vbp only gives a centered image with the default 480i/576i
> resolutions. However, only ever changing vbp will cause the image to be always
> at the bottom of the screen when the active line count is decreased (e.g.
> setting the resolution to 720x480 but for 50Hz "PAL" - like many game consoles
> did back in the day).
> 
> I believe that the perfect solution would:
> 
> - Use the canonical / standard-defined blanking line counts for the standard
>   vertical resolutions (480/486/576)
> - Increase vfp and vbp from there by the same number if a smaller number of
>   active lines is specified, so that the resulting image is centered
> - Likewise, decrease vfp and vbp by the same number if the active line number
>   is larger and there is still leeway (this should allow for seamless handling
>   of 480i vs. 486i for 60 Hz "NTSC")

I'm not sure I understand how that's any different than the code you
initially commented on.

I would start by taking the entire blanking area, remove the sync
period. We only have the two porches now, and I'm starting from the
minimum, adding as many pixels in both (unless it's not an even number,
in which case the backporch will have the extra pixel).

Isn't it the same thing?

> - If even more active lines are specified, once the limit for vfp is hit, then
>   decrease vbp only - the resulting image will definitely be off-center, but
>   there's no other way

Unless you only want me to consider the front porch maximum?

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel