From: kernel test robot <lkp@intel.com>
To: Frank Li <Frank.Li@nxp.com>,
maz@kernel.org, tglx@linutronix.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kw@linux.com, bhelgaas@google.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pci@vger.kernel.org, peng.fan@nxp.com,
aisheng.dong@nxp.com, jdmason@kudzu.us, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, kishon@ti.com,
lorenzo.pieralisi@arm.com, ntb@lists.linux.dev, lznuaa@gmail.com,
imx@lists.linux.dev, manivannan.sadhasivam@linaro.org
Subject: Re: [PATCH v9 4/4] PCI: endpoint: Add vNTB MSI support
Date: Thu, 8 Sep 2022 04:43:48 +0800 [thread overview]
Message-ID: <202209080437.cNpaoZXx-lkp@intel.com> (raw)
In-Reply-To: <20220907034856.3101570-5-Frank.Li@nxp.com>
Hi Frank,
I love your patch! Perhaps something to improve:
[auto build test WARNING on jonmason-ntb/ntb-next]
[also build test WARNING on robh/for-next linus/master v6.0-rc4 next-20220907]
[cannot apply to tip/irq/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Frank-Li/PCI-EP-driver-support-MSI-doorbell-from-host/20220907-115114
base: https://github.com/jonmason/ntb ntb-next
config: loongarch-randconfig-s052-20220906 (https://download.01.org/0day-ci/archive/20220908/202209080437.cNpaoZXx-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/0fe017b7ce1e4748acce80d9ddb81b3cd456adbb
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Frank-Li/PCI-EP-driver-support-MSI-doorbell-from-host/20220907-115114
git checkout 0fe017b7ce1e4748acce80d9ddb81b3cd456adbb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=loongarch SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/pci/endpoint/functions/pci-epf-vntb.c:567:25: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __iomem *[assigned] mw_addr @@ got void * @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:567:25: sparse: expected void [noderef] __iomem *[assigned] mw_addr
drivers/pci/endpoint/functions/pci-epf-vntb.c:567:25: sparse: got void *
drivers/pci/endpoint/functions/pci-epf-vntb.c:600:41: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void *addr @@ got void [noderef] __iomem *epf_db @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:600:41: sparse: expected void *addr
drivers/pci/endpoint/functions/pci-epf-vntb.c:600:41: sparse: got void [noderef] __iomem *epf_db
drivers/pci/endpoint/functions/pci-epf-vntb.c:1206:33: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __iomem *base @@ got struct epf_ntb_ctrl *reg @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:1206:33: sparse: expected void [noderef] __iomem *base
drivers/pci/endpoint/functions/pci-epf-vntb.c:1206:33: sparse: got struct epf_ntb_ctrl *reg
drivers/pci/endpoint/functions/pci-epf-vntb.c:1217:33: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __iomem *base @@ got struct epf_ntb_ctrl *reg @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:1217:33: sparse: expected void [noderef] __iomem *base
drivers/pci/endpoint/functions/pci-epf-vntb.c:1217:33: sparse: got struct epf_ntb_ctrl *reg
drivers/pci/endpoint/functions/pci-epf-vntb.c:1228:33: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __iomem *base @@ got struct epf_ntb_ctrl *reg @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:1228:33: sparse: expected void [noderef] __iomem *base
drivers/pci/endpoint/functions/pci-epf-vntb.c:1228:33: sparse: got struct epf_ntb_ctrl *reg
drivers/pci/endpoint/functions/pci-epf-vntb.c:1240:33: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __iomem *base @@ got struct epf_ntb_ctrl *reg @@
drivers/pci/endpoint/functions/pci-epf-vntb.c:1240:33: sparse: expected void [noderef] __iomem *base
drivers/pci/endpoint/functions/pci-epf-vntb.c:1240:33: sparse: got struct epf_ntb_ctrl *reg
vim +567 drivers/pci/endpoint/functions/pci-epf-vntb.c
0fe017b7ce1e47 Frank Li 2022-09-06 536
e35f56bb03304a Frank Li 2022-02-22 537 /**
e35f56bb03304a Frank Li 2022-02-22 538 * epf_ntb_db_bar_init() - Configure Doorbell window BARs
e35f56bb03304a Frank Li 2022-02-22 539 * @ntb: NTB device that facilitates communication between HOST and vHOST
e35f56bb03304a Frank Li 2022-02-22 540 */
e35f56bb03304a Frank Li 2022-02-22 541 static int epf_ntb_db_bar_init(struct epf_ntb *ntb)
e35f56bb03304a Frank Li 2022-02-22 542 {
e35f56bb03304a Frank Li 2022-02-22 543 const struct pci_epc_features *epc_features;
e35f56bb03304a Frank Li 2022-02-22 544 u32 align;
e35f56bb03304a Frank Li 2022-02-22 545 struct device *dev = &ntb->epf->dev;
e35f56bb03304a Frank Li 2022-02-22 546 int ret;
e35f56bb03304a Frank Li 2022-02-22 547 struct pci_epf_bar *epf_bar;
e35f56bb03304a Frank Li 2022-02-22 548 void __iomem *mw_addr;
e35f56bb03304a Frank Li 2022-02-22 549 enum pci_barno barno;
0fe017b7ce1e47 Frank Li 2022-09-06 550 size_t size;
e35f56bb03304a Frank Li 2022-02-22 551
e35f56bb03304a Frank Li 2022-02-22 552 epc_features = pci_epc_get_features(ntb->epf->epc,
e35f56bb03304a Frank Li 2022-02-22 553 ntb->epf->func_no,
e35f56bb03304a Frank Li 2022-02-22 554 ntb->epf->vfunc_no);
e35f56bb03304a Frank Li 2022-02-22 555 align = epc_features->align;
0fe017b7ce1e47 Frank Li 2022-09-06 556 size = epf_ntb_db_size(ntb);
e35f56bb03304a Frank Li 2022-02-22 557
e35f56bb03304a Frank Li 2022-02-22 558 barno = ntb->epf_ntb_bar[BAR_DB];
0fe017b7ce1e47 Frank Li 2022-09-06 559 epf_bar = &ntb->epf->bar[barno];
e35f56bb03304a Frank Li 2022-02-22 560
0fe017b7ce1e47 Frank Li 2022-09-06 561 if (ntb->epf_db_phys) {
0fe017b7ce1e47 Frank Li 2022-09-06 562 mw_addr = NULL;
0fe017b7ce1e47 Frank Li 2022-09-06 563 epf_bar->phys_addr = ntb->epf_db_phys;
0fe017b7ce1e47 Frank Li 2022-09-06 564 epf_bar->barno = barno;
0fe017b7ce1e47 Frank Li 2022-09-06 565 epf_bar->size = size;
0fe017b7ce1e47 Frank Li 2022-09-06 566 } else {
e35f56bb03304a Frank Li 2022-02-22 @567 mw_addr = pci_epf_alloc_space(ntb->epf, size, barno, align, 0);
e35f56bb03304a Frank Li 2022-02-22 568 if (!mw_addr) {
0fe017b7ce1e47 Frank Li 2022-09-06 569 dev_err(dev, "Failed to allocate door bell address\n");
e35f56bb03304a Frank Li 2022-02-22 570 return -ENOMEM;
e35f56bb03304a Frank Li 2022-02-22 571 }
0fe017b7ce1e47 Frank Li 2022-09-06 572 }
e35f56bb03304a Frank Li 2022-02-22 573
e35f56bb03304a Frank Li 2022-02-22 574 ntb->epf_db = mw_addr;
e35f56bb03304a Frank Li 2022-02-22 575
e35f56bb03304a Frank Li 2022-02-22 576 ret = pci_epc_set_bar(ntb->epf->epc, ntb->epf->func_no, ntb->epf->vfunc_no, epf_bar);
e35f56bb03304a Frank Li 2022-02-22 577 if (ret) {
e35f56bb03304a Frank Li 2022-02-22 578 dev_err(dev, "Doorbell BAR set failed\n");
e35f56bb03304a Frank Li 2022-02-22 579 goto err_alloc_peer_mem;
e35f56bb03304a Frank Li 2022-02-22 580 }
e35f56bb03304a Frank Li 2022-02-22 581 return ret;
e35f56bb03304a Frank Li 2022-02-22 582
e35f56bb03304a Frank Li 2022-02-22 583 err_alloc_peer_mem:
e35f56bb03304a Frank Li 2022-02-22 584 pci_epc_mem_free_addr(ntb->epf->epc, epf_bar->phys_addr, mw_addr, epf_bar->size);
e35f56bb03304a Frank Li 2022-02-22 585 return -1;
e35f56bb03304a Frank Li 2022-02-22 586 }
e35f56bb03304a Frank Li 2022-02-22 587
--
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-07 20:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 3:48 [PATCH v9 0/4] PCI EP driver support MSI doorbell from host Frank Li
2022-09-07 3:48 ` [PATCH v9 1/4] irqchip: allow pass down .pm field at IRQCHIP_PLATFORM_DRIVER_END Frank Li
2022-09-07 3:48 ` [PATCH v9 2/4] irqchip: Add IMX MU MSI controller driver Frank Li
2022-09-08 0:03 ` kernel test robot
2022-09-08 7:02 ` Marc Zyngier
2022-09-08 14:26 ` [EXT] " Frank Li
2022-09-08 14:35 ` Marc Zyngier
2022-09-08 7:39 ` Marc Zyngier
2022-09-08 14:23 ` [EXT] " Frank Li
2022-09-08 14:51 ` Marc Zyngier
2022-09-08 15:35 ` Frank Li
2022-09-09 12:07 ` Marc Zyngier
2022-09-09 14:59 ` Frank Li
2022-09-10 14:35 ` Marc Zyngier
2022-09-12 15:53 ` Frank Li
2022-09-13 17:44 ` Marc Zyngier
2022-09-09 14:52 ` Frank Li
2022-09-10 14:40 ` Marc Zyngier
2022-09-12 16:17 ` Frank Li
2022-09-07 3:48 ` [PATCH v9 3/4] dt-bindings: irqchip: imx mu work as msi controller Frank Li
2022-09-09 1:43 ` Rob Herring
2022-09-07 3:48 ` [PATCH v9 4/4] PCI: endpoint: Add vNTB MSI support Frank Li
2022-09-07 20:43 ` kernel test robot [this message]
2022-09-13 17:24 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209080437.cNpaoZXx-lkp@intel.com \
--to=lkp@intel.com \
--cc=Frank.Li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=kbuild-all@lists.01.org \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lznuaa@gmail.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maz@kernel.org \
--cc=ntb@lists.linux.dev \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).