From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: netdev@vger.kernel.org
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"George McCollister" <george.mccollister@gmail.com>,
"Kurt Kanzenbach" <kurt@linutronix.de>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Woojung Huh" <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Clément Léger" <clement.leger@bootlin.com>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Marek Vasut" <marex@denx.de>, "John Crispin" <john@phrozen.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-renesas-soc@vger.kernel.org
Subject: [PATCH net-next 1/3] dt-bindings: net: dsa: mt7530: replace label = "cpu" with proper checks
Date: Mon, 12 Sep 2022 20:50:56 +0300 [thread overview]
Message-ID: <20220912175058.280386-2-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20220912175058.280386-1-vladimir.oltean@nxp.com>
The fact that some DSA device trees use 'label = "cpu"' for the CPU port
is nothing but blind cargo cult copying. The 'label' property was never
part of the DSA DT bindings for anything except the user ports, where it
provided a hint as to what name the created netdevs should use.
DSA does use the "cpu" port label to identify a CPU port in dsa_port_parse(),
but this is only for non-OF code paths (platform data).
The proper way to identify a CPU port is to look at whether the
'ethernet' phandle is present.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
.../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
index f9e7b6e20b35..fa271ee16b5e 100644
--- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
@@ -163,9 +163,7 @@ patternProperties:
allOf:
- $ref: dsa-port.yaml#
- if:
- properties:
- label:
- const: cpu
+ required: [ ethernet ]
then:
required:
- phy-mode
@@ -187,9 +185,7 @@ $defs:
patternProperties:
"^(ethernet-)?port@[0-9]+$":
if:
- properties:
- label:
- const: cpu
+ required: [ ethernet ]
then:
if:
properties:
@@ -215,9 +211,7 @@ $defs:
patternProperties:
"^(ethernet-)?port@[0-9]+$":
if:
- properties:
- label:
- const: cpu
+ required: [ ethernet ]
then:
if:
properties:
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-12 17:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 17:50 [PATCH net-next 0/3] Remove label = "cpu" from DSA dt-bindings Vladimir Oltean
2022-09-12 17:50 ` Vladimir Oltean [this message]
2022-09-12 17:59 ` [PATCH net-next 1/3] dt-bindings: net: dsa: mt7530: replace label = "cpu" with proper checks Florian Fainelli
2022-09-13 8:19 ` Arınç ÜNAL
2022-09-13 15:51 ` Rob Herring
2022-09-13 15:55 ` Arınç ÜNAL
2022-09-13 16:26 ` Vladimir Oltean
2022-09-12 17:50 ` [PATCH net-next 2/3] dt-bindings: net: dsa: mt7530: stop requiring phy-mode on CPU ports Vladimir Oltean
2022-09-12 18:07 ` Florian Fainelli
2022-09-13 8:19 ` Arınç ÜNAL
2022-09-13 15:51 ` Rob Herring
2022-09-12 17:50 ` [PATCH net-next 3/3] dt-bindings: net: dsa: remove label = "cpu" from examples Vladimir Oltean
2022-09-12 18:12 ` Florian Fainelli
2022-09-13 8:20 ` Arınç ÜNAL
2022-09-13 13:31 ` Vladimir Oltean
2022-09-13 14:14 ` Arınç ÜNAL
2022-09-13 14:32 ` Vladimir Oltean
2022-09-13 15:54 ` Rob Herring
2022-09-13 15:54 ` Rob Herring
2022-09-20 1:10 ` [PATCH net-next 0/3] Remove label = "cpu" from DSA dt-bindings patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912175058.280386-2-vladimir.oltean@nxp.com \
--to=vladimir.oltean@nxp.com \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marex@denx.de \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).