From: Sascha Hauer <s.hauer@pengutronix.de>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com,
Michael Trimarchi <michael@amarulasolutions.com>,
stable@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register
Date: Tue, 13 Sep 2022 18:35:10 +0200 [thread overview]
Message-ID: <20220913163510.GR6477@pengutronix.de> (raw)
In-Reply-To: <20220904141020.2947725-1-dario.binacchi@amarulasolutions.com>
Hi Dario,
On Sun, Sep 04, 2022 at 04:10:19PM +0200, Dario Binacchi wrote:
> Driver registration fails on SOC imx8mn as its supplier, the clock
> control module, is probed later than subsys initcall level. This driver
> uses platform_driver_probe which is not compatible with deferred probing
> and won't be probed again later if probe function fails due to clock not
> being available at that time.
>
> This patch replaces the use of platform_driver_probe with
> platform_driver_register which will allow probing the driver later again
> when the clock control module will be available.
>
> Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for i.MX23/28")
> Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Cc: stable@vger.kernel.org
How I see it v3 of this patch is perfectly fine and should be taken
instead of this one. I just commented that to v3.
Not sure if Vinod would take v3, or if you should resend v3 as v6
instead. If you do, you can add my Acked-by.
Vinod, please let us know what you prefer.
Sascha
>
> ---
>
> Changes in v5:
> - Update the commit message.
> - Add the patch "dmaengine: mxs: fix section mismatch" to remove the
> warning raised by this patch.
>
> Changes in v4:
> - Restore __init in front of mxs_dma_probe() definition.
> - Rename the mxs_dma_driver variable to mxs_dma_driver_probe.
> - Update the commit message.
> - Use builtin_platform_driver() instead of module_platform_driver().
>
> Changes in v3:
> - Restore __init in front of mxs_dma_init() definition.
>
> Changes in v2:
> - Add the tag "Cc: stable@vger.kernel.org" in the sign-off area.
>
> drivers/dma/mxs-dma.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index 994fc4d2aca4..18f8154b859b 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -839,10 +839,6 @@ static struct platform_driver mxs_dma_driver = {
> .name = "mxs-dma",
> .of_match_table = mxs_dma_dt_ids,
> },
> + .probe = mxs_dma_probe,
> };
> -
> -static int __init mxs_dma_module_init(void)
> -{
> - return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe);
> -}
> -subsys_initcall(mxs_dma_module_init);
> +builtin_platform_driver(mxs_dma_driver);
> --
> 2.32.0
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-13 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 14:10 [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Dario Binacchi
2022-09-04 14:10 ` [RESEND PATCH v5 2/2] dmaengine: mxs: fix section mismatch Dario Binacchi
2022-09-21 9:35 ` Robin Murphy
2022-09-13 16:35 ` Sascha Hauer [this message]
2022-09-20 17:10 ` [RESEND PATCH v5 1/2] dmaengine: mxs: use platform_driver_register Dario Binacchi
2022-09-21 3:23 ` Vinod Koul
2022-09-21 10:39 ` Sascha Hauer
2022-09-21 12:50 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2022-08-20 8:44 Dario Binacchi
2022-07-28 6:18 Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220913163510.GR6477@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).