From: Liang He <windhl@126.com>
To: tony@atomide.com, linux@armlinux.org.uk,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: windhl@126.com, chenmengda2009@163.com
Subject: [PATCH] ARM: OMAP2+: Hold reference returned from of_find_xxx API
Date: Thu, 15 Sep 2022 09:42:58 +0800 [thread overview]
Message-ID: <20220915014258.3999504-1-windhl@126.com> (raw)
In omap4_twl_init(), we should hold the reference returned from
of_find_compatible_node() which has increased the refcount and
then call of_node_put() with it when done.
Fixes: ccd369455a23 ("ARM: OMAP2+: Remove bogus warnings for machines without twl PMIC")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Mengda Chen <chenmengda2009@163.com>
---
arch/arm/mach-omap2/omap_twl.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c
index d4dab041324d..07b5f17066ce 100644
--- a/arch/arm/mach-omap2/omap_twl.c
+++ b/arch/arm/mach-omap2/omap_twl.c
@@ -213,11 +213,13 @@ static struct omap_voltdm_pmic omap4_core_pmic = {
int __init omap4_twl_init(void)
{
struct voltagedomain *voltdm;
+ struct device_node *np;
if (!cpu_is_omap44xx() ||
- of_find_compatible_node(NULL, NULL, "motorola,cpcap"))
+ (np = of_find_compatible_node(NULL, NULL, "motorola,cpcap"))) {
+ of_node_put(np);
return -ENODEV;
-
+ }
voltdm = voltdm_lookup("mpu");
omap_voltage_register_pmic(voltdm, &omap4_mpu_pmic);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-09-15 1:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 1:42 Liang He [this message]
2022-09-15 11:29 ` [PATCH] ARM: OMAP2+: Hold reference returned from of_find_xxx API Russell King (Oracle)
2022-09-15 12:41 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915014258.3999504-1-windhl@126.com \
--to=windhl@126.com \
--cc=chenmengda2009@163.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).