From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4813ECAAD3 for ; Thu, 15 Sep 2022 03:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v9h9fUXTwja3anx7XFqwMaBRov1DKfR25VtfEWc9I2c=; b=ryMYyhRqL2ArNK Ic86F9PKGXeRDtQxIQbA8Do2A31/r1Fyhec/QtiUjiL8tSA/md33e743LuQNq4VfpvpupaOV/0LvD 2C56RrOZ12QBW5SvD7yls/BrFfrDqDzvzHeuMN3/c40KKyCHCheNhqnAVtyxOgBzalOovMMB4m2Rm R6ets9x5yz8sjET9tt7Pvqes06HUf/NCwN3JzZ29nc+c5RnZL+m7pBgH7j1T+ucWRpgIeDwitmHOp G2PDLYNOcnR6IlIazxiarLI4Z6GFn3dli2KlOxpmmN1LJSzO7F30QgCbKBFhIhbJDGdeaXp3yvUOU ificMLuamJvDXKCuwAIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYffH-00GtQS-DQ; Thu, 15 Sep 2022 03:35:47 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYffE-00GtOM-Fm for linux-arm-kernel@lists.infradead.org; Thu, 15 Sep 2022 03:35:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF55D61944; Thu, 15 Sep 2022 03:35:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37874C433C1; Thu, 15 Sep 2022 03:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663212943; bh=14mpXxKRo+6XuJ0Gg9ChAvQ6g/o45p4uV2lg6Nt3yTw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N9kQ/3FbtkzP5+q9h0RPZk5GTSWF/L03BJ+bz4dDdroqWmhANL5opzJl1DVFyqqsL g3thYwnwBkhDh+q2GjUAkRW3OED+VH1K6PxMqbLaKTINdBX9r4EXVGoEKzHYlFCRuN U81okINiT5Ypm0kOsAFjxt+VO0AjGRPegb1uyP+tke7rf1oqb8kDIX3KV6CW/NG7t2 X+4+BpB72l/UoMUspLU0EKguacM+J6PkAIgRYouz9BUOH7OdUHzVVwSeMC0jV5+H5B X9kVtM7yUvsRquM26ZZwKEtLgKfbOQGSVOT9T3xWoBUv9wrZqqfDbaAay+P90+wGer zyq9QQxupUNHQ== Date: Wed, 14 Sep 2022 22:35:40 -0500 From: Bjorn Andersson To: Souradeep Chowdhury Cc: Andy Gross , Bjorn Andersson , Rob Herring , Alex Elder , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sai Prakash Ranjan , Sibi Sankar , Rajendra Nayak , vkoul@kernel.org Subject: Re: [PATCH V9 1/7] dt-bindings: Added the yaml bindings for DCC Message-ID: <20220915033540.jb4q4bjd3oomsfl4@builder.lan> References: <41b94746e1560d63f16fb5dc965042ec496aeaf1.1663173478.git.quic_schowdhu@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <41b94746e1560d63f16fb5dc965042ec496aeaf1.1663173478.git.quic_schowdhu@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_203544_625058_D8ECC7D1 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 14, 2022 at 10:31:11PM +0530, Souradeep Chowdhury wrote: > Documentation for Data Capture and Compare(DCC) device tree bindings > in yaml format. > > Reviewed-by: Rob Herring > Signed-off-by: Souradeep Chowdhury > --- > .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > new file mode 100644 > index 0000000..b7a6619 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Data Capture and Compare > + > +maintainers: > + - Souradeep Chowdhury Please update your email address. > + > +description: | > + DCC (Data Capture and Compare) is a DMA engine which is used to save > + configuration data or system memory contents during catastrophic failure > + or SW trigger. DCC is used to capture and store data for debugging purpose An empty line inbetween description and properties would be nice. > +properties: > + compatible: > + items: > + - enum: > + - qcom,sm8150-dcc > + - qcom,sc7280-dcc > + - qcom,sc7180-dcc > + - qcom,sdm845-dcc > + - const: qcom,dcc > + > + reg: > + items: > + - description: DCC base register region > + - description: DCC RAM base register region > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + dma@10a2000{ > + compatible = "qcom,sm8150-dcc","qcom,dcc"; > + reg = <0x010a2000 0x1000>, > + <0x010ad000 0x2000>; Please remove the double space between address and size. Regards, Bjorn > + }; > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel