From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45852C6FA8E for ; Tue, 20 Sep 2022 14:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PlEM930vRV6+DnH+xW+kKosFvXB8gkUMkSY5hpMSZog=; b=gh3y8NLD6YTDrC Fu0Hm7ktLO9zBLvroFI94sI2al+fuas5lSCP78oO4SMYPsIfCMbBnZP42yf/X95TYhjJRTo5F4dme 3dO/M5SaI8osOcFdB/K/tSGWz7EcMsBBGqZ4/tqmmfB26pC27ScMQMe8rAve9TdwS+jOKJEJ1fZ7l +HmgZGaqaenDm+saJAgKrlXOXzcObr0XNaveV/1nAdToAN8yRlfWcKNNmMvLlNDbZQbabJq1PKjX0 8Yf7pSQWDWMU4GzdnYHrudeSMIA9MtBqXrXVKXtAgDWctdzrfOhAqisNWhM9KXCR3dcKb7fQIY4QJ MDoFTWQt2y2U7z5m/3gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaeGI-004USv-GS; Tue, 20 Sep 2022 14:30:10 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaeGG-004URP-1A for linux-arm-kernel@lists.infradead.org; Tue, 20 Sep 2022 14:30:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 893B5B82A56; Tue, 20 Sep 2022 14:30:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96BA9C433C1; Tue, 20 Sep 2022 14:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663684205; bh=I74h6Nr+i8FTSqMM2icXg4l/Z8d01teWye2vzkJV1Yo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tHarhIC2/v9gdXe8pFO5gXOuAP/7hsBnlKicHFa4HPoAj/rpPDrietRKjaL4T/Jh6 ZdvbDq80prp81jUORiUO9QansekQg8YHYHrA/R14iIDhXbuZJ6QtnH7cqPeFWF3ztD hXqC/4Y/dT7gwvq0UdYzLgOqKA3n2d2nlyxTAiBUVFmdRu+VxNIRAFji/s14TQFyn8 S8G767aHCoBNK/rt2XKGk+/82GueazboMFIICcJantWmx7ibIkRvX6LXAnU6dJkEYK ldsGZtRZ71AmJhh1Sqq26kmLwBrRPtpgwZqJozUz+lUd44jaF22Zy7BkoIoRfKrK5Y kNf+jquNSTU3w== Date: Tue, 20 Sep 2022 07:30:03 -0700 From: Jakub Kicinski To: Nathan Huckleberry Cc: Dan Carpenter , llvm@lists.linux.dev, "David S. Miller" , Eric Dumazet , Paolo Abeni , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Nathan Chancellor , Nick Desaulniers , Tom Rix , Horatiu Vultur , Casper Andersson , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sparx5: Fix return type of sparx5_port_xmit_impl Message-ID: <20220920073003.5dab2753@kernel.org> In-Reply-To: <20220912214432.928989-1-nhuck@google.com> References: <20220912214432.928989-1-nhuck@google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_073008_251310_721D1B6D X-CRM114-Status: UNSURE ( 8.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 12 Sep 2022 14:44:29 -0700 Nathan Huckleberry wrote: > -int sparx5_port_xmit_impl(struct sk_buff *skb, struct net_device *dev) > +netdev_tx_t sparx5_port_xmit_impl(struct sk_buff *skb, struct net_device *dev) Similarly to mana this has a prototype. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel