From: Will Deacon <will@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
broonie@kernel.org, acme@kernel.org, leo.yan@linaro.org,
john.garry@huawei.com, catalin.marinas@arm.com,
Jonathan Corbet <corbet@lwn.net>,
Mark Rutland <mark.rutland@arm.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 0/2] perf: arm64: Kernel support for Dwarf unwinding through SVE functions
Date: Thu, 22 Sep 2022 21:57:08 +0100 [thread overview]
Message-ID: <20220922205707.GB12945@willie-the-truck> (raw)
In-Reply-To: <d6eaa797-380b-e8ae-f928-54843dd596f2@arm.com>
On Thu, Sep 22, 2022 at 03:31:20PM +0100, James Clark wrote:
>
>
> On 22/09/2022 15:04, Will Deacon wrote:
> > On Thu, Sep 01, 2022 at 02:26:56PM +0100, James Clark wrote:
> >> I'm resubmitting this with a few of the changes suggested by Will on V2.
> >>
> >> I haven't made any changes regarding the open questions about the
> >> discoverability or saving the new reg and passing to output_sample()
> >> because I think it's best to be consistent with the implementations on
> >> other platforms first. I have explained in more detail on v2 [1].
> >>
> >> [1]: https://lore.kernel.org/lkml/5fcf1a6f-c8fb-c296-992e-18aae8874095@arm.com/
> >
> > Fair enough, I can't argue against being consistent.
> >
> > Given that this exposes subtle new user ABI, do we have any coverage in
> > the selftests? If not, please could you add something?
> >
>
> Thanks, I will do that. I assume you mean the self tests in
> tools/perf/tests and not some non Perf tests?
I hadn't thought much about it, so wherever is best. It would just be nice
to have something we can run to make sure that this continues to work as
intended.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-22 20:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 13:26 [PATCH v3 0/2] perf: arm64: Kernel support for Dwarf unwinding through SVE functions James Clark
2022-09-01 13:26 ` [PATCH v3 1/2] perf: arm64: Add SVE vector granule register to user regs James Clark
2022-09-01 13:26 ` [PATCH v3 2/2] arm64/sve: Add Perf extensions documentation James Clark
2022-09-01 13:33 ` Mark Brown
2022-09-20 10:28 ` James Clark
2022-09-22 14:04 ` [PATCH v3 0/2] perf: arm64: Kernel support for Dwarf unwinding through SVE functions Will Deacon
2022-09-22 14:31 ` James Clark
2022-09-22 20:57 ` Will Deacon [this message]
2022-09-22 20:33 ` Will Deacon
2022-09-23 9:32 ` James Clark
2022-09-23 12:36 ` Will Deacon
2022-09-23 12:43 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922205707.GB12945@willie-the-truck \
--to=will@kernel.org \
--cc=acme@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).