From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A67C4C07E9D for ; Mon, 26 Sep 2022 19:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l1cJGphdacbhA6ZQguZirJoLOemCnC1I1Kw+DhM1Rb8=; b=zQNU0oBCTmxZLS vf4xat1+aHdBTKAd4MLQ4tiNcxDiVAJzEdyG0E9cYG0m9PiWEpvKEM3PmhuZnOZgvTkK68b8Cb15k y2YON2kQidMYT4wZcxJBuOIekg0AyvaXXHiE35ESxnee16cB6TQ+OvT8MwI6tWnQ2l3vPkCo2eiCq wixE8hpEYpCyJ8qDlQt6IzdUuHx2uFgNmhw6PAdpuD5X97iz2MCnlWPv2AdnM9j9jXK7C/jFMEwYL S+Qh0J5K8krk+8qs3LJveJdgiE2MlsvO+F7cHz+GV3S6zO8QOKMVCEETC/rQ7KvuVXFqS5RtYq2tA o643AdJtg88qEYT9dBbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocu5l-006ebw-QI; Mon, 26 Sep 2022 19:48:37 +0000 Received: from mail-oa1-f45.google.com ([209.85.160.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocu5j-006ebX-2N for linux-arm-kernel@lists.infradead.org; Mon, 26 Sep 2022 19:48:36 +0000 Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1278624b7c4so10648491fac.5 for ; Mon, 26 Sep 2022 12:48:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=M50FI7LNj1aukpmOfyVHjUDvsfAXsOHY9FPlj/V6CBo=; b=U0eQUOOHz7PV5yVCTg7PsaUBGlYCkXIaUPYFGJoOuGPpkhFHPvj+gn784yfqLEVrZR B0R6AtY5uodeIHL2twImkoEgddlViq08av3E5sns2heBMKP5Oxp3w7ks2C/QYwLgor8m A9qp9B8U/Z6KhBLZ0fcc5MSWxvTEzzJObHu6+wOHr+3Q6NY8RQWq4jvb/5yaOYzYowvE 9GecbFBId7ai+StgwjfXEWEloTTjIZNSWSe1e7j5Z4kh6ZbCCJuDyMpFFdU3Y/Vxv5WZ uIS22VfRTqY9s/iwN1I28pwNYktPusgk34QkZrB4wNbJ+ElVpP928Y/sXyyUg0x4wH7j tPWw== X-Gm-Message-State: ACrzQf3hmC1WKSTyLQBRm6zi3KeT+/p9M0NM7HcXd2TakMlDAi/o22g8 C4OFAVFhg7wpKbgWDvKhGw== X-Google-Smtp-Source: AMsMyM6Br1/MAg6GDzGavnanJLMgJ/Uf+HWn8UkUSSrF2UjAIQWyzkfE3qsANrovvBLiJVEF2w+YjA== X-Received: by 2002:a05:6871:b26:b0:127:7d57:9e28 with SMTP id fq38-20020a0568710b2600b001277d579e28mr188586oab.141.1664221713866; Mon, 26 Sep 2022 12:48:33 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id k23-20020a056870959700b000f5e89a9c60sm10413556oao.3.2022.09.26.12.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 12:48:33 -0700 (PDT) Received: (nullmailer pid 2677686 invoked by uid 1000); Mon, 26 Sep 2022 19:48:32 -0000 Date: Mon, 26 Sep 2022 14:48:32 -0500 From: Rob Herring To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Liam Girdwood , Mark Brown , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Marcin Wojtas , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/5] ASoC: kirkwood: enable Kirkwood driver for Armada 38x platforms Message-ID: <20220926194832.GA2668987-robh@kernel.org> References: <20220920132648.2008-1-pali@kernel.org> <20220920132648.2008-2-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220920132648.2008-2-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220926_124835_249931_0E20E7C3 X-CRM114-Status: GOOD ( 25.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 20, 2022 at 03:26:44PM +0200, Pali Roh=E1r wrote: > From: Marcin Wojtas > = > The audio unit of Marvell Armada38x SoC is similar to the ones comprised = by > other Marvell SoCs (Kirkwood, Dove and Armada 370). Therefore KW audio > driver can be used to support it and this commit adds new compatible stri= ng > to identify Armada 38x variant. > = > Two new memory regions are added: first one for PLL configuration and > the second one for choosing one of audio I/O modes (I2S or S/PDIF). > For the latter purpose a new optional DT property is added ('spdif-mode'). > = > kirkwood-i2s driver is extended by adding a new init function for Armada > 38x flavor and also a routine that enables PLL output (i.e. MCLK) > configuration. > = > Signed-off-by: Marcin Wojtas > Tested-by: Star_Automation > Reviewed-by: Nadav Haklai > Reviewed-by: Lior Amsalem > Tested-by: Lior Amsalem > Signed-off-by: Hezi Shahmoon > Reviewed-by: Neta Zur Hershkovits > [pali: Fix support for pre-38x SoCs] > Signed-off-by: Pali Roh=E1r > --- > .../devicetree/bindings/sound/mvebu-audio.txt | 14 +- > sound/soc/kirkwood/kirkwood-i2s.c | 136 +++++++++++++++++- > sound/soc/kirkwood/kirkwood.h | 2 + > 3 files changed, 149 insertions(+), 3 deletions(-) > = > diff --git a/Documentation/devicetree/bindings/sound/mvebu-audio.txt b/Do= cumentation/devicetree/bindings/sound/mvebu-audio.txt > index cb8c07c81ce4..4f5dec5cb3c2 100644 > --- a/Documentation/devicetree/bindings/sound/mvebu-audio.txt > +++ b/Documentation/devicetree/bindings/sound/mvebu-audio.txt > @@ -6,9 +6,14 @@ Required properties: > "marvell,kirkwood-audio" for Kirkwood platforms > "marvell,dove-audio" for Dove platforms > "marvell,armada370-audio" for Armada 370 platforms > + "marvell,armada-380-audio" for Armada 38x platforms Perhaps be consistent with the 370 string above it. > = > - reg: physical base address of the controller and length of memory mapp= ed > - region. > + region (named "i2s_regs"). So you are adding 'reg-names'? The values belong under 'reg-names' then. = '_regs' is also redundant. > + With "marvell,armada-380-audio" two other regions are required: > + first of those is dedicated for Audio PLL Configuration registers > + (named "pll_regs") and the second one ("soc_ctrl") - for register > + where one of exceptive I/O types (I2S or S/PDIF) is set. > = > - interrupts: > with "marvell,kirkwood-audio", the audio interrupt > @@ -23,6 +28,13 @@ Required properties: > "internal" for the internal clock > "extclk" for the external clock > = > +Optional properties: > + > +- spdif-mode: > + Enable S/PDIF mode on Armada 38x SoC. Using this property > + disables standard I2S I/O. Valid only with "marvell,armada-380-audio" > + compatible string. So boolean? > + > Example: > = > i2s1: audio-controller@b4000 { DT changes should be separate patch. It would also be nice to see this = converted to schema first. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel