From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7291C07E9D for ; Wed, 28 Sep 2022 02:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nj9+ANBHNHkxjpGjoAQVx1QOTQ0/n6/OzCPA4upQ6aI=; b=EfMGq5Ek2jnwWL Sg+qXoIxkYwJ3IbVP9QSCP7Stgb1mq7wIXLryJkyD9A/5uxs0c3k/EZAQekb6JibbGkgrBmiTciyO h32XuIBWpTZCV1q2cP6R5DaC50qiz13iWQWaWRxIi6yj7mkLCMQ6/qaJa4UhMoi0g6Mz5JDu4u3hI ia5p0LsuBVHUi98UYw3vv1Y5oVmLw26wUqlI7htpmQFN5d5+iNthgl+yveleOtfGpj+B0mra5Trlv ZuiXcDqe2Vq9X3aNAvgxI21NRmR/trna4DN4PPp1SCfvmv1imzZQg+MLLEjDXJpCPDhYafeG6bLHz f1tf+6io8CK8GybO+Ogg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odMc8-00DWyq-5W; Wed, 28 Sep 2022 02:15:56 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odMc2-00DWuh-IA; Wed, 28 Sep 2022 02:15:52 +0000 X-UUID: 83a49cb4943b46aa9bee4a6a6cef69ee-20220927 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=Q+fSEED8koFMBB0jhsQvQ1pjxAX/BH3bjI3pxMvhkOY=; b=kvqbjCwTZkhD8fLHDJ89Tpy1GezdmvKZ0bsJr8r5aZVfWFaPWsSOHsX5g6Uzs905e8Z2HgSoICMeaGdOjqXOSU8qVDBOGfPXSR5Caf9DdrxTCH//LiJqvnnLxxhutySTL3WnVVWAAb/lRnrkynBwxVqhGLsx3S3hAvt/vhYgd4o=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:112ff860-a95a-4db8-8c96-5e732e34218f,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:39a5ff1,CLOUDID:cf283e07-1cee-4c38-b21b-a45f9682fdc0,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:-5,EDM:-3,IP:nil, URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 83a49cb4943b46aa9bee4a6a6cef69ee-20220927 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1032914646; Tue, 27 Sep 2022 19:15:45 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Wed, 28 Sep 2022 09:55:06 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Wed, 28 Sep 2022 09:55:06 +0800 From: Miles Chen To: CC: , , , , , , , , Subject: Re: [PATCH 3/6] clk: mediatek: mt8192: Do not re-register top_early_divs in probe function Date: Wed, 28 Sep 2022 09:55:07 +0800 Message-ID: <20220928015507.17206-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <0a1618c4-b808-56bd-e89f-560b0423191d@collabora.com> References: <0a1618c4-b808-56bd-e89f-560b0423191d@collabora.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_191550_669514_4AB7B942 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >> top_early_divs are registered in the CLK_OF_DECLARE_DRIVER() half of the >> topckgen clk driver. Don't try to register it again in the actual probe >> function. This gets rid of the "Trying to register duplicate clock ..." >> warning. >> >> Signed-off-by: Chen-Yu Tsai > >Can't we simply remove the CLK_OF_DECLARE_DRIVER() and top_init_early entirely, >and transfer TOP_CSW_F26M_D2 to top_divs[] instead? >I get that systimer concern and we have something similar in MT8195, where the >TOP_CLK26M_D2 is registered "late". Another reason for this: Removing the CLK_OF_DECLARE_DRIVER() is good when we want to build our driver as kernel modules because it does not work with kernel modules. thanks, Miles > >Getting back to MT8192, TOP_CSW_F26M_D2 seems to be used only for: >1. systimer >2. SPMI MST (registered "late"). > >Being it a fixed factor clock, parented to another fixed clock, it doesn't >even have any ON/OFF switch, so I think it would be actually possible to go >for the proposed removal... which would further improve this cleanup. > >Regards, >Angelo > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel