From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83570C04A95 for ; Thu, 29 Sep 2022 08:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5CaTyZzgd72a4kt7Lc1Iu3ye43OS4e+4I3j7UPbOIhM=; b=Bez3mK0cs8Yetw mMebAdt5355NqCjM7LgexugJj99uEWQOhNUcl1sderxDUa6r3AtTDzL5a3MjEAPqwco1iCaK7tCHs ssFj8m8NO5LKTVmtJro7qsuIw2aXMA5C6GnbktSlXV+NTAK49ebx1Wvuqeq/npZE2np6RqQI/79Qd tLv3Zaf64p9AcmIFtcJV1jipZODRXJhPtEm/V6iq/SxZtiqmwNHnCVv3M5qokgiKFQsI4KgLRimF5 Au3TOhhaudHBVXd9z55E7AB+iO/K+9nimCgkk9NJKbjbeh17jSlxYrfGLXt6Q0sfHRMv+derCpJVd xvuiH8HOAj2gSUVN5m7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odod4-001kpF-Qq; Thu, 29 Sep 2022 08:10:48 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odocy-001kmi-KO for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 08:10:42 +0000 Received: by mail-pj1-x102d.google.com with SMTP id cv6so619621pjb.5 for ; Thu, 29 Sep 2022 01:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=PqlfwPujJPa5ILhcAEpjB2XsXFIbNicns4sglvBu2Nc=; b=iik4pyUMcQXH0byUTH3UfkwH8RlaHqsQ5U3b4sybeBIPhtwbxsNQKtG+/BNrmOuF3o um+XOEMBDn94QCGDcbNSZumApjt4JYx4n0BQguGBfEgr1Y0EtIhHLtjSomCCAK5PuIAR cjAzyj5ceFJ9ImesfbZWOSzfQdfn8lWZHL7SY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=PqlfwPujJPa5ILhcAEpjB2XsXFIbNicns4sglvBu2Nc=; b=T26VMy1kmjCeN5pGH8sAjh/mn+9OVXk4bnf89r6D7GC2we1YIKMN9Tw2zt1q8G4W55 k4lLnFnDxvo1RcwhX2va/30w6GLqyc1Ylia+VAbIBFYE8XtRL6NZmFiimovthSrpms/l Hyq1RF5OM4xdRnd6KR9mhXw8XzjZKuMVYxFZgHWyXsIU8f+t+Df9WZ4aYOXPJ6TrV27A OD3+oRK+T/zIWf6SIC70+mb7/vYcb5h1kI40Pj4eAz+LEa6FhCssIKkgFk4zoCH0cAym 8a7CGmHYCqXrod0J8dkAhL7uzXTo585158vRlWlOg6lcN0mzvmt44ZcqS2dJR/dknnmw bI9w== X-Gm-Message-State: ACrzQf03EcXtP+hJ4wvtkXfmt+8D815FQNDIczaki7sIN8S1oIeoaNjs GpRYjwxkDG+a5wFhJXRRmgD9+g== X-Google-Smtp-Source: AMsMyM6T5dB82wt7higNMwUVZBo8eq9IUm01DA0UgbxCIMi2sMaKyAvr86TcSZkBJXezzwNJaXIvRQ== X-Received: by 2002:a17:902:e88c:b0:176:a427:be6a with SMTP id w12-20020a170902e88c00b00176a427be6amr2233325plg.150.1664439039213; Thu, 29 Sep 2022 01:10:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s2-20020a17090a764200b0020087d7e778sm2815639pjl.37.2022.09.29.01.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 01:10:38 -0700 (PDT) Date: Thu, 29 Sep 2022 01:10:37 -0700 From: Kees Cook To: William Zhang Cc: Florian Fainelli , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Seung-Woo Kim , Russell King , Arnd Bergmann , Linus Walleij , "Russell King (Oracle)" , "Steven Rostedt (Google)" , Nick Hawkins , John Crispin , Masahiro Yamada , Nicolas Schier , Nick Desaulniers , open list , bcm-kernel-feedback-list@broadcom.com, anand.gore@broadcom.com Subject: Re: [PATCH] ARM: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL Message-ID: <202209290110.024DC2FE@keescook> References: <20220928174739.802806-1-f.fainelli@gmail.com> <202209281100.5311EE081B@keescook> <729030b4-c341-966f-05ed-3754122cb4f7@gmail.com> <986bea84-7cc3-9c40-733c-0c766f7a9ebc@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <986bea84-7cc3-9c40-733c-0c766f7a9ebc@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_011040_710192_18A3E67A X-CRM114-Status: GOOD ( 26.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 28, 2022 at 05:33:14PM -0700, William Zhang wrote: > > > On 09/28/2022 04:06 PM, Florian Fainelli wrote: > > On 9/28/22 11:01, Kees Cook wrote: > > > On Wed, Sep 28, 2022 at 10:47:39AM -0700, Florian Fainelli wrote: > > > > From: Seung-Woo Kim > > > > > > > > To enable UBSAN on ARM, this patch enables ARCH_HAS_UBSAN_SANITIZE_ALL > > > > from arm confiuration. Basic kernel bootup test is passed on arm with > > > > CONFIG_UBSAN_SANITIZE_ALL enabled. > > > > > > > > Signed-off-by: Seung-Woo Kim > > > > [florian: rebased against v6.0-rc7] > > > > Signed-off-by: Florian Fainelli > > > > > > Ah-ha, thanks for testing this. What devices did you check this on? I > > > know boot-up on arm32 can be very device-specific. > > > > This was tested on an ARCH_BRCMSTB system which is using an ARMv8 CPU > > booted in AArch32 mode, so virtually equivalent to armv7l. A raspberry > > Pi 4B is also happily booting with it. > > > > > > > > Which UBSAN configs did you try? > > > > All CONFIG_UBSAN_* work with the exception of CONFIG_UBSAN_ALIGNMENT on > > my ARCH_BRCMSTB system, however it works fine on the Raspberry Pi 4B. > > Florian > > I also tested on a BCM63138 board (ARM A9) under ARCH_BCMBCA using the > multi_v7_defconfig with all the UBSAN configs enabled except UBSAN_ALIGNMENT > and board boots up fine. Turning on UBSAN_ALIGNMENT results in flood of > false positive misaligned-access warnings. This is fine as ARM supports > unaligned access. > > It did catch an out-of-band bug in mach-sunxi smp code. I will submit a > separate patch to fix that bug. Yay! :) Move coverage is great. :) > > Tested-by: William Zhang Thanks! -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel