From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E473EC433FE for ; Fri, 30 Sep 2022 08:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t3lfbVy5QjGqshBcAXpxrHNXoRG3iCKFGSj9yMFTVok=; b=yRk/cJUdwr909T yLxmG4h0n9GWWdPqjil8P84BBzZ3fRwG7+C7xruZhwljk5KtNxVOY5UvuJzzPiK7PW96dPEEZS7r2 oCjCmpexIYmj8hW2Mj4OjocR6zVSS9eXnbLvKMzSmu6XpKM7CI9/QbaWjD51kxxk33Odjog73a1Wa ZhAV4NnPLhF4tKUyCt89VJVYZ1PUiNOHq0KCT4pONsTpWmn8lDpymoqfQtwrKRFQB+MvRzxaF0S5T caicOsyXDJcnptBQ655Z+w/ryuMSz048eeREN0VMO14yGAyfNJqCLriSp8gITWPGSBiBs6W98OsSr rCAfIeGxY4SpSMXqcdSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeAwV-007xCp-N2; Fri, 30 Sep 2022 08:00:19 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeAwR-007xA4-3X; Fri, 30 Sep 2022 08:00:17 +0000 X-UUID: b02333da951049d48bba7dfecb029f9e-20220930 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=nsg8SlBW4owAEbvckoVuWyxzCs2P4j+O1NyGMe8wsNY=; b=ay1Efn+HaoaIKi2pNAwYvSzCsVz7I9chgS4kpXi6AVpLAV4lbkn2O0i88S4wtCm37Y5nZnilX1SeePMkrV6cn7moKUsbjD+k++FbgZURo1TRi2hOpvZj18gLrGgIe96OtWWFmp+KP4BNqWB42ZuN+AwKvNqhFnGe6BIPGLuMLvs=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:5af1530d-008a-47f4-b645-d3e94983f9b8,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:39a5ff1,CLOUDID:43dec2e4-87f9-4bb0-97b6-34957dc0fbbe,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:-5,EDM:-3,IP:nil, URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: b02333da951049d48bba7dfecb029f9e-20220930 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 123001023; Fri, 30 Sep 2022 01:00:04 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Fri, 30 Sep 2022 15:09:24 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 30 Sep 2022 15:09:24 +0800 From: Miles Chen To: CC: , , , , , , , , Subject: Re: [PATCH 3/6] clk: mediatek: mt8192: Do not re-register top_early_divs in probe function Date: Fri, 30 Sep 2022 15:09:24 +0800 Message-ID: <20220930070924.5020-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220930_010015_174656_6949541C X-CRM114-Status: GOOD ( 14.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >On Wed, Sep 28, 2022 at 9:55 AM Miles Chen wrote: >> >> >> top_early_divs are registered in the CLK_OF_DECLARE_DRIVER() half of the >> >> topckgen clk driver. Don't try to register it again in the actual probe >> >> function. This gets rid of the "Trying to register duplicate clock ..." >> >> warning. >> >> >> >> Signed-off-by: Chen-Yu Tsai >> > >> >Can't we simply remove the CLK_OF_DECLARE_DRIVER() and top_init_early entirely, >> >and transfer TOP_CSW_F26M_D2 to top_divs[] instead? >> >I get that systimer concern and we have something similar in MT8195, where the >> >TOP_CLK26M_D2 is registered "late". >> >> Another reason for this: >> Removing the CLK_OF_DECLARE_DRIVER() is good when we want to build our driver as >> kernel modules because it does not work with kernel modules. > >I agree. But as I mentioned in my other reply, we need to fix the clock >user first before dropping that clock. And there's also the matter of >DT backward compatibility. So we need to do it incrementally. > > >ChenYu Got it. thanks for doing this. thanks, Miles _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel