From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45C43C433FE for ; Sun, 2 Oct 2022 23:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S2iNEOIGPVRp+e9cgUlnABw9/mjnCrWi0NBMrHmgVeQ=; b=IU8mj6fwvq8cXo O7ZhYNgFW97BkgmkJMCZdCzgpli79QIkMjSBoNTnFIXv7XzCmBfa1nrhf5qnSIldbz2gUrOkBkKhi KAGfDng26U4ntQK/vvIvw4NuhrU22ZD8mOiVR1cXAu/vRvj+gl0B3eJzsliGq53J1M2sk0iw/R4FH A6GcAMHc7VsTV/pQJbNnstq1vadhBLsK4Vq96GtIbbbj06sZDD6BtD7dRj7G9iV9kdIDgwib03TcP c5tYJcMsQxtyhXSA0Mm16Y1t8VmR3ubGfuoPn7lPTt6TFUmLd11Cw/f1N0M80IvUd+xOOvaDum+R1 h91pGm2c6jFAL//VFosQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1of7wi-002ttE-Ts; Sun, 02 Oct 2022 23:00:29 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1of7pG-002oit-I6 for linux-arm-kernel@lists.infradead.org; Sun, 02 Oct 2022 22:52:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 25E1A60F2E; Sun, 2 Oct 2022 22:52:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56827C433C1; Sun, 2 Oct 2022 22:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664751165; bh=gtlsmRQIxOF1aD70zk6aG8lbdASWebPDvTW22e+qgeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VTUPHgctTHrqV00bjC8c+WDBVrTTwknxwdA0Y7B+rxMzDSfrlWV4kQAPMqdjB97iS gXRXX3IA6L4CvRObZ50oLOMuLSgYtaFS3XFh29aK8qp+8EcZyRFSOPA8Pi9xaXQNds p9M5EWyD07YN4rYYbzUcMGK1Xuk1J+NZ2o2ZWMPBRubyX1to2FoA7AL07SCePdhf3b qXSwko3q4Xaiu4f3gQt5a4DrrhYcHIPEZmOlLPWLqmGcGxC5ro7Vl2FK+WpChBiIE9 Dl8nHyAsDDrtV8Kid+uY2+TbR2j4mJP4x+4K2WZP58+TlSLqC8lG5RrvuutNJorzmm l7zSq1F9b0tng== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Swati Agarwal , Radhey Shyam Pandey , Vinod Koul , Sasha Levin , michal.simek@xilinx.com, lars@metafoo.de, shravya.kumbham@xilinx.com, adrianml@alumnos.upm.es, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 3/9] dmaengine: xilinx_dma: Report error in case of dma_set_mask_and_coherent API failure Date: Sun, 2 Oct 2022 18:52:30 -0400 Message-Id: <20221002225236.239675-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221002225236.239675-1-sashal@kernel.org> References: <20221002225236.239675-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221002_155246_669789_5B199A68 X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Swati Agarwal [ Upstream commit 8f2b6bc79c32f0fa60df000ae387a790ec80eae9 ] The driver does not handle the failure case while calling dma_set_mask_and_coherent API. In case of failure, capture the return value of API and then report an error. Addresses-coverity: Unchecked return value (CHECKED_RETURN) Signed-off-by: Swati Agarwal Reviewed-by: Radhey Shyam Pandey Link: https://lore.kernel.org/r/20220817061125.4720-4-swati.agarwal@xilinx.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/xilinx/xilinx_dma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index 792776c86ee8..3bb711e735ab 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -2703,7 +2703,11 @@ static int xilinx_dma_probe(struct platform_device *pdev) xdev->ext_addr = false; /* Set the dma mask bits */ - dma_set_mask_and_coherent(xdev->dev, DMA_BIT_MASK(addr_width)); + err = dma_set_mask_and_coherent(xdev->dev, DMA_BIT_MASK(addr_width)); + if (err < 0) { + dev_err(xdev->dev, "DMA mask error %d\n", err); + goto disable_clks; + } /* Initialize the DMA engine */ xdev->common.dev = &pdev->dev; -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel