linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: armada-xp-98dx3236: add interrupts for watchdog
@ 2022-10-03 21:24 Chris Packham
  2022-10-04  1:13 ` Chris Packham
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Packham @ 2022-10-03 21:24 UTC (permalink / raw)
  To: andrew, gregory.clement, sebastian.hesselbarth, robh+dt,
	krzysztof.kozlowski+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, Chris Packham

The first interrupt is for the regular watchdog timeout. Normally the
RSTOUT line will trigger a reset before this interrupt fires but on
systems with a non-standard reset it may still trigger.

The second interrupt is for a timer1 which is used as a pre-timeout for
the watchdog.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
index 38a052a0312d..0e561dfc0ca9 100644
--- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
+++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
@@ -286,6 +286,7 @@ &watchdog {
 	compatible = "marvell,armada-xp-wdt";
 	clocks = <&coreclk 2>, <&refclk>;
 	clock-names = "nbclk", "fixed";
+	interrupts = <93>, <38>;
 };
 
 &cpurst {
-- 
2.37.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: armada-xp-98dx3236: add interrupts for watchdog
  2022-10-03 21:24 [PATCH] ARM: dts: armada-xp-98dx3236: add interrupts for watchdog Chris Packham
@ 2022-10-04  1:13 ` Chris Packham
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Packham @ 2022-10-04  1:13 UTC (permalink / raw)
  To: andrew, gregory.clement, sebastian.hesselbarth, robh+dt,
	krzysztof.kozlowski+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel

Hi All,

On 4/10/22 10:24, Chris Packham wrote:
> The first interrupt is for the regular watchdog timeout. Normally the
> RSTOUT line will trigger a reset before this interrupt fires but on
> systems with a non-standard reset it may still trigger.
>
> The second interrupt is for a timer1 which is used as a pre-timeout for
> the watchdog.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

I just realized this is a duplicate of 
https://lore.kernel.org/linux-watchdog/20220211003257.2037332-2-chris.packham@alliedtelesis.co.nz/ 
(I did have a strange sense of deja vu when writing it).

Looks like that patch was reviewed and acked but never delivered. 
Gregory would you be able to pick it up now? The driver change has been 
in for a while.

> ---
>   arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> index 38a052a0312d..0e561dfc0ca9 100644
> --- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> +++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> @@ -286,6 +286,7 @@ &watchdog {
>   	compatible = "marvell,armada-xp-wdt";
>   	clocks = <&coreclk 2>, <&refclk>;
>   	clock-names = "nbclk", "fixed";
> +	interrupts = <93>, <38>;
>   };
>   
>   &cpurst {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-04  1:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-03 21:24 [PATCH] ARM: dts: armada-xp-98dx3236: add interrupts for watchdog Chris Packham
2022-10-04  1:13 ` Chris Packham

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).