From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 610CEC433F5 for ; Tue, 4 Oct 2022 12:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=semtoNz9UVzhsu4Eo1YqhMc5AADyY+neYvs/nt5IDBE=; b=Ov7mo1MMcW0Vvd FBL3uXuM8Z04LPxRpUgI+0Uf09vZPK/dRUUcqfEnZSEZTF1M7wJDcrlIDwxmCSSe7y7eNdiHS6qwm mVRiznxXiZEPZ37J9rcKNXXoq1UrOHYKRD4QXZcOq8rJ3FzWUJk0FcLXVI/rmmhOGeJZ+5Xrd6FYU 8Q4tjavyPiXX+TPv8iE+bWYl14qw7eih4viScZ5/q00YwAnSbA9jQUTIUrbqF3t+MHDGs9lH/dRoO lI9awSCH/rc9qbEW6HEY0tQaVIJ4Gsl3l3Y1+7VbqGvPoF3ExUYfwOw3jZTufRilPOr2uwJWWdB2U anSMad+nc0LvZDBh3nFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofhAe-009e0B-Rn; Tue, 04 Oct 2022 12:37:12 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofhAb-009dzi-El for linux-arm-kernel@lists.infradead.org; Tue, 04 Oct 2022 12:37:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B8F8AB81A52; Tue, 4 Oct 2022 12:37:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6561C433C1; Tue, 4 Oct 2022 12:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664887026; bh=Pwem6v0XVdQs/TvgX1hPEq08PISP+cyRhK0ZnOnoCN4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TzQ2oAVakFNEeMmBZOJVnJIdZmeUakDWnM6eKUURxHRUBv4UvES5WbHw3ZKoSmh+c hbMSC8TjxVyXtatmKoepl5+MLJ3kUYD0spMHNhK+lfSUyMSbsNyEjqi9sm9KSDQ0Rr vVBeZXN554yKfkEzoCdL+LhvkHLlZ/mdYVR9TomBhToynT4qG/f153gGLbSnDEteoS qiNYIUP09nmlHv1eVc98Ysn/GXxwx/m4Md9ncirClp45tX1WeNYxyJqjHYkx0xvnIy hAhfRAE2vgDvwXrR8S1Sknxnut8+kjgRwHTI6tms6SmEf3Vl7Y4td7VNNpp/7mBDXm MFA4RTvkTyLSA== Date: Tue, 4 Oct 2022 14:36:42 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: "Russell King (Oracle)" Cc: Marcin Wojtas , pali@kernel.org, Christoph Hellwig , Robin Murphy , Arnd Bergmann , Andre Przywara , Marc Zyngier , Linus Torvalds , Andrew Lunn , Gregory Clement , Greg Kroah-Hartman , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: REGRESSION in 6.0-rc7 caused by patch "ARM/dma-mapping: use dma-direct unconditionally" Message-ID: <20221004143642.46ca1e7c@thinkpad> In-Reply-To: References: <20220930151028.0e518421@dellmb> <630be11f-09ef-02d4-69f7-c7880ae5674c@arm.com> <20220930165234.729ad68c@dellmb> <20220930170205.490f1a6b@dellmb> <20221003073037.GB2108@lst.de> <20221003172533.6dc87184@dellmb> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221004_053709_666727_62359E20 X-CRM114-Status: GOOD ( 22.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 4 Oct 2022 10:08:15 +0100 "Russell King (Oracle)" wrote: > On Tue, Oct 04, 2022 at 10:30:40AM +0200, Marcin Wojtas wrote: > > Thanks for the explanation and I agree with your reasoning. Therefore > > the below should be sufficient if we use HW BM and non-coherent > > setting: > > > > --- a/drivers/net/ethernet/marvell/mvneta_bm.c > > +++ b/drivers/net/ethernet/marvell/mvneta_bm.c > > @@ -103,7 +103,7 @@ int mvneta_bm_construct(struct hwbm_pool > > *hwbm_pool, void *buf) > > */ > > *(u32 *)buf = (u32)buf; > > phys_addr = dma_map_single(&priv->pdev->dev, buf, bm_pool->buf_size, > > - DMA_FROM_DEVICE); > > + DMA_BIDIRECTIONAL); > > if (unlikely(dma_mapping_error(&priv->pdev->dev, phys_addr))) > > return -ENOMEM; > > > > Marek - can you please confirm that? > > This is insufficient. Marek's patch is the correct version. > > The DMA API requires that the direction argument is the same for > mapping, unmapping and syncing a region. And now I am wondering about whether this didn't also cause the buffer manager not working on Armada 3720. Marvell just gave an erratum that HWBM is broken on 3720, but maybe they didn't notice this and just gave up. Also mvneta works only with one CPU on 3720 (see usage of pp->neta_armada3700 in mvneta.c), which I also still don't know why, and maybe it is related to this. Marek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel