From: Stephen Boyd <sboyd@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Russell King <linux@armlinux.org.uk>,
Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
Viresh Kumar <vireshk@kernel.org>,
soc@kernel.org, kernel test robot <lkp@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: spear: Move prototype to accessible header
Date: Mon, 10 Oct 2022 20:46:29 -0700 [thread overview]
Message-ID: <20221011034631.9D467C433C1@smtp.kernel.org> (raw)
In-Reply-To: <20221011031104.5gvw47ocbhj52oxy@vireshk-i7>
Quoting Viresh Kumar (2022-10-10 20:11:04)
> On 10-10-22, 18:01, Stephen Boyd wrote:
> > __init is meaningless in header files
>
> Technically yes.
>
> But then I grepped include/ and it is widely used, even by core kernel
> headers. Why is that ? Maybe just to keep prototype consistent ?
>
> Also init.h says:
>
> * If the function has a prototype somewhere, you can also add
> * __init between closing brace of the prototype and semicolon:
> *
> * extern int initialize_foobar_device(int, int, int) __init;
>
> Hmm, I understand that it is just saying that __init can be used after
> function's name instead of just before, but isn't it also suggesting
> that headers may also have it (maybe just to keep it consistent) ?
>
I didn't say it was forbidden ;)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-10-11 3:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 4:22 [PATCH] clk: spear: Move prototype to accessible header Viresh Kumar
2022-10-11 1:01 ` Stephen Boyd
2022-10-11 3:11 ` Viresh Kumar
2022-10-11 3:46 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221011034631.9D467C433C1@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soc@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).