From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V6 6/7] remoteproc: imx_rproc: request mbox channel later
Date: Wed, 12 Oct 2022 16:26:54 -0600 [thread overview]
Message-ID: <20221012222654.GD1196937@p14s> (raw)
In-Reply-To: <20220929061704.1571746-7-peng.fan@oss.nxp.com>
On Thu, Sep 29, 2022 at 02:17:03PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> It is possible that when remote processor crash, the communication
> channel will be broken with garbage value in mailbox, such as
> when Linux is issuing a message through mailbox, remote processor
> crashes, we need free & rebuild the mailbox channels to make sure
> no garbage value in mailbox channels.
>
> So move the request/free to start/stop for managing remote procesosr in
> Linux, move to attach/detach for remote processor is out of control of
> Linux.
>
> Previous, we just request mbox when attach for CM4 boot early before
> Linux, but if mbox defer probe, remoteproc core will do resource cleanup
> and corrupt resource table for later probe.
>
> So move request mbox ealier and still keep mbox request when attach
> for self recovery case, but keep a check when request/free mbox.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/remoteproc/imx_rproc.c | 26 +++++++++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 8175c4c9aa22..bece44b46719 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -84,6 +84,8 @@ struct imx_rproc_mem {
> #define ATT_CORE_MASK 0xffff
> #define ATT_CORE(I) BIT((I))
>
> +static int imx_rproc_xtr_mbox_init(struct rproc *rproc);
> +static void imx_rproc_free_mbox(struct rproc *rproc);
> static int imx_rproc_detach_pd(struct rproc *rproc);
>
> struct imx_rproc {
> @@ -357,6 +359,10 @@ static int imx_rproc_start(struct rproc *rproc)
> struct arm_smccc_res res;
> int ret;
>
> + ret = imx_rproc_xtr_mbox_init(rproc);
> + if (ret)
> + return ret;
> +
> switch (dcfg->method) {
> case IMX_RPROC_MMIO:
> ret = regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask,
> @@ -407,6 +413,8 @@ static int imx_rproc_stop(struct rproc *rproc)
>
> if (ret)
> dev_err(dev, "Failed to stop remote core\n");
> + else
> + imx_rproc_free_mbox(rproc);
>
> return ret;
> }
> @@ -592,7 +600,7 @@ static void imx_rproc_kick(struct rproc *rproc, int vqid)
>
> static int imx_rproc_attach(struct rproc *rproc)
> {
> - return 0;
> + return imx_rproc_xtr_mbox_init(rproc);
> }
>
> static struct resource_table *imx_rproc_get_loaded_rsc_table(struct rproc *rproc, size_t *table_sz)
> @@ -720,6 +728,9 @@ static int imx_rproc_xtr_mbox_init(struct rproc *rproc)
> struct device *dev = priv->dev;
> struct mbox_client *cl;
>
> + if (priv->tx_ch && priv->rx_ch)
> + return 0;
> +
Why is this needed? The remoteproc core's state machine driven by rproc->state
guarantees that imx_rproc_start(), imx_rproc_stop() and imx_rproc_attach are not
called more than once.
And why is imx_rproc_xtr_mbox_init() in imx_rproc_probe() not removed?
> if (!of_get_property(dev->of_node, "mbox-names", NULL))
> return 0;
>
> @@ -749,8 +760,15 @@ static void imx_rproc_free_mbox(struct rproc *rproc)
> {
> struct imx_rproc *priv = rproc->priv;
>
> - mbox_free_channel(priv->tx_ch);
> - mbox_free_channel(priv->rx_ch);
> + if (priv->tx_ch) {
> + mbox_free_channel(priv->tx_ch);
> + priv->tx_ch = NULL;
> + }
> +
> + if (priv->rx_ch) {
> + mbox_free_channel(priv->rx_ch);
> + priv->rx_ch = NULL;
> + }
> }
>
> static void imx_rproc_put_scu(struct rproc *rproc)
> @@ -779,6 +797,8 @@ static int imx_rproc_partition_notify(struct notifier_block *nb,
> if (!((event & BIT(priv->rproc_pt)) && (*(u8 *)group == IMX_SC_IRQ_GROUP_REBOOTED)))
> return 0;
>
> + imx_rproc_free_mbox(priv->rproc);
Why putting this here when it will be called again in imx_rproc_stop()? If you
need it for the attached scenario, create imx_rproc_detach() and add it there.
> +
> rproc_report_crash(priv->rproc, RPROC_WATCHDOG);
>
> pr_info("Partition%d reset!\n", priv->rproc_pt);
> --
> 2.37.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-12 22:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 6:16 [PATCH V6 0/7] remoteproc: imx_rproc: support i.MX8QM/QXP Peng Fan (OSS)
2022-09-29 6:16 ` [PATCH V6 1/7] dt-bindings: remoteproc: imx_rproc: support i.MX8QXP Peng Fan (OSS)
2022-09-29 6:16 ` [PATCH V6 2/7] dt-bindings: remoteproc: imx_rproc: support i.MX8QM Peng Fan (OSS)
2022-09-29 6:17 ` [PATCH V6 3/7] remoteproc: imx_rproc: support attaching to i.MX8QXP M4 Peng Fan (OSS)
2022-10-12 21:23 ` Mathieu Poirier
2022-09-29 6:17 ` [PATCH V6 4/7] remoteproc: imx_rproc: support kicking Mcore from Linux for i.MX8QXP Peng Fan (OSS)
2022-10-12 21:45 ` Mathieu Poirier
2022-09-29 6:17 ` [PATCH V6 5/7] remoteproc: imx_rproc: support i.MX8QM Peng Fan (OSS)
2022-10-12 22:06 ` Mathieu Poirier
2022-09-29 6:17 ` [PATCH V6 6/7] remoteproc: imx_rproc: request mbox channel later Peng Fan (OSS)
2022-10-12 22:26 ` Mathieu Poirier [this message]
2022-10-13 13:06 ` Peng Fan
2022-09-29 6:17 ` [PATCH V6 7/7] remoteproc: imx_rproc: Enable attach recovery for i.MX8QM/QXP Peng Fan (OSS)
2022-09-29 23:20 ` Peng Fan
2022-10-12 22:32 ` Mathieu Poirier
2022-10-13 13:11 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221012222654.GD1196937@p14s \
--to=mathieu.poirier@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).