From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org,
gwendal@chromium.org, linux-kernel@vger.kernel.org,
paul@crapouillou.net, miquel.raynal@bootlin.com,
groeck@chromium.org, chrome-platform@lists.linux.dev,
lars@metafoo.de, linmq006@gmail.com,
u.kleine-koenig@pengutronix.de, alexandru.ardelean@analog.com,
mihail.chindris@analog.com, Michael.Hennerich@analog.com,
Cosmin Tanislav <cosmin.tanislav@analog.com>,
nathan@kernel.org, andriy.shevchenko@linux.intel.com,
bleung@chromium.org, linux-arm-kernel@lists.infradead.org,
matti.vaittinen@fi.rohmeurope.com, Eugen.Hristev@microchip.com,
Claudiu.Beznea@microchip.com
Subject: Re: [RFT PATCH v3 10/10] iio: Don't silently expect attribute types
Date: Sat, 5 Nov 2022 14:45:18 +0000 [thread overview]
Message-ID: <20221105144518.7fa63084@jic23-huawei> (raw)
In-Reply-To: <41abe9f6-d633-664a-db93-0580b23e44e1@gmail.com>
On Mon, 10 Oct 2022 12:36:54 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> On 10/9/22 20:38, Jonathan Cameron wrote:
> > On Thu, 6 Oct 2022 15:53:52 +0300
> > Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> >
> >> Hi Claudiu,
> >>
> >> On 10/6/22 11:35, Claudiu.Beznea@microchip.com wrote:
> >>> On 03.10.2022 11:13, Matti Vaittinen wrote:
> >>>> The iio_triggered_buffer_setup_ext() and the
> >>>> devm_iio_kfifo_buffer_setup_ext() were changed by
> >>>> commit 15097c7a1adc ("iio: buffer: wrap all buffer attributes into iio_dev_attr")
> >>>> to silently expect that all attributes given in buffer_attrs array are
> >>>> device-attributes. This expectation was not forced by the API - and some
> >>>> drivers did register attributes created by IIO_CONST_ATTR().
> >>>>
> >>>> When using IIO_CONST_ATTRs the added attribute "wrapping" does not copy
> >>>> the pointer to stored string constant and when the sysfs file is read the
> >>>> kernel will access to invalid location.
> >>>>
> >>>> Change the function signatures to expect an array of iio_dev_attrs to
> >>>> avoid similar errors in the future.
> >>>>
> >>>> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> >>>
> >>> Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> >>>
> >>> on SAMA5D2
> >>>
> >>
> >> Thanks a ton for the testing! I do _really_ appreciate it :) I am now
> >> slightly more confident regarding the fix here - and a lot more
> >> confident that we do have an actual bug (as you explained in the reply
> >> to the first RFT) :)
> >
> > You analysis was sound, so I've long been convinced ;)
> >
> > Anyhow, one more coming through...
> > AD4130 v9 patch had same issue and so will also need updating with this
> > patch if it lands before yours.
> >
> > Other than that static macro being ugly (which I can't improve on!)
> > all looks good to me, but I'll let it sit a while longer. If nothing
> > else I want to rebase the fixes-togreg tree on rc1 before putting the first
> > part of this series on top of it then letting them soak in next for
> > a few days,
>
> Thanks Jonathan.
>
> Can you please ping me if you want me to rebase/rework the series? (I
> may combine this with the kx022a-series then, but naturally not all
> patches in the series need to be applied at once. Eg, fixes can be taken
> in faster, kx022a part can be iterated, iterated, iterated... ;] ).
Applied the remainder of this series. As expected need to make the changes
in patch 10 to your kx022a driver and the ad4130 ADC that also crossed with
this series.
+CC Cosmin for the ad4130. Please check the result in the
testing branch of iio.git.
Applied to the togreg branch of iio.git and pushed out initially as testing.
This is a nice hardening of the code against future mistakes.
Thanks,
Jonathan
>
> Yours
> -- Matti
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-11-05 14:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 8:09 [PATCH v3 00/10] iio: Fix unsafe buffer attributes Matti Vaittinen
2022-10-03 8:11 ` [PATCH v3 04/10] iio: at91-sama5d2_adc: " Matti Vaittinen
2022-10-06 8:34 ` Claudiu.Beznea
2022-10-16 11:14 ` Jonathan Cameron
2022-10-03 8:13 ` [PATCH v3 09/10] iio: at91-sama5d2_adc: Use IIO_STATIC_CONST_DEVICE_ATTR() Matti Vaittinen
2022-10-06 8:35 ` Claudiu.Beznea
2022-10-03 8:13 ` [RFT PATCH v3 10/10] iio: Don't silently expect attribute types Matti Vaittinen
2022-10-03 8:43 ` Andy Shevchenko
2022-10-03 8:58 ` Matti Vaittinen
2022-10-03 9:02 ` Matti Vaittinen
2022-10-03 9:39 ` Andy Shevchenko
2022-10-03 9:42 ` Andy Shevchenko
2022-10-06 8:35 ` Claudiu.Beznea
2022-10-06 12:53 ` Matti Vaittinen
2022-10-09 17:38 ` Jonathan Cameron
2022-10-10 9:36 ` Matti Vaittinen
2022-11-05 14:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221105144518.7fa63084@jic23-huawei \
--to=jic23@kernel.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.ardelean@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=cosmin.tanislav@analog.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=lars@metafoo.de \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mihail.chindris@analog.com \
--cc=miquel.raynal@bootlin.com \
--cc=nathan@kernel.org \
--cc=paul@crapouillou.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).