From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3F26C433FE for ; Wed, 9 Nov 2022 22:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uEfipejRocrowBc2kgasHeWlYdD0oEVYeXxRIWndvIY=; b=dLzrwmKTKa6BFY PBCd0qYZ+rnpziG9jaFfkPVcFy8uKDglUczaPNpHyFbXzKN14+jpMu65IoLbRwMVToHTIVlYYIuYB bNo+86KOTsYWQPSOGjVzWCtZ8A3JGuGVpA5nXIKCV+S0+TlZqRRDDok4NGrpldIVlNSD2sb085qY2 cVPuXTdH1NkaEmlOkZyOh+BWSlrcLXdgVdv/GMPpxh7I//xmPAgk4gO44U4VI1UEBlHylTxUGpTrm m8BFh21POcU49+WjWoxxkzCcppO5jExCJy+TdQi1uc5ch/8I+xW7u7YfDwXgOsI+ZOBHV3dAQlJpp epbGgzyvH3k8T8YbNjfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ostNv-000804-TL; Wed, 09 Nov 2022 22:17:28 +0000 Received: from mail-oa1-f54.google.com ([209.85.160.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ostNs-0007zB-7u for linux-arm-kernel@lists.infradead.org; Wed, 09 Nov 2022 22:17:25 +0000 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-13b103a3e5dso373733fac.2 for ; Wed, 09 Nov 2022 14:17:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k4lH5rWvUE98GU8yCy1NGQDUM/X/Z3Tpbwa5NYFQXGg=; b=s/R4fpWgBtpJGBqAs+vUHlOcSqGhvsCcO/dZJdZuTEDdHpNFxMaPvsWGiqeUrzgOP5 qbDOdUcHLVTgZfnTGPAFMIrkICAFvtypGwGXk0Q6FL7KSCcVZr/cVF3XKyy3rw2sywaJ Xy8DUbJaJW9fSFs/uUOI6DgysT+uJ5SdS8nkG5jarcz8LQdrvYWcytT0rRsCRIZ0ai6O 1Z/Z1AvkQuyaC/ir4Jbva2XmoRM9EAApUkyNg02ixh6kgCAH8P//2XyVCnBGB2k+NEeJ 76WZ5SmZzcgFZiAGB7Yr0zBsrABeRGDjuUbTdYIgVFkVSpqIGvU1A7y9TVExQkEfO/dj N8JA== X-Gm-Message-State: ACrzQf3lQz3XL4XKw443V8ccofyZk0toxvsAqXmfoH9/BBnTTBr1B7j+ FQIHboRguCa+hjC+Ad7XPA== X-Google-Smtp-Source: AMsMyM4FAtCtJYba4qjwAMKO/E286pubc0VAzXrmDkV7GWZ7ieKpPlDQmLDrWAXpJ8enR50wmPd/Qg== X-Received: by 2002:a05:6871:611:b0:13b:8097:2b92 with SMTP id w17-20020a056871061100b0013b80972b92mr47236179oan.44.1668032242503; Wed, 09 Nov 2022 14:17:22 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id db6-20020a0568306b0600b0066cc0525476sm4690773otb.75.2022.11.09.14.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 14:17:21 -0800 (PST) Received: (nullmailer pid 2973198 invoked by uid 1000); Wed, 09 Nov 2022 22:17:23 -0000 Date: Wed, 9 Nov 2022 16:17:23 -0600 From: Rob Herring To: "Russell King (Oracle)" Cc: Krzysztof Kozlowski , Linus Walleij , Bartosz Golaszewski , Lee Jones , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter Subject: Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller Message-ID: <20221109221723.GA2948356-robh@kernel.org> References: <531d88b8-75db-1d8f-1384-b8d05594e7b3@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221109_141724_306761_9AF9AE13 X-CRM114-Status: GOOD ( 30.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 08, 2022 at 10:22:31PM +0000, Russell King (Oracle) wrote: > On Tue, Nov 08, 2022 at 09:55:58PM +0100, Krzysztof Kozlowski wrote: > > On 08/11/2022 17:33, Russell King (Oracle) wrote: > > > Add a DT binding for the Apple Mac System Management Controller. > > > > Drop the second, redundant "binding" from subject. It's already in prefix. > > Yet another thing that's been there from the start... how many more > things are you going to pick up in subsequent versions of the patch? > When does this stop? > > In any case, taking your comment literally, > > "dt-bindings: mfd: add for Apple Mac System Management Controller" > > makes no sense, so presumably you want something more than that. > > In any case, I see several recent cases already merged which follow > the pattern that I've used and that you've reviewed. > > > > Signed-off-by: Russell King (Oracle) > > > --- > > > .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ > > > 1 file changed, 67 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > new file mode 100644 > > > index 000000000000..014eba5a1bbc > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > @@ -0,0 +1,67 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Apple Mac System Management Controller > > > + > > > +maintainers: > > > + - Hector Martin > > > + > > > +description: > > > + Apple Mac System Management Controller implements various functions > > > + such as GPIO, RTC, power, reboot. > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - enum: > > > + - apple,t6000-smc > > > + - apple,t8103-smc > > > + - apple,t8112-smc > > > + - const: apple,smc > > > + > > > + reg: > > > + items: > > > + - description: SMC area > > > + - description: SRAM area > > > + > > > + reg-names: > > > + items: > > > + - const: smc > > > + - const: sram > > > + > > > + mboxes: > > > + maxItems: 1 > > > + > > > + gpio: > > > + $ref: /schemas/gpio/gpio-macsmc.yaml > > > > So this depends on other patch, so: > > 1. You need mention the dependency in cover letter (nothing there), > > 2. Re-order patches. > > > > The GPIO cannot go separate tree and this must be explicitly communicated. > > Sigh, getting an order that is sensible is really bloody difficult. It's not. Sub-devices before the MFD. The only time that doesn't work is when the sub-devices put the parent MFD in their example. The solution there is don't do that. Just 1 complete example in the MFD schema and no examples in the sub-devices. > I'm quite sure Lee is only going to want to apply the mfd bits. Indeed. I can't seem to make Lee care... All the schemas should really be applied together. > Then > what do we do with the other bits? GPIO stuff via the GPIO tree, then > wait a cycle before the rest can be merged. Or what? The schemas must be picked up in the same cycle. I don't care so much if subsystem maintainers' trees have warnings if they don't care, but I do care for linux-next. If the subsystem bits aren't picked up, then I'll pick them up if it comes to that. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel