From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org, Marek Vasut <marex@denx.de>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
stable@vger.kernel.org
Subject: Re: [PATCH v1] Revert "ARM: dts: imx7: Fix NAND controller size-cells"
Date: Mon, 5 Dec 2022 17:31:17 +0100 [thread overview]
Message-ID: <20221205172754.5a67e51d@xps-13> (raw)
In-Reply-To: <20221205152327.26881-1-francesco@dolcini.it>
Hi Francesco,
francesco@dolcini.it wrote on Mon, 5 Dec 2022 16:23:27 +0100:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> This reverts commit 753395ea1e45c724150070b5785900b6a44bd5fb.
>
> It introduced a boot regression on colibri-imx7, and potentially any
> other i.MX7 boards with MTD partition list generated into the fdt by
> U-Boot.
>
> While the commit we are reverting here is not obviously wrong, it fixes
> only a dt binding checker warning that is non-functional, while it
> introduces a boot regression and there is no obvious fix ready.
>
> Cc: stable@vger.kernel.org
> Fixes: 753395ea1e45 ("ARM: dts: imx7: Fix NAND controller size-cells")
> Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/
> Link: https://lore.kernel.org/all/20221205144917.6514168a@xps-13/
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> arch/arm/boot/dts/imx7s.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 03d2e8544a4e..0fc9e6b8b05d 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -1270,10 +1270,10 @@ dma_apbh: dma-apbh@33000000 {
> clocks = <&clks IMX7D_NAND_USDHC_BUS_RAWNAND_CLK>;
> };
>
> - gpmi: nand-controller@33002000 {
> + gpmi: nand-controller@33002000{
> compatible = "fsl,imx7d-gpmi-nand";
> #address-cells = <1>;
> - #size-cells = <0>;
> + #size-cells = <1>;
> reg = <0x33002000 0x2000>, <0x33004000 0x4000>;
> reg-names = "gpmi-nand", "bch";
> interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-12-05 16:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 15:23 [PATCH v1] Revert "ARM: dts: imx7: Fix NAND controller size-cells" Francesco Dolcini
2022-12-05 16:26 ` Marek Vasut
2022-12-05 17:58 ` Miquel Raynal
2022-12-05 18:07 ` Marek Vasut
2022-12-05 18:15 ` Francesco Dolcini
2022-12-05 18:18 ` Miquel Raynal
2022-12-05 18:52 ` Marek Vasut
2022-12-05 19:07 ` Francesco Dolcini
2022-12-06 10:16 ` Miquel Raynal
2022-12-06 19:02 ` Marek Vasut
2022-12-07 7:49 ` Francesco Dolcini
2022-12-08 10:51 ` Miquel Raynal
2022-12-08 11:13 ` Thorsten Leemhuis
2022-12-08 13:21 ` Marek Vasut
2022-12-08 13:49 ` Francesco Dolcini
2022-12-08 13:54 ` Marek Vasut
2022-12-08 16:26 ` Francesco Dolcini
2022-12-08 16:40 ` Francesco Dolcini
2022-12-09 13:30 ` Thorsten Leemhuis
2022-12-09 15:25 ` Arnd Bergmann
2022-12-09 15:38 ` Miquel Raynal
2022-12-05 16:31 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205172754.5a67e51d@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).