From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B571FC54EBE for ; Fri, 13 Jan 2023 15:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B7d5FHYY2hN4KKvmK88q07ilKdti9Tla1nCRXcrDDis=; b=ye5FSUpcLdHDrQ z3e4SLhem+l0FUhLzKULtXxBm8l/tJ7vumVb2ZNp1H4kXVHGFqZpRhKARYvNDYvZ/lbBnWZLqvCZx Hr1I5DXD0aZ85qv1g9x2zIMNPnBd04YUI1auK4YmhiJ9wVXGAEXeRwlYbe7VUMvWBXFqzV7+i7ls8 +jfA+Yd/w57Lbq1DIL8Z8Rjgx75vkVUg0A1DV+wBD6GZrkTiWDS/6WkCrdDY01VehNAoS5p/eA8Mc WrsMJ9PAn7vANfKjG9LCRO83r7lo5KURoI3x7u21qz2KcUEtH6jB1lFIXUAzeb3O6VgclDT3BGSJt hji0JgsDUJvrA9oEUcWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGLh4-00371s-Hw; Fri, 13 Jan 2023 15:10:10 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGLh0-0036xn-Pi for linux-arm-kernel@lists.infradead.org; Fri, 13 Jan 2023 15:10:08 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGLge-000623-6Q; Fri, 13 Jan 2023 16:09:44 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pGLgd-0000lN-4k; Fri, 13 Jan 2023 16:09:43 +0100 Date: Fri, 13 Jan 2023 16:09:43 +0100 From: Michael Tretter To: Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , Alexander Stein , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/16] dt-bindings: media: fsl-pxp: convert to yaml Message-ID: <20230113150943.GC20866@pengutronix.de> Mail-Followup-To: Michael Tretter , Krzysztof Kozlowski , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , Alexander Stein , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org References: <20230112-imx-pxp-v2-0-e2281da1db55@pengutronix.de> <20230112-imx-pxp-v2-1-e2281da1db55@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230113_071006_847250_100B9D96 X-CRM114-Status: GOOD ( 29.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 13 Jan 2023 12:56:12 +0100, Krzysztof Kozlowski wrote: > On 13/01/2023 10:54, Michael Tretter wrote: > > Convert the bindings of the Freescale Pixel Pipeline to YAML. > > > > The conversion drops the previously listed compatibles for several SoCs. > > It is unclear, if the PXP on these SoCs is compatible to any of the PXPs > > on the existing SoCs and would allow to reuse the already defined > > compatibles. The missing compatibles should be brought back when the > > support for the PXP on these SoCs is added. > > > > Signed-off-by: Michael Tretter > > --- > > Changelog: > > > > v2: > > > > - add fsl,imx6sll-pxp and fsl,imx6sx-pxp compatibles > > - restrict number of interrupts per variant > > - cleanup syntax > > --- > > .../devicetree/bindings/media/fsl,imx6ull-pxp.yaml | 82 ++++++++++++++++++++++ > > .../devicetree/bindings/media/fsl-pxp.txt | 26 ------- > > 2 files changed, 82 insertions(+), 26 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml b/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > > new file mode 100644 > > index 000000000000..c1232689a261 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > > @@ -0,0 +1,82 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > + > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/fsl,imx6ull-pxp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale Pixel Pipeline > > + > > +maintainers: > > + - Philipp Zabel > > + - Michael Tretter > > + > > +description: > > + The Pixel Pipeline (PXP) is a memory-to-memory graphics processing engine > > + that supports scaling, colorspace conversion, alpha blending, rotation, and > > + pixel conversion via lookup table. Different versions are present on various > > + i.MX SoCs from i.MX23 to i.MX7. > > + > > +properties: > > + compatible: > > + oneOf: > > + - const: fsl,imx6ul-pxp > > + - const: fsl,imx6ull-pxp > > + - const: fsl,imx7d-pxp > > These three are an enum. These are alternatives to the 'items:' entry below. Are you suggesting to use the following statement? oneOf: - enum: - fsl,imx6ul-pxp - fsl,imx6ull-pxp - fsl,imx7d-pxp - items: - enum: - fsl,imx6sll-pxp - fsl,imx6sx-pxp Why is this better than the one that I used? > > > + - items: > > + - enum: > > + - fsl,imx6sll-pxp > > + - fsl,imx6sx-pxp > > + - const: fsl,imx6ull-pxp > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + minItems: 1 > > + maxItems: 2 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: axi > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,imx6sx-pxp > > + then: > > + properties: > > + interrupts: > > + numItems: 1 > > That's not correct syntax... I am surprised that it works. Did you test > the bindings? I copied this syntax from renesas,wdt.yaml and ran make ARCH=arm dtbs_check DT_SCHEMA_FILES=fsl,imx6ull-pxp.yaml with SOC_IMX7D=y, SOC_IMX6UL=y, SOC_IMX6SLL=y, and SOC_IMX6SX=y. The latter two were not enabled in the v1, which is why it didn't catch the missing compatibles. On a closer look, I just saw that the checker ignored the schema due to the incorrect syntax and didn't produce any further errors. With the syntax fixed, the checker now produces also a few more errors about power-domains, which I will fix in v3. Is this syntax correct? allOf: - if: properties: compatible: contains: enum: - fsl,imx6sx-pxp then: properties: interrupts: minItems: 1 maxItems: 1 else: properties: interrupts: minItems: 2 maxItems: 2 Michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel