From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3AF4C636D4 for ; Mon, 13 Feb 2023 08:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yq0QZOZ2jClbofMrdNp0ZMFXQwGUVsUYfvIrIJfQFyM=; b=goVDWEwlRuz/4h 4B8BzKb0CPtEE3d8qpqzn5PabmdnvbCkuAkkETriHwIXTczdrYRVIVU0wBTqaoN3w8uVMeLfR3fR+ MVmCnOs2Ci/ajF389VjNtOGhw/fOH4Xj1wBgJQF612/2bbAoC9c49smP4JymV4eKK5ruZgdhVK07X wKT2/Fp92K4SbOmh9O42KosbToWG2qwTnpP54J6xLpivOxPLIzlxCDj5EnCcuui74EiAH4xg4MN9l fP5o0r+fz1WbIB4/W51pp+Q+5dzOw5colqqBYuP99euJbIS4rpEVaSom2JBEr9jUW9feGnotZtowJ oT4TpezoT9gNGeqfTh+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRTw8-00DYDj-ME; Mon, 13 Feb 2023 08:11:45 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRTw4-00DYAT-Jz for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 08:11:42 +0000 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31D5Ki0N021659; Mon, 13 Feb 2023 08:11:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : reply-to : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=Z6gmndh7hn35T25vfiaxGtwhAK87i7V4DUFpij/Ezfk=; b=oTo65ptqbe5EtAw+hvPnc9jYCbtZlKcApP5zq1QoMIUgEhy+CXkqiPRIPlhspcHkKkn7 UN8HlI+SzFYddcLh1KNOz4wjWQ9mZb3OjskZhuNSa/OPRKpa8nyM8ADAnO9ecNHU9ZWD bNxtHS3AaztiWFNMBRF5pvhWXhlMb6SxXdBYcNHJ//kJDVZc5I06zeP6ntQZhRrBFFbj C4FZzvAjxFS4JmYXORN2EN8ovVni7wSpX4MHzK4ksspP4eOBbH7fJ7Q+hyQmFId3eVI5 8Z+5ontMK1ltXsWspwdSXnalP2XhQ3XqK27C8EF8w7cH7JnSTtrRjByu5HEUHIMRFaLd 6A== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3np3deujgw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Feb 2023 08:11:16 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31D8BE0w006582 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Feb 2023 08:11:14 GMT Received: from quicinc.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 13 Feb 2023 00:11:07 -0800 Date: Mon, 13 Feb 2023 13:41:03 +0530 From: Srivatsa Vaddagiri To: Elliot Berman CC: Bjorn Andersson , Alex Elder , Murali Nalajala , "Jonathan Corbet" , Trilok Soni , "Carl van Schaik" , Prakruthi Deepak Heragu , Dmitry Baryshkov , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , "Krzysztof Kozlowski" , Bagas Sanjaya , Catalin Marinas , "Will Deacon" , Marc Zyngier , Jassi Brar , Sudeep Holla , , , , , Subject: Re: [PATCH v9 26/27] virt: gunyah: Add irqfd interface Message-ID: <20230213081103.GL332@quicinc.com> References: <20230120224627.4053418-1-quic_eberman@quicinc.com> <20230120224627.4053418-27-quic_eberman@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230120224627.4053418-27-quic_eberman@quicinc.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: FYSiYlOz-rpXG8-Xzk1DuHHq665gAgG8 X-Proofpoint-ORIG-GUID: FYSiYlOz-rpXG8-Xzk1DuHHq665gAgG8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-13_04,2023-02-09_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxscore=0 clxscore=1015 adultscore=0 mlxlogscore=574 malwarescore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302130072 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_001140_821389_DBF4FA18 X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Srivatsa Vaddagiri Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Elliot Berman [2023-01-20 14:46:25]: > +static int gunyah_irqfd_populate(struct gunyah_vm_resource_ticket *ticket, > + struct gunyah_resource *ghrsc) > +{ > + struct gunyah_irqfd *irqfd = container_of(ticket, struct gunyah_irqfd, ticket); > + u64 enable_mask = GH_DBL_NONBLOCK; > + u64 ack_mask = ~0; > + int ret = 0; > + > + irqfd->ghrsc = ghrsc; > + if (irqfd->level) { > + ret = gh_hypercall_dbl_set_mask(irqfd->ghrsc->capid, enable_mask, ack_mask); We probably want this mask set for both level and edge interrupts. > + if (ret) > + pr_warn("irq %d couldn't be set as level triggered. Might cause IRQ storm if asserted\n", > + irqfd->f->fn.irqfd.label); > + } > + kref_get(&irqfd->kref); Is this kref_get() really needed? > + > + return 0; > +} > + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel