From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Martyn Welch <martyn.welch@collabora.com>,
Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org, Abel Vesa <abel.vesa@nxp.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Lucas Stach <l.stach@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
Jacky Bai <ping.bai@nxp.com>
Subject: Re: [PATCH] arm64: dts: imx8mp-msc-sm2s: Add sound card
Date: Wed, 22 Feb 2023 20:57:42 +0100 [thread overview]
Message-ID: <20230222205742.505016e4@booty> (raw)
In-Reply-To: <20230222175941.7pdi7yg5am3ws4gp@pengutronix.de>
Hi Marco,
On Wed, 22 Feb 2023 18:59:41 +0100
Marco Felsch <m.felsch@pengutronix.de> wrote:
> Hi Luca,
>
> On 23-02-22, Luca Ceresoli wrote:
> > The MSC SM2-MB-EP1 carrier board for the SM2S-IMX8PLUS SMARC module has an
> > NXPP SGTL5000 audio codec connected to I2S-0 (sai2).
> >
> > This requires to:
> >
> > * add the power supplies (always on)
> > * enable sai2 with pinmuxes
> > * reparent the CLKOUT1 clock that feeds the codec SYS_MCLK to
> > IMX8MP_CLK_24M in order it to generate an accurate 24 MHz rate
> >
> > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> > ---
> > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 60 +++++++++++++++++++
> > 1 file changed, 60 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts
> > index 470ff8e31e32..894d9809f76d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts
> > @@ -14,6 +14,57 @@ / {
> > compatible = "avnet,sm2s-imx8mp-14N0600E-ep1",
> > "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp",
> > "fsl,imx8mp";
>
> ...
>
> > +/* I2S-0 = sai2 */
> > +&sai2 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_sai2>;
> > +
> > + assigned-clocks = <&clk IMX8MP_CLK_SAI2>;
> > + assigned-clock-parents = <&clk IMX8MP_AUDIO_PLL1_OUT>;
> > + assigned-clock-rates = <12288000>;
> > +
> > + fsl,sai-mclk-direction-output;
> > + status = "okay";
> > };
>
> Do you have some downstream patches for the sai interfaces? AFAIR Marek
> worked on this but the patches are not mainlien yet.
Right, my patch is based on the v3 series by Marek, and it should be
threaded accordingly
(https://lore.kernel.org/linux-arm-kernel/20230222172552.1545519-1-luca.ceresoli@bootlin.com/),
but I realize I haven't made it 100% clear -- sorry about this.
I guess I should just resend separately with a clarifying cover letter
next time.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-22 19:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 1:32 [PATCH v3 1/6] clk: Introduce devm_clk_hw_register_mux_parent_data() Marek Vasut
2022-06-25 1:32 ` [PATCH v3 2/6] clk: Introduce devm_clk_hw_register_gate_parent_data() Marek Vasut
2022-06-25 1:32 ` [PATCH v3 3/6] clk: imx: imx8mp: Add audiomix block control Marek Vasut
2022-06-27 15:35 ` Abel Vesa
2022-06-27 16:23 ` Marek Vasut
2022-06-28 7:44 ` Abel Vesa
2022-06-28 17:06 ` Marek Vasut
2022-06-29 7:41 ` Abel Vesa
2022-08-04 9:13 ` Peng Fan
2022-08-04 9:31 ` Marek Vasut
2022-08-11 14:20 ` Abel Vesa
2022-08-11 14:30 ` Marek Vasut
2022-08-11 15:03 ` Abel Vesa
2022-08-11 15:14 ` Abel Vesa
2022-08-11 16:38 ` Marek Vasut
2022-08-11 16:51 ` Abel Vesa
2022-06-29 7:43 ` Abel Vesa
[not found] ` <CAA+D8ANLrPML3Hp3fYyfiSSUs9V6xAu55d4Y2-8cVVAuTNwaMw@mail.gmail.com>
2022-10-19 14:33 ` Marek Vasut
[not found] ` <CAA+D8ANdOQaz05_SCmTgEW_bCS4ABBLgMzXese_3WWiF8WxzqA@mail.gmail.com>
2022-10-25 21:10 ` Marek Vasut
[not found] ` <CAA+D8AO3KZr9uxS-T1LXK568EeE-wf8yxGCYiayBBxFKDF_HZQ@mail.gmail.com>
2022-10-26 11:03 ` Marek Vasut
2023-02-22 16:58 ` Luca Ceresoli
2022-06-25 1:32 ` [PATCH v3 4/6] dt-bindings: clock: " Marek Vasut
2022-06-25 1:32 ` [PATCH v3 5/6] arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX Marek Vasut
2023-02-22 16:59 ` Luca Ceresoli
2022-06-25 1:32 ` [PATCH v3 6/6] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK Marek Vasut
2023-02-22 17:22 ` Luca Ceresoli
2023-02-22 17:25 ` [PATCH] arm64: dts: imx8mp-msc-sm2s: Add sound card Luca Ceresoli
2023-02-22 17:59 ` Marco Felsch
2023-02-22 18:39 ` Marek Vasut
2023-02-22 19:02 ` Marco Felsch
2023-02-23 16:23 ` Marek Vasut
2023-02-24 12:56 ` Marco Felsch
2023-02-22 19:57 ` Luca Ceresoli [this message]
2023-02-22 18:20 ` Krzysztof Kozlowski
2023-02-23 7:30 ` kernel test robot
2023-02-23 16:24 ` [PATCH v3 6/6] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK Marek Vasut
2023-02-24 16:16 ` Luca Ceresoli
2022-10-10 6:20 ` [PATCH v3 3/6] clk: imx: imx8mp: Add audiomix block control Shengjiu Wang
2022-11-21 8:17 ` [PATCH v3 1/6] clk: Introduce devm_clk_hw_register_mux_parent_data() Richard Leitner
2022-11-26 15:23 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222205742.505016e4@booty \
--to=luca.ceresoli@bootlin.com \
--cc=abel.vesa@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=marex@denx.de \
--cc=martyn.welch@collabora.com \
--cc=mturquette@baylibre.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).