From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ran Wang <ran.wang_1@nxp.com>,
Yang Yingliang <yangyingliang@huawei.com>,
Li Jun <jun.li@nxp.com>, Sean Anderson <sean.anderson@seco.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Colin Ian King <colin.i.king@gmail.com>,
Shawn Guo <shawnguo@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-usb@vger.kernel.org, kernel@pengutronix.de,
linuxppc-dev@lists.ozlabs.org, Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org
Subject: [PATCH 00/11] usb: phy: Convert to platform remove callback returning void
Date: Sun, 19 Mar 2023 10:24:17 +0100 [thread overview]
Message-ID: <20230319092428.283054-1-u.kleine-koenig@pengutronix.de> (raw)
Hello,
this series adapts the platform drivers below drivers/usb/phy to use the
.remove_new() callback. Compared to the traditional .remove() callback
.remove_new() returns no value. This is a good thing because the driver core
doesn't (and cannot) cope for errors during remove. The only effect of a
non-zero return value in .remove() is that the driver core emits a warning. The
device is removed anyhow and an early return from .remove() usually yields a
resource leak.
By changing the remove callback to return void driver authors cannot
reasonably assume any more that there is some kind of cleanup later.
All drivers could be converted trivally as they all returned zero
unconditionally in their .remove() callback.
Best regards
Uwe
Uwe Kleine-König (11):
usb: phy: ab8500: Convert to platform remove callback returning void
usb: phy: am335x: Convert to platform remove callback returning void
usb: phy: fsl: Convert to platform remove callback returning void
usb: phy: generic: Convert to platform remove callback returning void
usb: phy: gpio-vbus: Convert to platform remove callback returning
void
usb: phy: keystone: Convert to platform remove callback returning void
usb: phy: mv: Convert to platform remove callback returning void
usb: phy: mxs: Convert to platform remove callback returning void
usb: phy: tahvo: Convert to platform remove callback returning void
usb: phy: tegra: Convert to platform remove callback returning void
usb: phy: twl6030: Convert to platform remove callback returning void
drivers/usb/phy/phy-ab8500-usb.c | 6 ++----
drivers/usb/phy/phy-am335x.c | 5 ++---
drivers/usb/phy/phy-fsl-usb.c | 6 ++----
drivers/usb/phy/phy-generic.c | 6 ++----
drivers/usb/phy/phy-gpio-vbus-usb.c | 6 ++----
drivers/usb/phy/phy-keystone.c | 6 ++----
drivers/usb/phy/phy-mv-usb.c | 6 ++----
drivers/usb/phy/phy-mxs-usb.c | 6 ++----
drivers/usb/phy/phy-tahvo.c | 6 ++----
drivers/usb/phy/phy-tegra-usb.c | 6 ++----
drivers/usb/phy/phy-twl6030-usb.c | 6 ++----
11 files changed, 22 insertions(+), 43 deletions(-)
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2023-03-19 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 9:24 Uwe Kleine-König [this message]
2023-03-19 9:24 ` [PATCH 08/11] usb: phy: mxs: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-20 14:54 ` [EXT] " Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230319092428.283054-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Frank.Li@nxp.com \
--cc=colin.i.king@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ran.wang_1@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sean.anderson@seco.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).