linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Richard <thomas.richard@bootlin.com>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Haojian Zhuang" <haojian.zhuang@linaro.org>,
	"Vignesh R" <vigneshr@ti.com>,
	"Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
	"Andi Shyti" <andi.shyti@kernel.org>,
	"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Tom Joseph" <tjoseph@cadence.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org,  linux-i2c@vger.kernel.org,
	linux-phy@lists.infradead.org,  linux-pci@vger.kernel.org,
	gregory.clement@bootlin.com,  theo.lebrun@bootlin.com,
	thomas.petazzoni@bootlin.com, u-kumar1@ti.com,
	 Thomas Richard <thomas.richard@bootlin.com>
Subject: [PATCH 03/14] i2c: omap: wakeup the controller during suspend callback
Date: Mon, 15 Jan 2024 17:14:44 +0100	[thread overview]
Message-ID: <20240102-j7200-pcie-s2r-v1-3-84e55da52400@bootlin.com> (raw)
In-Reply-To: <20240102-j7200-pcie-s2r-v1-0-84e55da52400@bootlin.com>

A device may need the controller up during suspend_noirq or
resume_noirq.
But if the controller is autosuspended, there is no way to wakeup it
during suspend_noirq or resume_noirq because runtime pm is disabled
at this time.

The suspend callback wakes up the controller, so it is available until
its suspend_noirq callback (pm_runtime_force_suspend).
During the resume, it's restored by resume_noirq callback
(pm_runtime_force_resume). Then resume callback enables autosuspend.

So the controller is up during a little time slot in suspend and resume
sequences even if it's not used.

Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
 drivers/i2c/busses/i2c-omap.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 42165ef57946..57f0738fa748 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1575,9 +1575,24 @@ static int __maybe_unused omap_i2c_runtime_resume(struct device *dev)
 	return 0;
 }
 
+
+static int omap_i2c_suspend(struct device *dev)
+{
+	return pm_runtime_resume_and_get(dev);
+}
+
+static int omap_i2c_resume(struct device *dev)
+{
+	pm_runtime_mark_last_busy(dev);
+	pm_runtime_put_autosuspend(dev);
+
+	return 0;
+}
+
 static const struct dev_pm_ops omap_i2c_pm_ops = {
 	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
 				      pm_runtime_force_resume)
+	SET_SYSTEM_SLEEP_PM_OPS(omap_i2c_suspend, omap_i2c_resume)
 	SET_RUNTIME_PM_OPS(omap_i2c_runtime_suspend,
 			   omap_i2c_runtime_resume, NULL)
 };

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-01-15 16:17 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 16:14 [PATCH 00/14] Add suspend to ram support for PCIe on J7200 Thomas Richard
2024-01-15 16:14 ` [PATCH 01/14] gpio: pca953x: move suspend/resume to suspend_noirq/resume_noirq Thomas Richard
2024-01-15 19:56   ` Andy Shevchenko
2024-01-19 15:50     ` Thomas Richard
2024-01-16  7:43   ` Tony Lindgren
2024-01-19 17:01     ` Thomas Richard
2024-01-28  0:12       ` Linus Walleij
2024-02-08 16:19         ` Thomas Richard
2024-02-08 16:53           ` Bartosz Golaszewski
2024-02-08 21:29           ` Linus Walleij
2024-02-09  7:44             ` Thomas Richard
2024-02-09 10:50               ` Linus Walleij
2024-01-15 16:14 ` [PATCH 02/14] pinctrl: pinctrl-single: " Thomas Richard
2024-01-15 20:02   ` Andy Shevchenko
2024-01-19 16:08     ` Thomas Richard
2024-01-19 16:11       ` Andy Shevchenko
2024-01-22 14:33         ` Thomas Richard
2024-01-23 12:44           ` Andy Shevchenko
2024-01-31  8:05   ` Linus Walleij
2024-01-15 16:14 ` Thomas Richard [this message]
2024-01-15 20:03   ` [PATCH 03/14] i2c: omap: wakeup the controller during suspend callback Andy Shevchenko
2024-01-15 16:14 ` [PATCH 04/14] mux: mmio: Add resume support Thomas Richard
2024-01-15 20:05   ` Andy Shevchenko
2024-01-15 22:31   ` Peter Rosin
2024-01-19 16:25     ` Thomas Richard
2024-01-15 16:14 ` [PATCH 05/14] phy: ti: phy-j721e-wiz: make wiz_clock_init callable multiple times Thomas Richard
2024-01-23  7:18   ` Vinod Koul
2024-01-23  8:20     ` Thomas Richard
2024-01-23 14:02       ` Vinod Koul
2024-01-15 16:14 ` [PATCH 06/14] phy: ti: phy-j721e-wiz: add resume support Thomas Richard
2024-01-15 16:14 ` [PATCH 07/14] phy: cadence-torrent: extract calls to clk_get from cdns_torrent_clk Thomas Richard
2024-01-15 16:14 ` [PATCH 08/14] phy: cadence-torrent: register resets even if the phy is already configured Thomas Richard
2024-01-15 16:14 ` [PATCH 09/14] phy: cadence-torrent: move already_configured to struct cdns_torrent_phy Thomas Richard
2024-01-15 16:14 ` [PATCH 10/14] phy: cadence-torrent: remove noop_ops phy operations Thomas Richard
2024-01-15 16:14 ` [PATCH 11/14] phy: cadence-torrent: add suspend and resume support Thomas Richard
2024-01-16 18:22   ` Bjorn Helgaas
2024-01-22 14:24     ` Thomas Richard
2024-01-17 15:12   ` Philipp Zabel
2024-01-22 14:28     ` Thomas Richard
2024-01-15 16:14 ` [PATCH 12/14] PCI: cadence: add resume support to cdns_pcie_host_setup() Thomas Richard
2024-01-15 16:14 ` [PATCH 13/14] PCI: j721e: move reset GPIO to device struct Thomas Richard
2024-01-15 20:08   ` Andy Shevchenko
2024-01-16 18:19   ` Bjorn Helgaas
2024-01-15 16:14 ` [PATCH 14/14] PCI: j721e: add suspend and resume support Thomas Richard
2024-01-15 20:13   ` Andy Shevchenko
2024-01-22 15:30     ` Thomas Richard
2024-01-22 21:36       ` Andy Shevchenko
2024-01-24 14:09         ` Thomas Richard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240102-j7200-pcie-s2r-v1-3-84e55da52400@bootlin.com \
    --to=thomas.richard@bootlin.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=andi.shyti@kernel.org \
    --cc=andy@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=brgl@bgdev.pl \
    --cc=gregory.clement@bootlin.com \
    --cc=haojian.zhuang@linaro.org \
    --cc=jmkrzyszt@gmail.com \
    --cc=kishon@kernel.org \
    --cc=kw@linux.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=peda@axentia.se \
    --cc=robh@kernel.org \
    --cc=theo.lebrun@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tjoseph@cadence.com \
    --cc=tony@atomide.com \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).