From: Andre Przywara <andre.przywara@arm.com>
To: "Ryan Walklin" <ryan@testtoast.com>
Cc: "Viresh Kumar" <viresh.kumar@linaro.org>,
"Yangtao Li" <tiny.windzz@gmail.com>,
"Viresh Kumar" <vireshk@kernel.org>, "Nishanth Menon" <nm@ti.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-sunxi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
"Brandon Cheo Fusi" <fusibrandon13@gmail.com>,
"Martin Botka" <martin.botka@somainline.org>,
"Martin Botka" <martin.botka1@gmail.com>,
"Chris Morgan" <macroalpha82@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Sudeep Holla" <sudeep.holla@arm.com>
Subject: Re: [PATCH v4 0/8] cpufreq: sun50i: Add Allwinner H616 support
Date: Mon, 15 Apr 2024 01:14:35 +0100 [thread overview]
Message-ID: <20240415011435.2aeae1f1@minigeek.lan> (raw)
In-Reply-To: <0e021133-f8c1-457d-9079-d9c972e0e69b@app.fastmail.com>
On Thu, 04 Apr 2024 20:44:02 +1300
"Ryan Walklin" <ryan@testtoast.com> wrote:
Hi Ryan,
> On Thu, 4 Apr 2024, at 7:40 PM, Viresh Kumar wrote:
> > Is it okay to merge all the changes via the cpufreq tree ?
>
> I have tested this series with an H700-based board, and have at least one speed-bin (1.032GHz) is not supported although the governor attempts to enable it based on the opp-supported-hw bitmask, and I am unable to reach the 1.5GHz bin at 1.16v (or higher) despite it working on the vendor BSP (kernel panic at boot if enabled), so this may need some slight rework.
Thanks for the report!
So can you try to merge the 1.032 GHz OPP into the 1.008 GHz one? That
would be beneficial anyways since this is the default frequency that
U-Boot sets up.
Should be:
opp-1008000000 {
....
opp-microvolt-speed5 = <900000>;
opp-supported-hw = <0x3f>;
....
As for the 1.5 GHz speed bin: We could leave that out for now if it
causes trouble. But can you first state how you got the OPPs? I copied
them from some table you dumped once on IRC, but it would be good to
double check what the actual values are that the BSP kernel runs with.
The values in the vendor DT are highly inconsistent, besides we don't
know for sure which speed bin index the BSP is using and how this maps
to our method.
Cheers,
Andre
> I have reached out to Andre on IRC to debug.
>
> Ryan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-15 0:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 14:13 [PATCH v4 0/8] cpufreq: sun50i: Add Allwinner H616 support Andre Przywara
2024-03-29 14:13 ` [PATCH v4 1/8] firmware: smccc: Export revision soc_id function Andre Przywara
2024-03-29 14:13 ` [PATCH v4 2/8] cpufreq: dt-platdev: Blocklist Allwinner H616/618 SoCs Andre Przywara
2024-03-29 14:13 ` [PATCH v4 3/8] dt-bindings: opp: Describe H616 OPPs and opp-supported-hw Andre Przywara
2024-03-29 14:13 ` [PATCH v4 4/8] cpufreq: sun50i: Refactor speed bin decoding Andre Przywara
2024-03-29 14:13 ` [PATCH v4 5/8] cpufreq: sun50i: Add support for opp_supported_hw Andre Przywara
2024-03-29 14:13 ` [PATCH v4 6/8] cpufreq: sun50i: Add H616 support Andre Przywara
2024-03-29 14:13 ` [PATCH v4 7/8] arm64: dts: allwinner: h616: Add CPU OPPs table Andre Przywara
2024-03-29 14:13 ` [PATCH v4 8/8] arm64: dts: allwinner: h616: enable DVFS for all boards Andre Przywara
2024-04-04 6:40 ` [PATCH v4 0/8] cpufreq: sun50i: Add Allwinner H616 support Viresh Kumar
2024-04-04 7:44 ` Ryan Walklin
2024-04-15 0:14 ` Andre Przywara [this message]
2024-04-18 11:16 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415011435.2aeae1f1@minigeek.lan \
--to=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fusibrandon13@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lpieralisi@kernel.org \
--cc=macroalpha82@gmail.com \
--cc=mark.rutland@arm.com \
--cc=martin.botka1@gmail.com \
--cc=martin.botka@somainline.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan@testtoast.com \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tiny.windzz@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).