From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 795E1C433E3 for ; Wed, 31 Mar 2021 08:19:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15B5B61883 for ; Wed, 31 Mar 2021 08:19:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15B5B61883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GW7E553o9eVX9K/bJ1oh0oFa8CP6m2fByNtMy9OTNKs=; b=Z8w/SSmvp5MWqKRIhNg3rd1Hb Govl5/t6ibZUFtG210DAKJIDIFyM9KzaYyVL9YWF0XSbILSU0wPtRiVE3bPdKGmv5DgEZHxUz4/mf jRjIg+7r9W+24Za9phhpdQg4Gfvv+2DO6AhKpX3HYqkLXBak0fONtE6qptmm5hJ03GDvcjToHyMw/ x+Sb2ZRQf/FWG/bCrmTpzvPq4QS5SKlxgXGyx91p/CCb2kqDckCcaoaQ9JCYN2MnfjofHkmshMrss 1lBjRaPE3KR73xOMEJuMZUNnXsScdhhze+WJEjH8VyRBjQPMFivlpbpOlj1B3fMHgE5L9MUO7qHzs qRCQpHnSg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRW2s-005uzQ-Q9; Wed, 31 Mar 2021 08:17:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRW2m-005uui-JO for linux-arm-kernel@lists.infradead.org; Wed, 31 Mar 2021 08:17:42 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F12AB619CF; Wed, 31 Mar 2021 08:17:38 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lRW2i-004qpi-TT; Wed, 31 Mar 2021 09:17:37 +0100 MIME-Version: 1.0 Date: Wed, 31 Mar 2021 09:17:36 +0100 From: Marc Zyngier To: Dan Carpenter Cc: kbuild@lists.01.org, Will Deacon , lkp@intel.com, kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org, Steven Price , Jianyong Wu Subject: Re: [arm-platforms:kvm-arm64/ptp 1/7] drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)' In-Reply-To: <20210331043704.GG2065@kadam> References: <20210331043704.GG2065@kadam> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <20266a7616a349184aa66790c5851882@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: dan.carpenter@oracle.com, kbuild@lists.01.org, will@kernel.org, lkp@intel.com, kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org, steven.price@arm.com, jianyong.wu@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_091740_937418_11FFC786 X-CRM114-Status: GOOD ( 10.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-03-31 05:37, Dan Carpenter wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git > kvm-arm64/ptp > head: b44b5b769890e0e73e2f9fdf461fcbcf72f14ab2 > commit: fa591eac2e1ffdba4b7957fcc05b4d1f95246533 [1/7] arm/arm64: > Probe for the presence of KVM hypervisor > config: arm64-randconfig-m031-20210330 (attached as .config) > compiler: aarch64-linux-gcc (GCC) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() > warn: signedness bug returning '(-22)' > > vim +46 drivers/firmware/smccc/kvm_guest.c > > fa591eac2e1ffd Will Deacon 2020-12-09 43 bool > kvm_arm_hyp_service_available(u32 func_id) > ^^^^ > > fa591eac2e1ffd Will Deacon 2020-12-09 44 { > fa591eac2e1ffd Will Deacon 2020-12-09 45 if (func_id >= > ARM_SMCCC_KVM_NUM_FUNCS) > fa591eac2e1ffd Will Deacon 2020-12-09 @46 return -EINVAL; > ^^^^^^^^^^^^^^^ > This counts as true. Nice catch. Now fixed. Thanks for the heads up. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel