From: Kever Yang <kever.yang@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Tomohiro Mayama <parly-gh@iris.mystia.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm: dts: rockchip: fix vcc_host_5v regulator for usb3 host
Date: Mon, 19 Aug 2019 08:29:31 +0800 [thread overview]
Message-ID: <208c56e1-bfe0-a982-927d-bdddc3116631@rock-chips.com> (raw)
In-Reply-To: <2932927.UJgUFA1Pmh@phil>
Hi Heiko,
On 2019/8/16 下午8:24, Heiko Stuebner wrote:
> Hi Kever, TL,
>
> [added TL Lim for clarification]
>
> Am Donnerstag, 15. August 2019, 10:12:52 CEST schrieb Kever Yang:
>> According to rock64 schemetic V2 and V3, the VCC_HOST_5V output is
>> controlled by USB_20_HOST_DRV, which is the same as VCC_HOST1_5V.
> The v1 schematics I have do reference the GPIO0_A0 as controlling this
> supply, so the big question would be how to handle the different versions.
>
> Because adding this would probably break v1 boards in this function.
>
> @TL: where v1 boards also sold or were they only used during development?
I have check this with TL when I make this patch, the V1 hardware was
never sold and only V2/V3
are available on the market.
Thanks,
- Kever
> If this were the case, we could just apply the patch, not caring about
> v1 boards, but if v1 boards were also sold to customers there would be
> more of a problem.
>
> Thanks
> Heiko
>
>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>> Changes in v2:
>> - remove enable-active-high property
>>
>> arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 11 ++---------
>> 1 file changed, 2 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> index 7cfd5ca6cc85..62936b432f9a 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> @@ -34,10 +34,9 @@
>>
>> vcc_host_5v: vcc-host-5v-regulator {
>> compatible = "regulator-fixed";
>> - enable-active-high;
>> - gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
>> + gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
>> pinctrl-names = "default";
>> - pinctrl-0 = <&usb30_host_drv>;
>> + pinctrl-0 = <&usb20_host_drv>;
>> regulator-name = "vcc_host_5v";
>> regulator-always-on;
>> regulator-boot-on;
>> @@ -320,12 +319,6 @@
>> rockchip,pins = <0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
>> };
>> };
>> -
>> - usb3 {
>> - usb30_host_drv: usb30-host-drv {
>> - rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
>> - };
>> - };
>> };
>>
>> &sdmmc {
>>
>
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-19 0:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 8:12 [PATCH v2] arm: dts: rockchip: fix vcc_host_5v regulator for usb3 host Kever Yang
2019-08-16 12:24 ` Heiko Stuebner
2019-08-19 0:29 ` Kever Yang [this message]
2019-08-19 14:43 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=208c56e1-bfe0-a982-927d-bdddc3116631@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=katsuhiro@katsuster.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=parly-gh@iris.mystia.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).