From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F32F2C6FA82 for ; Fri, 23 Sep 2022 10:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FE73hkj8NuoYlGWDA8fvjHNYGyrpJqd1htDxOY/QI5Q=; b=WeVPwzybL4qaSt 416WaMxKKjlbPFZZlrkRsppCSO3v8ArABPdo6BMBrLgGpRMGH5/eqr0GNqbPgzq+xrN1GcEv1lUe3 kzx7jlEG8TQkVHo2K39Rf/20HGgAmnh45HjAnK5YSO+q1bELSIBlsKTU79n7g51SrjrFVOij7yPSb y9fvLB/3YF0ZpBhPTBigqQJ9x73cfEEw8ngPFUgQTt8doGyZvEs9Dd0gMmeKqBO90qV/TL/E4q64H TlhSVYYJCE7aFtIQhawoLCVRRue2PY2UJYK8HPwNlGc9FHjajDqoxgwJZPZV+lm5VSkiJqm+xEsbO YqI5evtzQY8WT+9Z3mmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obfVs-003XfL-Eu; Fri, 23 Sep 2022 10:02:28 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obfVm-003Xbm-P3; Fri, 23 Sep 2022 10:02:24 +0000 Received: from p508fdb48.dip0.t-ipconnect.de ([80.143.219.72] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1obfVi-0005d7-QY; Fri, 23 Sep 2022 12:02:18 +0200 From: Heiko Stuebner To: Nicolas Frattaroli , Rob Herring , Krzysztof Kozlowski , Dan Johansen Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: Enable HDMI and GPU on quartz64-b Date: Fri, 23 Sep 2022 12:02:18 +0200 Message-ID: <2218487.usQuhbGJ8B@phil> In-Reply-To: References: <20220920143446.633956-1-frattaroli.nicolas@gmail.com> <2198677.PYKUYFuaPT@phil> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220923_030222_857735_D07703D3 X-CRM114-Status: GOOD ( 32.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Freitag, 23. September 2022, 11:53:52 CEST schrieb Dan Johansen: > > Den 23.09.2022 kl. 11.45 skrev Heiko Stuebner: > > Hi, > > > > Am Donnerstag, 22. September 2022, 23:22:37 CEST schrieb Dan Johansen: > >> This seems to be based against linux-next and not mainline. It fails to > >> apply on mainline for me. > > I would not expect things any other way though :-) . > > I.e. in the current cycle everything new is of course targetting > > v6.1 and the Quartz boards already saw some other changes. > > Ah okay. I have misunderstood the submitting process then. > > I was under the impression that a patch should always target the latest > -rc1, in this case 6.0-rc1. > > I did not know that when you are at rc6/rc7 it's okay to target > linux-next without > mentioning it. > > Sorry for my noise. no worries - just to clarify a bit more, the issue gets slightly more complex :-) . I.e. patches should always target the maintainer-branch you're expecting them getting applied to. During the whole development cycle there is a lot of movement happening in each maintainer tree, so targetting some completely separate rc-kernel won't really make sense. Most of the time targetting -rc1 might work in the beginning, but when there are other changes already applied you need to take these into account too. Heiko > >> Den 20.09.2022 kl. 16.34 skrev Nicolas Frattaroli: > >>> This enables the GPU and HDMI output (including HDMI audio) on > >>> the PINE64 Quartz64 Model B single board computer. > >>> > >>> Signed-off-by: Nicolas Frattaroli > >>> --- > >>> .../boot/dts/rockchip/rk3566-quartz64-b.dts | 60 +++++++++++++++++++ > >>> 1 file changed, 60 insertions(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > >>> index 0f623198970f..77b179cd20e7 100644 > >>> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > >>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > >>> @@ -4,6 +4,7 @@ > >>> > >>> #include > >>> #include > >>> +#include > >>> #include "rk3566.dtsi" > >>> > >>> / { > >>> @@ -28,6 +29,17 @@ gmac1_clkin: external-gmac1-clock { > >>> #clock-cells = <0>; > >>> }; > >>> > >>> + hdmi-con { > >>> + compatible = "hdmi-connector"; > >>> + type = "a"; > >>> + > >>> + port { > >>> + hdmi_con_in: endpoint { > >>> + remote-endpoint = <&hdmi_out_con>; > >>> + }; > >>> + }; > >>> + }; > >>> + > >>> leds { > >>> compatible = "gpio-leds"; > >>> > >>> @@ -183,6 +195,33 @@ &gmac1m1_clkinout > >>> status = "okay"; > >>> }; > >>> > >>> +&gpu { > >>> + mali-supply = <&vdd_gpu>; > >>> + status = "okay"; > >>> +}; > >>> + > >>> +&hdmi { > >>> + avdd-0v9-supply = <&vdda0v9_image>; > >>> + avdd-1v8-supply = <&vcca1v8_image>; > >>> + status = "okay"; > >>> +}; > >>> + > >>> +&hdmi_in { > >>> + hdmi_in_vp0: endpoint { > >>> + remote-endpoint = <&vp0_out_hdmi>; > >>> + }; > >>> +}; > >>> + > >>> +&hdmi_out { > >>> + hdmi_out_con: endpoint { > >>> + remote-endpoint = <&hdmi_con_in>; > >>> + }; > >>> +}; > >>> + > >>> +&hdmi_sound { > >>> + status = "okay"; > >>> +}; > >>> + > >>> &i2c0 { > >>> status = "okay"; > >>> > >>> @@ -456,6 +495,10 @@ &i2c5 { > >>> status = "disabled"; > >>> }; > >>> > >>> +&i2s0_8ch { > >>> + status = "okay"; > >>> +}; > >>> + > >>> &i2s1_8ch { > >>> pinctrl-names = "default"; > >>> pinctrl-0 = <&i2s1m0_sclktx > >> The above part does not seem to exist in the current mainline (rc6) git > >> repo. > > which is of course already in linux-next, so this > > patch just applied nicely. > > > > > > Heiko > > > >>> @@ -677,3 +720,20 @@ &usb_host0_ehci { > >>> &usb_host0_ohci { > >>> status = "okay"; > >>> }; > >>> + > >>> +&vop { > >>> + assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>; > >>> + assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>; > >>> + status = "okay"; > >>> +}; > >>> + > >>> +&vop_mmu { > >>> + status = "okay"; > >>> +}; > >>> + > >>> +&vp0 { > >>> + vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 { > >>> + reg = ; > >>> + remote-endpoint = <&hdmi_in_vp0>; > >>> + }; > >>> +}; > > > > > > > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel