From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D25C43613 for ; Thu, 20 Jun 2019 12:28:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AC81206E0 for ; Thu, 20 Jun 2019 12:28:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uJK0x06+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AC81206E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LsP9A++vsCOReg391fNVMdyCe2Rt8n4Uf6VibqW5y+M=; b=uJK0x06+i/U/mL px+VA0WeLAc8w33wSYQck74Ku5xWjA/KaaYGWORAtnJpqRehtxftm3/uoKLK3ZT4AD1GddO+sdaqw nCOLbp4wGUiYLmSED+T5vvLkCjkFUu8liC59uXNpYKGOdRal0eO0i0/HKTcq3m7Nhq3b1C/ih91od wi9unRl7hGXsfvgrskx/FJgPcSdnT7aePX0lzHOpugsKW4Debg8V8Mxseflsag+wT9tyOn4V3khs8 Az/aql2NS/f5icz7K+JrShk+AMWekLjWzN1oba29HE6VhPGRAySDrqZPlZ4AxMC3nhF8pkR4eLbDj MfvGGaVlSCp6YDiJNoDg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdwB0-00012X-Nw; Thu, 20 Jun 2019 12:28:26 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdwAx-00011T-0T; Thu, 20 Jun 2019 12:28:24 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hdwAp-0003Td-BK; Thu, 20 Jun 2019 14:28:15 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Doug Anderson Subject: Re: [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators Date: Thu, 20 Jun 2019 14:28:14 +0200 Message-ID: <2226970.BAPq4liE1j@diego> In-Reply-To: References: <1458265206-15733-1-git-send-email-heiko@sntech.de> <1458265206-15733-5-git-send-email-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_052823_205903_DDA1DF20 X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LKML , "open list:ARM/Rockchip SoC..." , Matthias Kaehlcke , Yakir Yang , Enric Balletbo i Serra , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Doug, Am Donnerstag, 20. Juni 2019, 03:27:55 CEST schrieb Doug Anderson: > On Wed, Fri, 18 Mar 2016 Heiko Stuebner wrote: > > > > The panels need a bit of time to actually turn on. If this isn't > > observed, this results in problems when trying talk to the panels > > and thus produces detection errors. 100ms seem to be a safe value > > for the time being. > > > > Signed-off-by: Heiko Stuebner > > --- > > arch/arm/boot/dts/rk3288-veyron-jaq.dts | 1 + > > arch/arm/boot/dts/rk3288-veyron-jerry.dts | 1 + > > arch/arm/boot/dts/rk3288-veyron-minnie.dts | 1 + > > arch/arm/boot/dts/rk3288-veyron-speedy.dts | 1 + > > 4 files changed, 4 insertions(+) > > I know it was 3 years ago, but any idea how to reproduce the problems > you were seeing without this patch? I believe the downstream kernel > never had any delay like this and I'm not aware of any issues. > > I wonder if the need for this extra 100 ms delay is no longer there > now that we have: > > 3157694d8c7f pwm-backlight: Add support for PWM delays proprieties. > 5fb5caee92ba pwm-backlight: Enable/disable the PWM before/after LCD > enable toggle. > 6d5922dd0d60 ARM: dts: rockchip: set PWM delay backlight settings for Veyron I just did a non-scientific test on my jerry+minnie and yes, simply reverting that patch does not seem to affect display bringup and I still get a prompt. So I guess we could just revert that patch in light of the changes. [patches welcome ;-) ] Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel