From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] ARM: debug-ll: reorder Kconfig alphanumerically
Date: Thu, 17 Dec 2015 17:14:57 +0100 [thread overview]
Message-ID: <2266750.YuAszZRgmA@wuerfel> (raw)
In-Reply-To: <20151217104508.GG8644@n2100.arm.linux.org.uk>
On Thursday 17 December 2015 10:45:08 Russell King - ARM Linux wrote:
> On Fri, Dec 04, 2015 at 11:30:41PM +0100, Arnd Bergmann wrote:
> > + config DEBUG_LL_UART_EFM32
> > + bool "Kernel low-level debugging via efm32 UART"
> > + depends on ARCH_EFM32
> > + help
> > + Say Y here if you want the debug print routines to direct
> > + their output to an UART or USART port on efm32 based
> > + machines. Use the following addresses for DEBUG_UART_PHYS:
> > +
> > + 0x4000c000 | USART0
> > + 0x4000c400 | USART1
> > + 0x4000c800 | USART2
> > + 0x4000e000 | UART0
> > + 0x4000e400 | UART1
> > +
>
> NAK. The DEBUG_LL options are _supposed_ to be at the end - this option
> was correctly positioned:
Ok, got it. I thought about this briefly when I did the reorganization but
assumed it was not intentional and just oddly named. DEBUG_LL_UART_EFM32
it a bit different from all the other options, so either location seemed
reasonable:
* like DEBUG_LL_UART_8250 and DEBUG_LL_UART_PL01X, we don't configure
a particular address based on the platform, and the naming is consistent
with those options.
* like all other options, it specific to one particular platform, and
simply turning on DEBUG_LL from a defconfig file without selecting
a particular target ends up picking the first one, and that is
intentionally a platform specific option, so we don't have to pick
one explicitly.
I've queued up the patch below to avoid having to rebuild the entire
next/multiplatform branch, let me know if you'd rather see that branch
rebuilt.
Arnd
>From 06920d4eeabcd824436ace6fbd6cf49739a5812a Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 17 Dec 2015 16:59:55 +0100
Subject: [PATCH] ARM: debug-ll: move DEBUG_LL_UART_EFM32 to correct Kconfig location
I accidentally move the DEBUG_LL_UART_EFM32 option when sorting all
other options alphanumerically, but it belongs into the same group
as DEBUG_LL_UART_8250 and DEBUG_LL_UART_PL01X.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 1dc9341 ("ARM: debug-ll: reorder Kconfig alphanumerically")
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 3626b8b..776fc7c 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -246,20 +246,6 @@ choice
Say Y here if you want the debug print routines to direct
their output to the UA0 serial port in the CX92755.
- config DEBUG_LL_UART_EFM32
- bool "Kernel low-level debugging via efm32 UART"
- depends on ARCH_EFM32
- help
- Say Y here if you want the debug print routines to direct
- their output to an UART or USART port on efm32 based
- machines. Use the following addresses for DEBUG_UART_PHYS:
-
- 0x4000c000 | USART0
- 0x4000c400 | USART1
- 0x4000c800 | USART2
- 0x4000e000 | UART0
- 0x4000e400 | UART1
-
config DEBUG_EP93XX
bool "Kernel low-level debugging messages via ep93xx UART"
depends on ARCH_EP93XX
@@ -1299,6 +1285,20 @@ choice
options; the platform specific options are deprecated
and will be soon removed.
+ config DEBUG_LL_UART_EFM32
+ bool "Kernel low-level debugging via efm32 UART"
+ depends on ARCH_EFM32
+ help
+ Say Y here if you want the debug print routines to direct
+ their output to an UART or USART port on efm32 based
+ machines. Use the following addresses for DEBUG_UART_PHYS:
+
+ 0x4000c000 | USART0
+ 0x4000c400 | USART1
+ 0x4000c800 | USART2
+ 0x4000e000 | UART0
+ 0x4000e400 | UART1
+
config DEBUG_LL_UART_PL01X
bool "Kernel low-level debugging via ARM Ltd PL01x Primecell UART"
help
next prev parent reply other threads:[~2015-12-17 16:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 22:30 [PATCH 00/10] ARM: debug-ll fixes Arnd Bergmann
2015-12-04 22:30 ` [PATCH 01/10] ARM: debug-ll: fix UART configuration with ARCH_KEYSTONE Arnd Bergmann
2015-12-04 22:30 ` [PATCH 02/10] ARM: debug-ll: reorganize mvebu debug uart config Arnd Bergmann
2015-12-07 13:13 ` Daniel Thompson
2015-12-07 14:35 ` Arnd Bergmann
2015-12-04 22:30 ` [PATCH 03/10] ARM: debug-ll: rework ep93xx handling Arnd Bergmann
2015-12-10 23:17 ` Linus Walleij
2015-12-04 22:30 ` [PATCH 04/10] ARM: debug-ll: rework SPEAr handling Arnd Bergmann
2015-12-04 22:30 ` [PATCH 05/10] ARM: debug-ll: rework integrator/versatile handling Arnd Bergmann
2015-12-10 23:18 ` Linus Walleij
2015-12-04 22:30 ` [PATCH 06/10] ARM: debug-ll: rework gemini handling Arnd Bergmann
2015-12-07 15:24 ` Hans Ulli Kroll
2015-12-04 22:30 ` [PATCH 07/10] ARM: debug-ll: rework lpc32xx handling Arnd Bergmann
2015-12-06 11:33 ` Vladimir Zapolskiy
2015-12-04 22:30 ` [PATCH 08/10] ARM: debug-ll: rework footbridge handling Arnd Bergmann
2015-12-04 22:30 ` [PATCH 09/10] ARM: debug-ll: reorder Kconfig alphanumerically Arnd Bergmann
2015-12-17 10:45 ` Russell King - ARM Linux
2015-12-17 16:14 ` Arnd Bergmann [this message]
2015-12-04 22:30 ` [PATCH 10/10] ARM: orion/mvebu: unify debug-ll virtual addresses Arnd Bergmann
2015-12-07 17:30 ` Gregory CLEMENT
2015-12-17 10:50 ` [PATCH 00/10] ARM: debug-ll fixes Russell King - ARM Linux
2015-12-17 16:09 ` Arnd Bergmann
2015-12-22 15:06 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2266750.YuAszZRgmA@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).