From: cristian.birsan@microchip.com (cristian.birsan at microchip.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux-next v3 3/4] usb: gadget: udc: atmel: Use dev_err() to display EP configuration error
Date: Mon, 3 Apr 2017 10:19:53 +0300 [thread overview]
Message-ID: <226692c3b986abe4ec4239472a4d57e32dfc5a71.1491201365.git.cristian.birsan@microchip.com> (raw)
In-Reply-To: <cover.1491201365.git.cristian.birsan@microchip.com>
From: Cristian Birsan <cristian.birsan@microchip.com>
Use dev_err() to display EP configuration error to avoid silent failure.
Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 8bc0b52a..3ccc341 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -1851,8 +1851,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
* but it's clearly harmless...
*/
if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED))
- dev_dbg(&udc->pdev->dev,
- "ODD: EP0 configuration is invalid!\n");
+ dev_err(&udc->pdev->dev,
+ "ODD: EP0 configuration is invalid!\n");
/* Preallocate other endpoints */
n = fifo_mode ? udc->num_ep : udc->configured_ep;
@@ -1860,8 +1860,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
ep = &udc->usba_ep[i];
usba_ep_writel(ep, CFG, ep->ept_cfg);
if (!(usba_ep_readl(ep, CFG) & USBA_EPT_MAPPED))
- dev_dbg(&udc->pdev->dev,
- "ODD: EP%d configuration is invalid!\n", i);
+ dev_err(&udc->pdev->dev,
+ "ODD: EP%d configuration is invalid!\n", i);
}
}
--
2.7.4
next prev parent reply other threads:[~2017-04-03 7:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 7:19 [PATCH linux-next v3 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes cristian.birsan at microchip.com
2017-04-03 7:19 ` [PATCH linux-next v3 1/4] usb: gadget: udc: atmel: Check fifo configuration values against device tree cristian.birsan at microchip.com
2017-04-03 7:19 ` [PATCH linux-next v3 2/4] usb: gadget: udc: atmel: Minor code cleanup cristian.birsan at microchip.com
2017-04-05 12:33 ` Felipe Balbi
2017-04-07 16:05 ` m91496
2017-04-03 7:19 ` cristian.birsan at microchip.com [this message]
2017-04-03 7:19 ` [PATCH linux-next v3 4/4] usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0 cristian.birsan at microchip.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=226692c3b986abe4ec4239472a4d57e32dfc5a71.1491201365.git.cristian.birsan@microchip.com \
--to=cristian.birsan@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).