From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4779EC6FD1D for ; Fri, 17 Mar 2023 05:04:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yr+o0Z06GP8yRWgKXNngGRKQ8qDCwkq3dvm913f2VWg=; b=c5LHczPe4IiBMN knc9Dxc61MEM48/kb2eFe+mc5kZELbgWXkiTcMxqv5WR5QcbSAMH34/l0DR7VMPOlk61T8c25uSO7 W9kVBIjs0gUAY3xO8ItB6aTfNwExUuegRyfStxXrC7oddWtD3D3jUUpXXheuGRzIqZymv8i5nOdZn oIP3Z5dr2B/b2uUGXRgGgAVTfVgT8Y940sIk0H/3hS2hDcRwy/UeZDlkIrvxsFpM5Qo3nk7ACRS2x RHTaKH0OEPISEi5G9NJTKkJk6/okgCEmOQYyvziH0w3w5PnMrvPmtsOF5tNQWYb8x4LD7QBvhUKS+ J4btT3eUAC48PDMvVsOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pd2Ez-0010W9-2a; Fri, 17 Mar 2023 05:02:57 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pd2Ew-0010VD-15 for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 05:02:56 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32H52eVZ118036; Fri, 17 Mar 2023 00:02:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1679029360; bh=O3wqgAjd5Kq/xmlrss1YwHCRDPVlxQ49A5FvgeboGmc=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=RvpkluMDvA6JKT9Ccec86ev48N6FKa9H05fhakyQhp3ZvU5cGuW86zWNWnOAl8Jig +K4wGN7F0vkwJfQYu2wdpJyJqcXm+eH44ESF/L9ZZw0Y89XgRjCZh4L/JpbrNHTJl9 GZxYzy6Yduq9o5pDZzHE8NPtQCj3dW7bMpW350V0= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32H52dYo056248 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Mar 2023 00:02:39 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 17 Mar 2023 00:02:39 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 17 Mar 2023 00:02:39 -0500 Received: from [10.24.69.114] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32H52Yk9102104; Fri, 17 Mar 2023 00:02:35 -0500 Message-ID: <22b8860c-12bd-384d-41af-93f1dde9a0fd@ti.com> Date: Fri, 17 Mar 2023 10:32:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR To: Roger Quadros , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon CC: , , , , , , References: <20230313111127.1229187-1-danishanwar@ti.com> <20230313111127.1229187-5-danishanwar@ti.com> <60e73395-f670-6eaa-0eb7-389553320a71@kernel.org> <20718115-7606-a77b-7e4d-511ca9c1d798@ti.com> <468f85ad-e4b0-54e1-a5b9-4692ae8a1445@ti.com> <455440f4-7f2b-366e-53ec-700c3bb98534@kernel.org> Content-Language: en-US From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: <455440f4-7f2b-366e-53ec-700c3bb98534@kernel.org> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_220254_478794_9289CACD X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/03/23 19:34, Roger Quadros wrote: > > Hi, > > On 16/03/2023 15:11, Md Danish Anwar wrote: >> >> >> On 16/03/23 17:49, Roger Quadros wrote: >>> >>> >>> On 16/03/2023 13:44, Md Danish Anwar wrote: >>>> >>>> On 16/03/23 17:06, Roger Quadros wrote: >>>>> Hi, >>>>> >>>>> On 16/03/2023 13:05, Md Danish Anwar wrote: >>>>>> Hi Roger, >>>>>> >>>>>> On 15/03/23 17:52, Roger Quadros wrote: >>>>>>> >>>>>>> >>>>>>> On 13/03/2023 13:11, MD Danish Anwar wrote: >>>>>>>> From: Suman Anna > [..] >> Sure, then I will use the existing enum pru_type. >> >> The enum pru_type is currently in drivers/remoteproc/pruss.c I will move this >> enum definition from there to include/linux/remoteproc/pruss.h > > There are 2 public pruss.h files. > include/linux/remoteproc/pruss.h > and > include/linux/pruss_driver.h > > Why is that and when to use what? > The include/linux/remoteproc/pruss.h file was introduced in series [1] as a public header file for PRU_RPROC driver (drivers/remoteproc/pru_rproc.c) The second header file include/linux/pruss_driver.h was introduced much earlier as part of [2] , "soc: ti: pruss: Add a platform driver for PRUSS in TI SoCs". As far as I can see, seems like pruss_driver.h was added as a public header file for PRUSS platform driver (drivers/soc/ti/pruss.c) [1] https://lore.kernel.org/all/20230106121046.886863-1-danishanwar@ti.com/ [2] https://lore.kernel.org/all/1542886753-17625-7-git-send-email-rogerq@ti.com/ > cheers, > -roger -- Thanks and Regards, Danish. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel