* [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set
[not found] <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482307697.git.baolin.wang@linaro.org>
@ 2016-12-21 8:12 ` Baolin Wang
2017-01-03 5:54 ` Baolin Wang
2017-01-16 9:06 ` Kishon Vijay Abraham I
0 siblings, 2 replies; 6+ messages in thread
From: Baolin Wang @ 2016-12-21 8:12 UTC (permalink / raw)
To: linux-arm-kernel
According to the documentation, we should set the EXTCON_USB when
one SDP charger connector was reported.
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
---
Changes since v1:
- Change extcon_set_cable_state_() to extcon_set_state_sync().
- Add reviewed tag by Chanwoo Choi.
---
drivers/phy/phy-rockchip-inno-usb2.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c
index 2f99ec9..4ea95c2 100644
--- a/drivers/phy/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/phy-rockchip-inno-usb2.c
@@ -595,9 +595,14 @@ static void rockchip_usb2phy_otg_sm_work(struct work_struct *work)
if (rport->vbus_attached != vbus_attach) {
rport->vbus_attached = vbus_attach;
- if (notify_charger && rphy->edev)
+ if (notify_charger && rphy->edev) {
extcon_set_cable_state_(rphy->edev,
cable, vbus_attach);
+ if (cable == EXTCON_CHG_USB_SDP)
+ extcon_set_state_sync(rphy->edev,
+ EXTCON_USB,
+ vbus_attach);
+ }
}
break;
case OTG_STATE_B_PERIPHERAL:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set
2016-12-21 8:12 ` [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Baolin Wang
@ 2017-01-03 5:54 ` Baolin Wang
2017-01-12 6:43 ` Baolin Wang
2017-01-16 9:06 ` Kishon Vijay Abraham I
1 sibling, 1 reply; 6+ messages in thread
From: Baolin Wang @ 2017-01-03 5:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kison and Heiko,
On 21 December 2016 at 16:12, Baolin Wang <baolin.wang@linaro.org> wrote:
> According to the documentation, we should set the EXTCON_USB when
> one SDP charger connector was reported.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Could you apply this patch if there are no other comments? Thanks.
--
Baolin.wang
Best Regards
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set
2017-01-03 5:54 ` Baolin Wang
@ 2017-01-12 6:43 ` Baolin Wang
2017-01-12 8:18 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 6+ messages in thread
From: Baolin Wang @ 2017-01-12 6:43 UTC (permalink / raw)
To: linux-arm-kernel
On 3 January 2017 at 13:54, Baolin Wang <baolin.wang@linaro.org> wrote:
> Hi Kison and Heiko,
>
> On 21 December 2016 at 16:12, Baolin Wang <baolin.wang@linaro.org> wrote:
>> According to the documentation, we should set the EXTCON_USB when
>> one SDP charger connector was reported.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> Could you apply this patch if there are no other comments? Thanks.
Ping?
--
Baolin.wang
Best Regards
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set
2017-01-12 6:43 ` Baolin Wang
@ 2017-01-12 8:18 ` Kishon Vijay Abraham I
2017-01-12 8:37 ` Baolin Wang
0 siblings, 1 reply; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2017-01-12 8:18 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Thursday 12 January 2017 12:13 PM, Baolin Wang wrote:
> On 3 January 2017 at 13:54, Baolin Wang <baolin.wang@linaro.org> wrote:
>> Hi Kison and Heiko,
>>
>> On 21 December 2016 at 16:12, Baolin Wang <baolin.wang@linaro.org> wrote:
>>> According to the documentation, we should set the EXTCON_USB when
>>> one SDP charger connector was reported.
>>>
>>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>>
>> Could you apply this patch if there are no other comments? Thanks.
Does it fix something? Or else it can go in the next merge window.
Thanks
Kishon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set
2017-01-12 8:18 ` Kishon Vijay Abraham I
@ 2017-01-12 8:37 ` Baolin Wang
0 siblings, 0 replies; 6+ messages in thread
From: Baolin Wang @ 2017-01-12 8:37 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 12 January 2017 at 16:18, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> Hi,
>
> On Thursday 12 January 2017 12:13 PM, Baolin Wang wrote:
>> On 3 January 2017 at 13:54, Baolin Wang <baolin.wang@linaro.org> wrote:
>>> Hi Kison and Heiko,
>>>
>>> On 21 December 2016 at 16:12, Baolin Wang <baolin.wang@linaro.org> wrote:
>>>> According to the documentation, we should set the EXTCON_USB when
>>>> one SDP charger connector was reported.
>>>>
>>>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>>>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>
>>> Could you apply this patch if there are no other comments? Thanks.
>
> Does it fix something? Or else it can go in the next merge window.
Just fix the correct usage of EXTCON_CHG_USB_SDP connector. It's okay
for me that it can go in the next merge window. Thanks.
--
Baolin.wang
Best Regards
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set
2016-12-21 8:12 ` [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Baolin Wang
2017-01-03 5:54 ` Baolin Wang
@ 2017-01-16 9:06 ` Kishon Vijay Abraham I
1 sibling, 0 replies; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2017-01-16 9:06 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 21 December 2016 01:42 PM, Baolin Wang wrote:
> According to the documentation, we should set the EXTCON_USB when
> one SDP charger connector was reported.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
merged, thanks!
-Kishon
> ---
> Changes since v1:
> - Change extcon_set_cable_state_() to extcon_set_state_sync().
> - Add reviewed tag by Chanwoo Choi.
> ---
> drivers/phy/phy-rockchip-inno-usb2.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c
> index 2f99ec9..4ea95c2 100644
> --- a/drivers/phy/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/phy-rockchip-inno-usb2.c
> @@ -595,9 +595,14 @@ static void rockchip_usb2phy_otg_sm_work(struct work_struct *work)
> if (rport->vbus_attached != vbus_attach) {
> rport->vbus_attached = vbus_attach;
>
> - if (notify_charger && rphy->edev)
> + if (notify_charger && rphy->edev) {
> extcon_set_cable_state_(rphy->edev,
> cable, vbus_attach);
> + if (cable == EXTCON_CHG_USB_SDP)
> + extcon_set_state_sync(rphy->edev,
> + EXTCON_USB,
> + vbus_attach);
> + }
> }
> break;
> case OTG_STATE_B_PERIPHERAL:
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-16 9:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482307697.git.baolin.wang@linaro.org>
2016-12-21 8:12 ` [PATCH v2 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set Baolin Wang
2017-01-03 5:54 ` Baolin Wang
2017-01-12 6:43 ` Baolin Wang
2017-01-12 8:18 ` Kishon Vijay Abraham I
2017-01-12 8:37 ` Baolin Wang
2017-01-16 9:06 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).