From: Thomas Zimmermann <tzimmermann@suse.de>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
airlied@linux.ie, khilman@baylibre.com,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH] drm/meson: Convert to Linux IRQ interfaces
Date: Thu, 8 Jul 2021 15:48:19 +0200 [thread overview]
Message-ID: <248d2ec3-eb13-7e6b-8f8d-567988e4067f@suse.de> (raw)
In-Reply-To: <CAFBinCAio=-Lj=xQJ-EBXnhw1ygyyRv6M0cDZcod5NZO3YqcTQ@mail.gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1535 bytes --]
Hi
Am 08.07.21 um 15:31 schrieb Martin Blumenstingl:
> Hi Thomas,
>
> On Tue, Jul 6, 2021 at 9:45 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>>
>> Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's
>> IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers
>> don't benefit from using it.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> and also (although I am no drm subsystem expert):
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
Oh, just when I committed the patch. But thanks for your reply.
> [...]
>> - ret = drm_irq_install(drm, priv->vsync_irq);
>> + ret = request_irq(priv->vsync_irq, meson_irq, 0, drm->driver->name, drm);
> I'd like to use dev_name(dev) instead of drm->driver->name in the
> future as that'll make it much easier to identify the corresponding
> IRQ in /proc/interrupts for example
> your patch makes this possible - thanks for this!
I also thought about this, but every driver in DRM and apparently most
drivers in general pass the driver's name here. I think the change would
make a lot of sense, but it's probably worth a kernel-wide effort.
Best regards
Thomas
>
>
> Best regards,
> Martin
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-07-08 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 7:45 [PATCH] drm/meson: Convert to Linux IRQ interfaces Thomas Zimmermann
2021-07-07 6:13 ` Neil Armstrong
2021-07-08 13:31 ` Martin Blumenstingl
2021-07-08 13:48 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248d2ec3-eb13-7e6b-8f8d-567988e4067f@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).