From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yong Liang <yong.liang@mediatek.com>,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, drinkcat@chromium.org,
weiyi.lu@mediatek.com, jamesjj.liao@mediatek.com,
jasu@njomotys.info, owen.chen@mediatek.com,
chunhui.dai@mediatek.com, erin.lo@mediatek.com,
eddie.huang@mediatek.com
Cc: linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] Include mt8183-reset.h and add reset-cells in infracfg in dtsi file.
Date: Thu, 22 Aug 2019 16:33:25 +0200 [thread overview]
Message-ID: <24e4a0a9-065e-410d-7c3f-403ec859ae07@gmail.com> (raw)
In-Reply-To: <20190725080957.17333-1-yong.liang@mediatek.com>
On 25/07/2019 10:09, Yong Liang wrote:
> From: "yong.liang" <yong.liang@mediatek.com>
>
Missing commit message.
Subject could be shorter, something like:
arm64: dts: add reset-cells for infracfg
> Change-Id: I46e0aca76a206ac86ee0477d9dbd67e1e924b118
Please delete Change-Id it's not meaning full for upstream work.
> Signed-off-by: yong.liang <yong.liang@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 08274bfcebd8..2589e9461c6e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -8,6 +8,7 @@
> #include <dt-bindings/clock/mt8183-clk.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/reset-controller/mt8183-resets.h>
>
> / {
> compatible = "mediatek,mt8183";
> @@ -194,6 +195,7 @@
> compatible = "mediatek,mt8183-infracfg", "syscon";
> reg = <0 0x10001000 0 0x1000>;
> #clock-cells = <1>;
> + #reset-cells = <1>;
> };
>
> apmixedsys: syscon@1000c000 {
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-22 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 8:09 [PATCH 1/2] Include mt8183-reset.h and add reset-cells in infracfg in dtsi file Yong Liang
2019-08-22 14:33 ` Matthias Brugger [this message]
2019-08-22 14:34 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24e4a0a9-065e-410d-7c3f-403ec859ae07@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=chunhui.dai@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=eddie.huang@mediatek.com \
--cc=erin.lo@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=jasu@njomotys.info \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=owen.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=weiyi.lu@mediatek.com \
--cc=yong.liang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).