From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F255EC432C2 for ; Thu, 26 Sep 2019 11:02:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C288021A4A for ; Thu, 26 Sep 2019 11:02:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sat9DUrb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C288021A4A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nx7ecYxO0TIzxiuvyfrTCRMrhTeMwVRXlJxwXNdiqog=; b=sat9DUrbV7CWQr tcZTOtt1htipUXI8yzn072q0FTADYxmkIUcK/jqbiykQnulGl6amF+04j5F2zd4RIZagDhp6ImvTO uZpBGcsay6yJ0IIPvnIWcoOYFyZxKRl4yzPHSXItLyJn5fu7wA8BljmEfQahwvwAejyfPJejGFHun DtAzhhu8TZOB20t9MycBi1EuX7WJGo5J0IG3GaBo6bunoRriWzo+sP4wRgp4kItb+SfhCOem/nCJO K6By87AhFA8ZkRBBxYJaDtD1vOT5j4E3bF4jFkS+d7wuGsndqh2aY4Q+L84h5N32mBLDnXJqx8LGn zhhBMmgoCVLrRO4M9+mA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDRX6-0007fq-Ni; Thu, 26 Sep 2019 11:02:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDRX3-0007fT-Qc for linux-arm-kernel@lists.infradead.org; Thu, 26 Sep 2019 11:01:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D7861000; Thu, 26 Sep 2019 04:01:57 -0700 (PDT) Received: from [192.168.1.158] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B1F1F3F67D; Thu, 26 Sep 2019 04:01:55 -0700 (PDT) Subject: Re: [PATCH 3/4] arm64: vdso32: Fix compilation warning To: Catalin Marinas References: <20190920142738.qlsjwguc6bpnez63@willie-the-truck> <20190926060353.54894-1-vincenzo.frascino@arm.com> <20190926060353.54894-4-vincenzo.frascino@arm.com> <20190926083217.GD26802@iMac.local> From: Vincenzo Frascino Message-ID: <25676f5c-0c95-82b4-8d09-a313f812bb01@arm.com> Date: Thu, 26 Sep 2019 12:03:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190926083217.GD26802@iMac.local> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190926_040157_910926_E998C090 X-CRM114-Status: GOOD ( 13.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ard.biesheuvel@linaro.org, ndesaulniers@google.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/26/19 9:32 AM, Catalin Marinas wrote: > On Thu, Sep 26, 2019 at 07:03:52AM +0100, Vincenzo Frascino wrote: >> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h >> index b61b50bf68b1..b1c8c43234c5 100644 >> --- a/arch/arm64/include/asm/memory.h >> +++ b/arch/arm64/include/asm/memory.h >> @@ -228,11 +228,16 @@ static inline unsigned long kaslr_offset(void) >> #define __tag_get(addr) 0 >> #endif /* CONFIG_KASAN_SW_TAGS */ >> >> +#ifdef __aarch64__ >> static inline const void *__tag_set(const void *addr, u8 tag) >> { >> u64 __addr = (u64)addr & ~__tag_shifted(0xff); >> return (const void *)(__addr | __tag_shifted(tag)); >> } >> +#else >> +/* Unused in 32 bit mode */ >> +#define __tag_set(addr, tag) 0 >> +#endif > > I'm fine with this as a temporary workaround (or hack). But please add a > better comment on what the 32-bit mode is about - the compat vDSO. > Ok, I will do in v2, to avoid confusion. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel