From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nishanth Menon <nm@ti.com>
Cc: Apurva Nandan <a-nandan@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hari Nagalla <hnagalla@ti.com>
Subject: Re: [PATCH 3/4] arm64: dts: ti: Add initial support for J784s4 SoC
Date: Wed, 24 Aug 2022 15:47:30 +0300 [thread overview]
Message-ID: <25820bbe-c232-fb5c-0654-fc917ed8ad92@linaro.org> (raw)
In-Reply-To: <20220824050233.u4457ldxiqtiia4p@nineteen>
On 24/08/2022 08:02, Nishanth Menon wrote:
> On 13:18-20220823, Krzysztof Kozlowski wrote:
>>> + main_gpio_intr: interrupt-controller@a00000 {
>>> + compatible = "ti,sci-intr";
>>> + reg = <0x00 0x00a00000 0x00 0x800>;
>>
>> 0x0, not 0x00. Here and all other places.
>
>
> Krzysztof is this a convention we have started following strongly?
>
> The reason I ask is to be able to cleanup elsewhere in the dts as well..
>
>
> So far, I have insisted on 0x00 usage.
Not really, just stick to one. Your other nodes have 0x0, so just choose
one. Anyway additional zeros seem redundant, but it is up to you which
convention you prefer. Just choose one, not mixed.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-24 12:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 19:00 [PATCH 0/4] Add initial support for J784s4 SoC Apurva Nandan
2022-08-19 19:00 ` [PATCH 1/4] dt-bindings: arm: ti: Add bindings " Apurva Nandan
2022-08-22 19:13 ` Rob Herring
2022-08-19 19:00 ` [PATCH 2/4] dt-bindings: pinctrl: k3: Introduce pinmux definitions for J784s4 Apurva Nandan
2022-08-22 19:13 ` Rob Herring
2022-08-26 8:29 ` Linus Walleij
2022-08-26 11:22 ` Vignesh Raghavendra
2022-08-19 19:00 ` [PATCH 3/4] arm64: dts: ti: Add initial support for J784s4 SoC Apurva Nandan
2022-08-23 10:18 ` Krzysztof Kozlowski
2022-08-24 5:02 ` Nishanth Menon
2022-08-24 12:47 ` Krzysztof Kozlowski [this message]
2022-08-19 19:00 ` [PATCH 4/4] arch: arm64: ti: Add support for J784s4 EVM board Apurva Nandan
2022-08-23 10:21 ` Krzysztof Kozlowski
2022-08-24 5:06 ` Nishanth Menon
2022-08-24 5:33 ` Vignesh Raghavendra
2022-08-24 7:12 ` Krzysztof Kozlowski
2022-08-24 9:15 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25820bbe-c232-fb5c-0654-fc917ed8ad92@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a-nandan@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).