From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48BA4C282C2 for ; Wed, 13 Feb 2019 14:27:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16ABD2190A for ; Wed, 13 Feb 2019 14:27:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MHaiH07D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16ABD2190A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4YKAdMh7xlL8KYODHJLDWTcuTKf/9BAGQIr8rKU1YCw=; b=MHaiH07DmBWVyo 1gG81725AAaFbj9AFH9L0jR6Lu0oJmG6wWT0x2fQ8IEpZlVbQ7MWPsHFK03tQReAFdsG3nGWiJKi5 PkL9s0Siinh3hsJvhV9iC1WUoiIz7clU0ChPDqXmWgoGex64M6x+S6QqPLMp8mydXHhXNjJlDwbgH ZBiuZQtzde4onsvxUNDtsu1fE/YVhM8fmLwo8HW57LluGQ4kaZ/3vaSBiA4yK/yI990b9vDCKGdkH 04SxVHUHW3GMs0aZ3Lqf0LyS0vhRlU6yGes8rNp6y3SpmKDLXLHgDjBw4COQUdR5w8goT7n1xLnCj 2F6DVN33ATeXDI/eaE5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtvVF-00032R-3B; Wed, 13 Feb 2019 14:27:09 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtvVA-00031v-Lt for linux-arm-kernel@lists.infradead.org; Wed, 13 Feb 2019 14:27:07 +0000 Received: from aptenodytes (aaubervilliers-681-1-89-68.w90-88.abo.wanadoo.fr [90.88.30.68]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 082BD240014; Wed, 13 Feb 2019 14:26:50 +0000 (UTC) Message-ID: <25f4beadd3088b3fbb2751f120e4216969301136.camel@bootlin.com> Subject: Re: [PATCH v3 8/8] drm/panel: Add Ronbo RB070D30 panel From: Paul Kocialkowski To: Maxime Ripard , Maarten Lankhorst , Sean Paul Date: Wed, 13 Feb 2019 15:26:45 +0100 In-Reply-To: <2663d767bffbc83f84f9086e614b0ec1dd343ced.1549896081.git-series.maxime.ripard@bootlin.com> References: <2663d767bffbc83f84f9086e614b0ec1dd343ced.1549896081.git-series.maxime.ripard@bootlin.com> Organization: Bootlin User-Agent: Evolution 3.30.5 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190213_062705_021361_77CCEE9C X-CRM114-Status: GOOD ( 21.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Konstantin Sudakov , bbrezillon@kernel.org, Sam Ravnborg , dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Thomas Petazzoni , Jagan Teki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Archived-At: List-Archive: Hi, On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote: > From: Konstantin Sudakov > > The Ronbo RB070D30 panel is a MIPI-DSI panel based on a Fitipower EK79007 > controller and a 1024x600 panel. > > Reviewed-by: Sam Ravnborg > Signed-off-by: Konstantin Sudakov > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/panel/Kconfig | 9 +- > drivers/gpu/drm/panel/Makefile | 1 +- > drivers/gpu/drm/panel/panel-ronbo-rb070d30.c | 262 ++++++++++++++++++++- Looks like no bindings documentation is introduced for this panel. Shouldn't that be the case? The vendor also seems to be missing from vendor-prefixes.txt. For the driver itself: Reviewed-by: Paul Kocialkowski Cheers, Paul > 3 files changed, 272 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-ronbo-rb070d30.c > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 3f3537719beb..870dcdbf2601 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -138,6 +138,15 @@ config DRM_PANEL_RAYDIUM_RM68200 > Say Y here if you want to enable support for Raydium RM68200 > 720x1280 DSI video mode panel. > > +config DRM_PANEL_RONBO_RB070D30 > + tristate "Ronbo Electronics RB070D30 panel" > + depends on OF > + depends on DRM_MIPI_DSI > + depends on BACKLIGHT_CLASS_DEVICE > + help > + Say Y here if you want to enable support for Ronbo Electronics > + RB070D30 1024x600 DSI panel. > + > config DRM_PANEL_SAMSUNG_S6D16D0 > tristate "Samsung S6D16D0 DSI video mode panel" > depends on OF > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index 4396658a7996..4a103d346809 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -12,6 +12,7 @@ obj-$(CONFIG_DRM_PANEL_ORISETECH_OTM8009A) += panel-orisetech-otm8009a.o > obj-$(CONFIG_DRM_PANEL_PANASONIC_VVX10F034N00) += panel-panasonic-vvx10f034n00.o > obj-$(CONFIG_DRM_PANEL_RASPBERRYPI_TOUCHSCREEN) += panel-raspberrypi-touchscreen.o > obj-$(CONFIG_DRM_PANEL_RAYDIUM_RM68200) += panel-raydium-rm68200.o > +obj-$(CONFIG_DRM_PANEL_RONBO_RB070D30) += panel-ronbo-rb070d30.o > obj-$(CONFIG_DRM_PANEL_SAMSUNG_LD9040) += panel-samsung-ld9040.o > obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6D16D0) += panel-samsung-s6d16d0.o > obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E3HA2) += panel-samsung-s6e3ha2.o > diff --git a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c > new file mode 100644 > index 000000000000..cb4f99252aa0 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c > @@ -0,0 +1,262 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2018-2019, Bridge Systems BV > + * Copyright (C) 2018-2019, Bootlin > + * Copyright (C) 2017, Free Electrons > + * > + * This file based on panel-ilitek-ili9881c.c > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#include > +#include > +#include > +#include > + > +#include