From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69D5DC6FA8B for ; Thu, 22 Sep 2022 07:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6D+rEaey7QxKIKcvWDi0EMjU9lBu7Xe/m/DD3Uby0ac=; b=D8TPauHwbUjUwT q28hklAxDbqHAz3Hm6PDcC4YKmqMZ5kYW629+DVifXp6lwBJnHJuWN1mcVELHFpYnAZTnSyH1OKJj hrTpf2raZSUxPhKOzJTgGluhMnXympqyH5/lc+C+Bj3KHBOzrpF5Mt4aZzMtV1WHhHyXPxPIShvAh rsgbTbuReOpG9fOcA8YmrctanRYRg1LqMSua63dbVFv79bfAo3AMnKNg6ibd+9DxwbJVcfpIOguXs eHZKowjesSZyMscXqP4oKRt0F8wERzXovsZcyl0iJpv9LNC/+9czYCJWjYvW9RH92DHpuJbr3KKdi SdTkzX/deGBA1YLvZc+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obGU5-00Dlru-Hg; Thu, 22 Sep 2022 07:18:57 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obGU0-00DloW-5X for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 07:18:55 +0000 Received: by mail-lf1-x135.google.com with SMTP id a2so13183401lfb.6 for ; Thu, 22 Sep 2022 00:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=ln6ZeHzfzIh7ZyAvFY4CPd7Whze3jXvv2P2xFSPlMGQ=; b=ErecUnfehksu48GfFXY1dB5cjHTxnXqpVDD2eczsRIHNXp0+fJGKID0aaV7oXQ+xM1 7UzGFYZkEODN1QvfiSBIgr2dlG1gSVGBXkfNyZhTWIky0TloopA9PS41gknISZvJWgdo QOK/0CIOeWjFvLaLoww1LRicmQ3cwIddX6Gocz2h7pRmKyxD+qR0Q5uvuys1dFSs+hJk XfdKZr+7mkvgKE75usGv6nSPF1edW0PsXbToJ70O5MZXvT51FnFdZcXi9LzwtjvjJlgY C8aNoEY+6FTSxr0nEmsUcvgeMg0XhqVHnZF0/zZ3ESBQqElajl9A8qvfwjQvbTWOnYbF Hqwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ln6ZeHzfzIh7ZyAvFY4CPd7Whze3jXvv2P2xFSPlMGQ=; b=zVg8YgxRYI3e6hMQo61JL/AEKOSTKkyIVCaeob1A5HPUBtiNeSv7qFGe+RxrAXJNA0 PKlW88j3LvwmyI4z8B0cXpkGjL94xmriIjJOLBJpw4bczaMK3KFByFN+PUit/hS6eHr7 hKp8lIHTuq6MqeUzV0We6n2+zpjJgLNMnUhChv/VYibTM0k7OhwBxc2p7Vy3GUVPrRrK nks6/txnO8H8PvuBQFcCvRtihIf3waVgnS5ISGlu1myU4DQBcMHmPNLxTEmAmdcTks/q yAfNhFJF4eVWAC+6g+Iujs/6S9uhosKysFI/4betuuFRrFfm7LojHh8D49+52/6xcRS9 StFQ== X-Gm-Message-State: ACrzQf2HuDN1mUY6nBJKWGDS2MNsOZ7ZOI4DKJDDaIKr2dFbMysukUE5 9DGE993giXgMawgRhLS3RXyZ4g== X-Google-Smtp-Source: AMsMyM47YFDCy8AwIT5M8sGMUa+EUaCIIo1zk4WZ+rlWlbFfVtDdWjoBH6LrVg/wiXrtgWAh0UwMAA== X-Received: by 2002:a05:6512:11e9:b0:49f:d530:9f25 with SMTP id p9-20020a05651211e900b0049fd5309f25mr749322lfs.533.1663831130309; Thu, 22 Sep 2022 00:18:50 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a7-20020a19f807000000b0048b256bb005sm804039lff.49.2022.09.22.00.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 00:18:49 -0700 (PDT) Message-ID: <260bb17f-efc8-1287-3e03-f9b8e79a6e31@linaro.org> Date: Thu, 22 Sep 2022 09:18:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 04/17] dt-bindings: display: mediatek: add MT8195 hdmi bindings Content-Language: en-US To: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-4-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220919-v1-4-4844816c9808@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_001852_308021_42F40B72 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add mt8195 SoC bindings for hdmi and hdmi-ddc > > Make port1 optional for mt8195 as it only supports HDMI tx for now. > Requires a ddc-i2c-bus phandle. > Requires a power-domains phandle. > > Signed-off-by: Guillaume Ranquet > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > index bdaf0b51e68c..abb231a0694b 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > @@ -21,6 +21,10 @@ properties: > - mediatek,mt7623-hdmi > - mediatek,mt8167-hdmi > - mediatek,mt8173-hdmi > + - mediatek,mt8195-hdmi > + > + clocks: true > + clock-names: true ???? Why is this moved? > > reg: > maxItems: 1 > @@ -28,20 +32,6 @@ properties: > interrupts: > maxItems: 1 > > - clocks: > - items: > - - description: Pixel Clock > - - description: HDMI PLL > - - description: Bit Clock > - - description: S/PDIF Clock > - > - clock-names: > - items: > - - const: pixel > - - const: pll > - - const: bclk > - - const: spdif Clock definition with constraints should stay here. You just customize it per variant. > - > phys: > maxItems: 1 > > @@ -58,6 +48,16 @@ properties: > description: | > phandle link and register offset to the system configuration registers. > > + ddc-i2c-bus: > + $ref: '/schemas/types.yaml#/definitions/phandle' Drop quotes > + description: Phandle to the ddc-i2c device Isn't this property of panel? > + > + power-domains: > + description: > + A phandle and PM domain specifier as defined by bindings > + of the power controller specified by phandle. See > + Documentation/devicetree/bindings/power/power-domain.yaml for details. No need for this text. This is standard property. You miss maxItems. > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > > @@ -76,7 +76,6 @@ properties: > > required: > - port@0 > - - port@1 > > required: > - compatible > @@ -86,9 +85,55 @@ required: > - clock-names > - phys > - phy-names > - - mediatek,syscon-hdmi > - ports > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt8195-hdmi > + then: > + properties: > + clocks: > + items: > + - description: APB > + - description: HDCP > + - description: HDCP 24M > + - description: Split HDMI > + clock-names: > + items: > + - const: hdmi_apb_sel > + - const: hdcp_sel > + - const: hdcp24_sel > + - const: split_hdmi Clocks are entirely different. I am not sure there is benefit in keeping these devices in one bindings. > + > + required: > + - power-domains > + - ddc-i2c-bus Blank line, > + else: > + properties: > + clocks: > + items: > + - description: Pixel Clock > + - description: HDMI PLL > + - description: Bit Clock > + - description: S/PDIF Clock > + > + clock-names: > + items: > + - const: pixel > + - const: pll > + - const: bclk > + - const: spdif > + > + ports: > + required: > + - port@1 > + > + required: > + - mediatek,syscon-hdmi > + > additionalProperties: false > > examples: > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml > new file mode 100644 > index 000000000000..3c80bcebe6d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek HDMI DDC Device Tree Bindings for mt8195 Drop Device Tree Bindings > + > +maintainers: > + - CK Hu > + - Jitao shi > + > +description: | > + The HDMI DDC i2c controller is used to interface with the HDMI DDC pins. Why is this different than existing ddc bindings? > + > +properties: > + compatible: > + enum: > + - mediatek,mt8195-hdmi-ddc > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: ddc-i2c > + > +required: > + - compatible > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + hdmiddc0: ddc_i2c { No underscores in node names. Generic node names. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel