From: Suzuki K Poulose <suzuki.poulose@arm.com> To: saiprakash.ranjan@codeaurora.org, gregkh@linuxfoundation.org, mathieu.poirier@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, robh+dt@kernel.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, david.brown@linaro.org, mark.rutland@arm.com Cc: rnayak@codeaurora.org, marc.w.gonzalez@free.fr, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, sibis@codeaurora.org, vivek.gautam@codeaurora.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv8 2/5] arm64: dts: qcom: msm8998: Add Coresight support Date: Thu, 18 Jul 2019 10:37:19 +0100 Message-ID: <281e3548-af53-f9a7-b9e4-813b448ab078@arm.com> (raw) In-Reply-To: <4854b0f7-6a81-bc87-3e63-d2b7c68a44f6@codeaurora.org> On 18/07/2019 10:14, Sai Prakash Ranjan wrote: > Hi Suzuki, > > On 7/18/2019 1:58 PM, Suzuki K Poulose wrote: >> Hi Sai, >> >> >> etr@6048000 { >>> + compatible = "arm,coresight-tmc", "arm,primecell"; >>> + reg = <0x06048000 0x1000>; >>> + >>> + clocks = <&rpmcc RPM_SMD_QDSS_CLK>, <&rpmcc >>> RPM_SMD_QDSS_A_CLK>; >>> + clock-names = "apb_pclk", "atclk"; >>> + arm,scatter-gather; >> >> Please could you confirm that you have tested the scatter-gather mode >> with ETR ? Either via perf/sysfs. Please could you share your results ? >> Unless verified >> this is going to be fatal for the system. >> >> Similarly for other platforms. >> > > Yes I have tested with scatter-gather mode with ETR on all platforms > which I have posted via sysfs(not perf) before on previous versions of > this patch series and no issues were found. And I suppose this was > discussed in v2 of this patch series [1]. Using the sysfs doesn't guarantee that the ETR actually uses SG mode, unless the buffer size selected is > 1M, which is why I am more interested in the perf usage. Alternatively you may configure a larger buffer size (say, 8MB) via: echo 0x800000 > /sys/bus/coresight/.../tmc_etr0/buffer_size > > As said in one of the series initially [1], QCOM msm downstream kernels > have been using scatter gather mode and we haven't seen any fatal issues. > > [1] https://patchwork.kernel.org/patch/10769535/ I haven't seen any test results there either. Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply index Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-12 14:16 [PATCHv8 0/5] Add coresight support for SDM845, MSM8998 and MSM8996 Sai Prakash Ranjan 2019-07-12 14:16 ` [PATCHv8 1/5] arm64: dts: qcom: sdm845: Add Coresight support Sai Prakash Ranjan 2019-07-12 16:44 ` Suzuki K Poulose 2019-07-12 16:49 ` saiprakash.ranjan 2019-07-19 9:46 ` Suzuki K Poulose 2019-07-19 10:28 ` Sai Prakash Ranjan 2019-07-12 14:16 ` [PATCHv8 2/5] arm64: dts: qcom: msm8998: " Sai Prakash Ranjan 2019-07-18 8:28 ` Suzuki K Poulose 2019-07-18 9:14 ` Sai Prakash Ranjan 2019-07-18 9:37 ` Suzuki K Poulose [this message] 2019-07-18 9:53 ` Sai Prakash Ranjan 2019-07-12 14:16 ` [PATCHv8 3/5] arm64: dts: qcom: msm8996: " Sai Prakash Ranjan 2019-07-17 17:00 ` Mathieu Poirier 2019-07-18 5:47 ` Sai Prakash Ranjan 2019-07-18 15:31 ` Mathieu Poirier 2019-07-18 15:48 ` Bjorn Andersson 2019-07-12 14:16 ` [PATCHv8 4/5] coresight: etm4x: Add ETM PIDs for SDM845 and MSM8996 Sai Prakash Ranjan 2019-07-17 17:40 ` Mathieu Poirier 2019-07-12 14:16 ` [PATCHv8 5/5] coresight: cpu-debug: Add support for Qualcomm Kryo Sai Prakash Ranjan 2019-07-17 16:56 ` Mathieu Poirier 2019-07-21 14:35 ` Leo Yan 2019-07-22 5:48 ` Sai Prakash Ranjan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=281e3548-af53-f9a7-b9e4-813b448ab078@arm.com \ --to=suzuki.poulose@arm.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=bjorn.andersson@linaro.org \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.w.gonzalez@free.fr \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=rnayak@codeaurora.org \ --cc=robh+dt@kernel.org \ --cc=saiprakash.ranjan@codeaurora.org \ --cc=sibis@codeaurora.org \ --cc=vivek.gautam@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git