From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Tobias Schramm <t.schramm@manjaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Tobias Schramm <t.schramm@manjaro.org>
Subject: Re: [PATCH 4/4] ARM: dts: sun8i: V3: add I2S interface to V3 dts
Date: Thu, 13 May 2021 21:25:04 +0200 [thread overview]
Message-ID: <2916483.liAivg88ip@kista> (raw)
In-Reply-To: <20210513190949.2069235-5-t.schramm@manjaro.org>
Dne četrtek, 13. maj 2021 ob 21:09:49 CEST je Tobias Schramm napisal(a):
> The Allwinner V3 SoC features an I2S interface. The I2C peripheral is
I2C -> I2S
> identical to that in the Allwinner H3 SoC.
> This commit adds it to the Allwinner V3 dts.
>
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
> ---
> arch/arm/boot/dts/sun8i-v3.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-v3.dtsi b/arch/arm/boot/dts/sun8i-
v3.dtsi
> index c279e13583ba..0061c49523f2 100644
> --- a/arch/arm/boot/dts/sun8i-v3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3.dtsi
> @@ -1,10 +1,30 @@
> // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> /*
> * Copyright (C) 2019 Icenowy Zheng <icenowy@aosc.io>
> + * Copyright (C) 2021 Tobias Schramm <t.schramm@manjaro.org>
It's uncommon to add additional copyrights just for one node, but ok.
> */
>
> #include "sun8i-v3s.dtsi"
>
> +/ {
> + soc {
> + i2s0: i2s@1c22000 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun8i-h3-
i2s";
You have to add v3s compatible as a fallback (and document it in devicetree
documentation).
Best regards,
Jernej
> + reg = <0x01c22000 0x400>;
> + interrupts = <GIC_SPI 13
IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_I2S0>,
<&ccu CLK_I2S0>;
> + clock-names = "apb", "mod";
> + dmas = <&dma 3>, <&dma 3>;
> + dma-names = "rx", "tx";
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2s0_pins>;
> + resets = <&ccu RST_BUS_I2S0>;
> + status = "disabled";
> + };
> + };
> +};
> +
> &ccu {
> compatible = "allwinner,sun8i-v3-ccu";
> };
> @@ -25,6 +45,11 @@ external_mdio: mdio@2 {
> &pio {
> compatible = "allwinner,sun8i-v3-pinctrl";
>
> + i2s0_pins: i2s0-pins {
> + pins = "PG10", "PG11", "PG12", "PG13";
> + function = "i2s";
> + };
> +
> uart1_pg_pins: uart1-pg-pins {
> pins = "PG6", "PG7";
> function = "uart1";
> --
> 2.30.1
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-05-13 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 19:09 [PATCH 0/4] Add missing peripherals to Allwinner V3s/V3 device trees Tobias Schramm
2021-05-13 19:09 ` [PATCH 1/4] ARM: dts: sun8i: v3s: add DMA controller to v3s dts Tobias Schramm
2021-05-13 19:09 ` [PATCH 2/4] ARM: dts: sun8i: v3s: add DMA properties to peripherals supporting DMA Tobias Schramm
2021-05-13 19:09 ` [PATCH 3/4] ARM: dts: sun8i: v3s: add analog codec and frontend to v3s dts Tobias Schramm
2021-05-13 19:09 ` [PATCH 4/4] ARM: dts: sun8i: V3: add I2S interface to V3 dts Tobias Schramm
2021-05-13 19:25 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2916483.liAivg88ip@kista \
--to=jernej.skrabec@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=t.schramm@manjaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).