From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C3AC433B4 for ; Fri, 9 Apr 2021 09:06:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EA2C61104 for ; Fri, 9 Apr 2021 09:06:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EA2C61104 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ml0TlGjn3iD4/0mWvuzSZMCAEWLhbTFVxq87KWBFoj0=; b=UyTrKuRrqkjBBB6EphJu2pgRK qYghTFjYEtxAoq55eVZKHNjzuM0nryZqy5GSl6oAfFHF2JqYoi9eH2uUaeHh0nRCFPP0Gk0NUcGlp 2eeSYMjUONWhAQF3ee3kuibcPmJtKNWCcmy0h/Fg+kItVrG3+zvAgF/D4zwnvalmb/mP/PaHn78cl BhBGhplfDJSAY+q092lJaVX1LiZHLjdSsc8m+LSQZb76lcArgiFSBnC4H9J8p4R3SdKm1U1sBw9Jc FxT3gJLGvN3YJ6oSF15Ep0k/Go08Y0mzcZzKYUevmaNHGvOfZKQApnmPZj1KlMjUdOqUvS1WeuaMp Z97+PBtBQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUn41-000A5o-PA; Fri, 09 Apr 2021 09:04:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUn3x-000A5H-Qs for linux-arm-kernel@desiato.infradead.org; Fri, 09 Apr 2021 09:04:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=OhAkrEfB7baenM8cTlHQJpKlfy65eHW/J59LYSjD3KE=; b=re2LzWozeXkL68W4TxXOBr0Ty1 EQxcr5786yp8woY63RvbAiCowaKQRNeH4pVhDAvr0k9jtmJQVetvHHfLxAi9HMMWvaJBNg0vmL0MK 70bAuUtN+pjxXQGE0ddJG7WoNkv8ZU1XDCxD42R4kwzhqsOpwHoCyUo8cTbsiZKhp4rKDmDuLn99a K6KOLu6/5TO/SKm7+i5B2L+/tj+LoeGMZR3/4SUdCePCC44Sa+e4L9feLkcA6s6f/8vnnfhiUc1bF m1jCP6U34ga/cUuUUuEyfl1OBtJi4zNJR9QWaZwxbH5DCkKc8c0nI5kdhA3wWD/RvsCVGMDqGEpsd /MLsVR+w==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUn3v-003jPQ-2g for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 09:04:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 640C11FB; Fri, 9 Apr 2021 02:04:19 -0700 (PDT) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C26353F73D; Fri, 9 Apr 2021 02:04:16 -0700 (PDT) Subject: Re: [PATCH -next] coresight: core: Make symbol 'csdev_sink' static To: Wei Yongjun , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot References: <20210409013215.488823-1-weiyongjun1@huawei.com> From: Anshuman Khandual Message-ID: <291c6015-dbef-553b-c756-9d5acd1d9fe2@arm.com> Date: Fri, 9 Apr 2021 14:35:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210409013215.488823-1-weiyongjun1@huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_020423_203477_1D5E8FAB X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/9/21 7:02 AM, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/hwtracing/coresight/coresight-core.c:26:1: warning: > symbol '__pcpu_scope_csdev_sink' was not declared. Should it be static? > > This symbol is not used outside of coresight-core.c, so this > commit marks it static. commit ? It is not on the tree yet. s/commit/change instead. > > Fixes: 2cd87a7b293d ("coresight: core: Add support for dedicated percpu sinks") There is no functional problem that this patch is proposing to fix and hence the "Fixes:" tag is not warranted. Suzuki/Matihieu ? > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/hwtracing/coresight/coresight-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 3e779e1619ed..6c68d34d956e 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -23,7 +23,7 @@ > #include "coresight-priv.h" > > static DEFINE_MUTEX(coresight_mutex); > -DEFINE_PER_CPU(struct coresight_device *, csdev_sink); > +static DEFINE_PER_CPU(struct coresight_device *, csdev_sink); > > /** > * struct coresight_node - elements of a path, from source to sink > Otherwise LGTM. As csdev_sink is not being used outside coresight-core.c file after the introduction of coresight_[set|get]_percpu_sink() helpers. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel