From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEFC8ECAAD3 for ; Thu, 15 Sep 2022 01:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=atERirnHu5yHR1gGO/Wx8sAT6rqLNXYmVaT9DBUIau4=; b=Zzg7teFSCvH4lS A//0so9rec+lY0WscMhRh8nfc9OLnxh9MPGYdBVQ3Hp4oMVDmwNJhPABZvi9O0p2CU/4jxmPABkhO ZzkN8TwEBnxcXI67VueDBLhN5TppcQw4xYw7kWelXJKekyOp62ekFr0TgvjoHcI7IKwmBdKyO+c5l ie1r5FDxrfHMulXrXAk/Z1sFzNe7jTKLyxuCjD0QPxkUNQ8mv0LwmFV/rsPciNJ8QU0wMfLflbNlK mqMvFEBHP+U5uPfZDuWIRNq7hc8xhqqEzf6iCXpWCqQGhtYeHLdoWcWNmRSCcVDdqhC/hrDAEMbKi +OEQm3mwLo4MVQg2rORQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYdd4-00ELap-E1; Thu, 15 Sep 2022 01:25:22 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYdd1-00ELXB-QL; Thu, 15 Sep 2022 01:25:21 +0000 X-UUID: 4006756407044899bcd0a913da5e1087-20220914 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=yWiqkRoMA5szwFch3bndA/3HuivLlnD9Nl9WlTv4YVY=; b=Uuk3FPlR4i6kGpKTRIvihshdQ380JsGYWGpMHTStL/y7BeP1jpQlR1RPqfUbmPE5SqkWT0AUr7A6ujOSWwe82gCr0+se02SGn6LSESZDkSp5mnJoz3Z91rLt9ydV24UecZSo2tL0rd8o4Tnk9fHIx5PWzhmQGRZYACqQtDUruGY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:d9864385-8aa8-4ee8-b218-d56ecf095cf7,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:39a5ff1,CLOUDID:9c80af5d-5ed4-4e28-8b00-66ed9f042fbd,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 4006756407044899bcd0a913da5e1087-20220914 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 247275609; Wed, 14 Sep 2022 18:25:06 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Thu, 15 Sep 2022 09:24:31 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 15 Sep 2022 09:24:31 +0800 Message-ID: <296155e2a12a474439ba092e73b4bcffbf3d3edc.camel@mediatek.com> Subject: Re: [PATCH 1/5] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195 From: Jason-JH Lin To: Matthias Brugger , Chun-Kuang Hu , Rob Herring , "Krzysztof Kozlowski" , AngeloGioacchino Del Regno CC: CK Hu , Rex-BC Chen , "Singo Chang" , Nancy Lin , , , , , , Date: Thu, 15 Sep 2022 09:24:31 +0800 In-Reply-To: <1b739216-8bb1-162b-1af5-24acba7324bf@gmail.com> References: <20220914182331.20515-1-jason-jh.lin@mediatek.com> <20220914182331.20515-2-jason-jh.lin@mediatek.com> <1b739216-8bb1-162b-1af5-24acba7324bf@gmail.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_182519_874719_A7E93987 X-CRM114-Status: GOOD ( 28.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Matthias, Thanks for the reviews. On Wed, 2022-09-14 at 23:24 +0200, Matthias Brugger wrote: > > On 14/09/2022 20:23, Jason-JH.Lin wrote: > > For previous MediaTek SoCs, such as MT8173, there are 2 display HW > > pipelines binding to 1 mmsys with the same power domain, the same > > clock driver and the same mediatek-drm driver. > > > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding > > to > > 2 different power domains, different clock drivers and different > > mediatek-drm drivers. > > > > Moreover, Hardware pipeline of VDOSYS0 has these components: COLOR, > > CCORR, AAL, GAMMA, DITHER. They are related to the PQ (Picture > > Quality) > > and they makes VDOSYS0 supports PQ function while they are not > > including in VDOSYS1. > > > > Hardware pipeline of VDOSYS1 has the component ETHDR (HDR related > > component). It makes VDOSYS1 supports the HDR function while it's > > not > > including in VDOSYS0. > > > > To summarize0: > > Only VDOSYS0 can support PQ adjustment. > > Only VDOSYS1 can support HDR adjustment. > > > > Therefore, we need to separate these two different mmsys hardwares > > to > > 2 different compatibles for MT8195. > > > > Fixes: 81c5a41d10b9 ("dt-bindings: arm: mediatek: mmsys: add mt8195 > > SoC binding") > > Signed-off-by: Jason-JH.Lin > > Signed-off-by: Bo-Chen Chen > > Acked-by: Krzysztof Kozlowski > > I'm not sure Krzysztof gave his Acked-by tag. I'll remove this tag. > > > --- > > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | > > 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > index 6ad023eec193..a53b32c0a608 100644 > > --- > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > +++ > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam > > l > > @@ -32,6 +32,8 @@ properties: > > - mediatek,mt8186-mmsys > > - mediatek,mt8192-mmsys > > - mediatek,mt8195-mmsys > > + - mediatek,mt8195-vdosys0 > > As I said in the last submission, we should make mediatek,mt8195- > mmsys as a > fallback of vdosys0. Actually mediatek,mt8195-mmsys is only used for > the > fallback of vdosys0. I think adding both vdosys0 and vdosys1 can make the description of this patch clearer. It's find to me to only add "mediatek,mt8195-vdosys0" in this patch. So I'll remove the "mediatek,mt8195-vdosys1" at the next version. Regards, Jason-JH.Lin > > Regards, > Matthias > > > + - mediatek,mt8195-vdosys1 > > - mediatek,mt8365-mmsys > > - const: syscon > > - items: > > -- Jason-JH Lin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel