From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F14C433E1 for ; Mon, 18 May 2020 22:30:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9867D207ED for ; Mon, 18 May 2020 22:30:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S+z0X/+o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9867D207ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CTr5xKSK0UD9obBcsA4rd8rTl2OiRvfSY32QJGqSb7U=; b=S+z0X/+o0ultGH Lhebj9A2g8rCizoBlVD0Mi8qC8Jjh+CgroFUzZGKUySTWCkI/BFsCF7tAK712+sNKkDEfguUfOtw3 Ekt7PQwFq/viEC3MSfkMX63NN30j9OXUf7++/Y+rh5PFpKu33cOi69TLLBpo9amu8Ms9ELMRVTsMh ixrnFBcZaw8S/IHYjlbGlYALKJAGLkIWhuJNqspU9Wv2XcXiN7Fkh1MjH7i05W69kgXvS3pTaQ0Bn MqJkyuMjSPQab7DQzrcJyekxKyLCuu56ZV8wNS2+/S7NGX4kvlybtcWJazbc6nGekQ5OjMoEvDgKQ 45pK2tYd4IHy8/P1koIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaoHO-0004a7-LE; Mon, 18 May 2020 22:30:38 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaoG1-0000vc-Tx; Mon, 18 May 2020 22:29:15 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaoFx-00007u-F7; Tue, 19 May 2020 00:29:09 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Johan Jonker , kever.yang@rock-chips.com, Caesar Wang Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: rk3399: fix pd_tcpc0 and pd_tcpc1 node position Date: Tue, 19 May 2020 00:29:08 +0200 Message-ID: <2978296.PvbIKR7951@diego> In-Reply-To: <20200428203003.3318-2-jbx6244@gmail.com> References: <20200428203003.3318-1-jbx6244@gmail.com> <20200428203003.3318-2-jbx6244@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_152914_021661_FC2A87CC X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kever, Caesar, could you double check where the type-c power-domains are located in the power-tree, as Caesar did add them under pd_vio back in 2016. Thanks Heiko Am Dienstag, 28. April 2020, 22:30:03 CEST schrieb Johan Jonker: > The pd_tcpc0 and pd_tcpc1 nodes are currently a sub node of pd_vio. > In the rk3399 TRM figure of the 'Power Domain Partition' and in the > table of 'Power Domain and Voltage Domain Summary' these power domains > are positioned directly under VD_LOGIC, so fix that in 'rk3399.dtsi'. > > Signed-off-by: Johan Jonker > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 37279db53..a4dc1bf2e 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1056,6 +1056,16 @@ > clocks = <&cru HCLK_SDIO>; > pm_qos = <&qos_sdioaudio>; > }; > + pd_tcpc0@RK3399_PD_TCPD0 { > + reg = ; > + clocks = <&cru SCLK_UPHY0_TCPDCORE>, > + <&cru SCLK_UPHY0_TCPDPHY_REF>; > + }; > + pd_tcpc1@RK3399_PD_TCPD1 { > + reg = ; > + clocks = <&cru SCLK_UPHY1_TCPDCORE>, > + <&cru SCLK_UPHY1_TCPDPHY_REF>; > + }; > pd_usb3@RK3399_PD_USB3 { > reg = ; > clocks = <&cru ACLK_USB3>; > @@ -1088,16 +1098,6 @@ > pm_qos = <&qos_isp1_m0>, > <&qos_isp1_m1>; > }; > - pd_tcpc0@RK3399_PD_TCPD0 { > - reg = ; > - clocks = <&cru SCLK_UPHY0_TCPDCORE>, > - <&cru SCLK_UPHY0_TCPDPHY_REF>; > - }; > - pd_tcpc1@RK3399_PD_TCPD1 { > - reg = ; > - clocks = <&cru SCLK_UPHY1_TCPDCORE>, > - <&cru SCLK_UPHY1_TCPDPHY_REF>; > - }; > pd_vo@RK3399_PD_VO { > reg = ; > #address-cells = <1>; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel