From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D439C76186 for ; Wed, 24 Jul 2019 17:16:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71D4E20840 for ; Wed, 24 Jul 2019 17:16:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TusSNNIv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71D4E20840 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jS8v1uuwvOPDCofOywPzPv71xi8ym+qrVR42ghAShgY=; b=TusSNNIv6YhZcC CkRkXbiyadBFkpt0tidYh3qtpmjMadMXz0BxRgKCXorYXTHAoKorN0n73mE9YUa9UwRPoePZZAJJB ZLQzZlIY7e6RsUNNvcplf8+R8zGhfyTO3Xry16lWFflJQheMgcGx0hoMI5qbcmETt1II9sEaFDXUr LTyEh7vx/UkXmbtxETxsMGXsvqVFOu1i80Y3iSWReFkP7x4/T+8YxpTwVv25eg9HPLAYYb/nfPWHM edjIzfSF8R5ZSKW41RbTmqhzdyBCAeGqLP1bQpAVJbpKSnB30YtYu0b/gevQrBz7TsbmJhiipvU27 1JijBo4RTCJ0QRFy5lBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqKsU-0001tO-Gn; Wed, 24 Jul 2019 17:16:34 +0000 Received: from smtprelay0250.hostedemail.com ([216.40.44.250] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqKsP-0001jn-W4 for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2019 17:16:31 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 034D818224D9C; Wed, 24 Jul 2019 17:16:25 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: brick72_54e3a62085009 X-Filterd-Recvd-Size: 1951 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Wed, 24 Jul 2019 17:16:23 +0000 (UTC) Message-ID: <2a0c5ef5c7e20b190156908991e4c964a501d80a.camel@perches.com> Subject: Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro From: Joe Perches To: Andrew Morton , Joel Stanley , Andrew Jeffery Date: Wed, 24 Jul 2019 10:16:22 -0700 In-Reply-To: References: User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190724_101630_108682_1722BCBC X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches > --- > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h > index a10358bb61ec..095ea03e5833 100644 > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); > /* CTRL2 */ > #define CRT_CTRL_DAC_EN BIT(0) > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & CRT_CTRL_VBLANK_LINE_MASK) > -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31) > +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20) ping? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel